Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(effects): Refactor types in effects, expose metadata key #2194

Merged
merged 1 commit into from
Nov 5, 2019
Merged

refactor(effects): Refactor types in effects, expose metadata key #2194

merged 1 commit into from
Nov 5, 2019

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

PR is based off #2190

What kind of change does this PR introduce?

  • Cleanup types within effects (remove any)
  • expose [CREATE_EFFECT_METADATA_KEY] key on the createEffect and clean up the tests.
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 30, 2019

Preview docs changes for c13aab5 at https://previews.ngrx.io/pr2194-c13aab5/

@timdeschryver
Copy link
Member

timdeschryver commented Nov 3, 2019

Seems like the commits are squashed in 1b70ff1 @alex-okrushko, was this the intention?
Asking because I'm not sure how we want to merge #2191, #2194, and #2195

refactor(effects): Refactor types in effects, expose metadata key for createEffect
@brandonroberts brandonroberts merged commit 4be5c37 into ngrx:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants