No logs about empty state for tests with mocked store #2420

evgenyfedorenko · 2020-03-02T02:20:46Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

This code adds an internal setting and a setter for mock store environment.
When set it suppresses the logs about the state which does not exist.

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Console warn logs numerous logs for mocked store which should not happen

Closes #2363

What is the new behavior?

Logs will be suppressed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Please take a look at this draft. I made some assumptions here which may not be true. Please comment.

Closes ngrx#2363

ngrxbot · 2020-03-02T02:29:49Z

Preview docs changes for 5c9bd12 at https://previews.ngrx.io/pr2420-5c9bd12/

Closes ngrx#2363

alex-okrushko · 2020-03-04T14:21:49Z

@evgenyfedorenko thanks. Tests would be nice as well 😁

alex-okrushko

Please add tests

evgenyfedorenko · 2020-03-04T14:45:11Z

@evgenyfedorenko thanks. Tests would be nice as well 😁

Was hoping this one will go unnoticed haha, jk.

timdeschryver · 2020-03-04T18:24:20Z

modules/store/src/index.ts

@@ -14,6 +14,7 @@ export {
 export { createAction, props, union } from './action_creator';
 export { Store, select } from './store';
 export { combineReducers, compose, createReducerFactory } from './utils';
+export { setNgrxMockEnvironment, isNgrxMockEnvironment } from './flags';


I suppose not, but is there a way to make the setNgrxMockEnvironment private?
This, to prevent the usage of it to disable the warning.

Closes ngrx#2417

Closes ngrx#2431

These checks are enabled by default in NgRx 9

…grx#2231) Closes ngrx#2232

…ata guide (ngrx#2428)

)

…ponent package (ngrx#2046)

…#2383) Closes ngrx#2334

Closes ngrx#2454

* fix(component): add docs overview closes ngrx#2442 * Update projects/ngrx.io/content/guide/component/index.md Co-Authored-By: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com> Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>

ngrx#2461)

Closes ngrx#2404

brandonroberts · 2020-04-26T18:48:14Z

@evgenyfedorenko What's the status on this? The PR needs to be rebased on master, and we still need some tests

evgenyfedorenko · 2020-04-26T19:53:55Z

Will try to take a look this week.

Closes ngrx#2363

…ko/platform into mockstore-logsless

Closes ngrx#2363

evgenyfedorenko · 2020-05-03T17:22:44Z

Added few tests.
@timdeschryver you asked to make this API private. It needs to be available in testing module as well as in store. How else I can share and not make it part of the public API ?

timdeschryver · 2020-05-03T18:14:24Z

@evgenyfedorenko I don't think it will be possible, it was an open question to ask if someone knew a way to do this.

brandonroberts · 2020-05-05T12:46:00Z

Something happened to the commits with the merge

evgenyfedorenko · 2020-05-05T15:17:08Z

Not sure what happened, should I recreate my changes on a new branch checked out from master?

timdeschryver · 2020-05-05T16:06:17Z

@evgenyfedorenko I think it should resolve itself if you rebase from master, but feel free to create a new branch if that's faster.

evgenyfedorenko · 2020-05-06T02:33:55Z

here is another PR with clean merge #2513

evgenyfedorenko added 2 commits March 1, 2020 21:05

feat(store): adding an internal setting _ngrxMockEnvironment

e6fe479

Closes ngrx#2363

Merge branch 'master' into mockstore-logsless

86b8a2a

brandonroberts and others added 2 commits March 2, 2020 10:58

chore: release 9.0.0-rc.0

94de612

refactor(entity): fix a 'setOne' test case (ngrx#2421)

f532826

brandonroberts requested a review from timdeschryver March 3, 2020 02:48

feat(store): removing the test

ea6a05c

Closes ngrx#2363

alex-okrushko requested changes Mar 4, 2020

View reviewed changes

timdeschryver reviewed Mar 4, 2020

View reviewed changes

brandonroberts and others added 4 commits March 4, 2020 21:08

docs(router-store): add missing selectCurrentRoute selector (ngrx#2425)

0d6b6af

chore: switch to Jest for unit tests (ngrx#2422)

fba0dda

feat(effects): add EffectsRunner to public API (ngrx#2427)

f66fd64

chore: release 9.0.0

dfb2787

timdeschryver added the WIP Not ready for review label Mar 9, 2020

AdditionAddict and others added 14 commits March 11, 2020 07:22

fix(example): optimistically add/remove book from collection (ngrx#2429)

b0aacf7

Closes ngrx#2417

docs(entity): clarify how entities update (ngrx#2432)

ba8154f

Closes ngrx#2431

ci: use disk cache for Bazel build (ngrx#2433)

5c7eb7d

docs: add link to version 8 docs (ngrx#2437)

b0ada45

refactor(example): remove immutability checks (ngrx#2438)

3e55dd5

These checks are enabled by default in NgRx 9

docs: fix capitalization in actions guide (ngrx#2439)

7598dc3

feat(effects): add user provided effects to EffectsModule.forFeature (n…

59ce3e2

…grx#2231) Closes ngrx#2232

docs(data): clarify step one and keep same class name in entity metad…

fdee3d8

…ata guide (ngrx#2428)

feat(schematics): export reducer directly when Ivy is enabled (ngrx#2440

b68fa67

)

feat(component): add ngrxPush pipe and ngrxLet directive to @ngrx/com…

464073d

…ponent package (ngrx#2046)

refactor(example): update loadCollection initialize action name (ngrx…

e41afe7

…#2383) Closes ngrx#2334

docs: add selector schematic to navigation (ngrx#2459)

7dc97f8

Closes ngrx#2454

ci: update cache key, remove cache key fallback (ngrx#2460)

e30cbe2

schuchard and others added 15 commits April 8, 2020 10:50

docs(component): spelling and grammar (ngrx#2479)

6a18359

ci: use hash of master branch for cache key (ngrx#2480)

4b0856a

ci: use bazel cache key first (ngrx#2481)

5b2f2d4

ci: don't use cache for deployment (ngrx#2482)

388017c

docs: fix import for search service worker (ngrx#2483)

81292b7

refactor(component): cleanup grouped files, docs, and deleted comments (

79ec1b4

ngrx#2461)

docs(data): fix compilation errors in example (ngrx#2490)

1925308

fix(router-store): selectors should return MemoizedSelector (ngrx#2492)

39a4b91

fix(store): ignore Ivy in runtime checks (ngrx#2491)

46d752f

Closes ngrx#2404

docs(entity): use setAll instead of deprecated addAll (ngrx#2484)

c210572

ci: fix cypress install for example e2e tests (ngrx#2499)

1f181e3

docs: fix the URL for installing with yarn (ngrx#2500)

236e9c9

ci: make saving of cache keys consistent (ngrx#2501)

935aa61

refactor(schematics): replace deprecated TestBed.get methods(ngrx#2503)

9b2f05e

refactor: replace deprecated TestBed.get (ngrx#2504)

470b788

evgenyfedorenko added 4 commits May 3, 2020 12:12

feat(store): adding an internal setting _ngrxMockEnvironment

2a7da63

Closes ngrx#2363

feat(store): removing the test

8432fc8

Closes ngrx#2363

Merge branch 'mockstore-logsless' of https://github.com/evgenyfedoren…

eee6543

…ko/platform into mockstore-logsless

feat(store): adding tests

5c9bd12

Closes ngrx#2363

evgenyfedorenko mentioned this pull request May 6, 2020

No logs about empty state for tests with mocked store #2513

Merged

3 tasks

evgenyfedorenko closed this May 6, 2020

evgenyfedorenko deleted the mockstore-logsless branch May 6, 2020 02:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No logs about empty state for tests with mocked store #2420

No logs about empty state for tests with mocked store #2420

evgenyfedorenko commented Mar 2, 2020

ngrxbot commented Mar 2, 2020 •

edited

Loading

alex-okrushko commented Mar 4, 2020

alex-okrushko left a comment

evgenyfedorenko commented Mar 4, 2020

timdeschryver Mar 4, 2020

brandonroberts commented Apr 26, 2020

evgenyfedorenko commented Apr 26, 2020

evgenyfedorenko commented May 3, 2020

timdeschryver commented May 3, 2020

brandonroberts commented May 5, 2020 •

edited

Loading

evgenyfedorenko commented May 5, 2020

timdeschryver commented May 5, 2020

evgenyfedorenko commented May 6, 2020

No logs about empty state for tests with mocked store #2420

No logs about empty state for tests with mocked store #2420

Conversation

evgenyfedorenko commented Mar 2, 2020

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

ngrxbot commented Mar 2, 2020 • edited Loading

alex-okrushko commented Mar 4, 2020

alex-okrushko left a comment

Choose a reason for hiding this comment

evgenyfedorenko commented Mar 4, 2020

timdeschryver Mar 4, 2020

Choose a reason for hiding this comment

brandonroberts commented Apr 26, 2020

evgenyfedorenko commented Apr 26, 2020

evgenyfedorenko commented May 3, 2020

timdeschryver commented May 3, 2020

brandonroberts commented May 5, 2020 • edited Loading

evgenyfedorenko commented May 5, 2020

timdeschryver commented May 5, 2020

evgenyfedorenko commented May 6, 2020

ngrxbot commented Mar 2, 2020 •

edited

Loading

brandonroberts commented May 5, 2020 •

edited

Loading