Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't select text by draging empty part when editing customBlock in wysiwyg mode #2048

Closed
z-950 opened this issue Nov 23, 2021 · 1 comment · Fixed by #2049
Closed

Can't select text by draging empty part when editing customBlock in wysiwyg mode #2048

z-950 opened this issue Nov 23, 2021 · 1 comment · Fixed by #2049
Labels
Bug
Milestone
v3.1.2

Comments

@z-950
Copy link
Contributor

z-950 commented Nov 23, 2021

Describe the bug

Can't select text by draging empty part when editing customBlock in wysiwyg mode. Draging empty part will emit drag event so that text can't be selected.

To Reproduce

Steps to reproduce the behavior:

  1. Change mode to wysiwyg
  2. Click the customBlock's edit button
  3. Draging the empty part in the customBlock's editable area.
  4. Text can not be selected, but dragging whole element.

Expected behavior

Text can be selected.

Additional context

version: 3.1.1
@z-950 z-950 added the Bug label Nov 23, 2021
@z-950 z-950 mentioned this issue Nov 23, 2021
Merged
6 tasks
@js87zz
Copy link
Contributor

js87zz commented Nov 25, 2021

@z-950
I checked the issue. I'll review the PR tomorrow. Thank you!! :)

js87zz pushed a commit that referenced this issue Dec 2, 2021
@z-950
fix: cannot select text when editing customBlock (#2049)
e9c8cc0 
* fix: empty tagBlacklist cause the editor to crash(#1678)

* fix: cannot select text when editing customBlock (#2048)
@js87zz js87zz added this to the v3.1.2 milestone Dec 10, 2021
ahamelers pushed a commit to ahamelers/tui.editor that referenced this issue Aug 21, 2023
@z-950
fix: cannot select text when editing customBlock (nhn#2049)
c57c3f2 
* fix: empty tagBlacklist cause the editor to crash(nhn#1678)

* fix: cannot select text when editing customBlock (nhn#2048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging a pull request may close this issue.

fix: cannot select text when editing customBlock
2 participants
@z-950 @js87zz