Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot select text when editing customBlock #2049

Merged
merged 4 commits into from
Dec 2, 2021
Merged

fix: cannot select text when editing customBlock #2049

merged 4 commits into from
Dec 2, 2021

Conversation

z-950
Copy link
Contributor

@z-950 z-950 commented Nov 23, 2021

fix #2048

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Fixed by set draggable to false when start editing. And draggable can be true at the time next click when it is not editable.

Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! :)

@js87zz js87zz merged commit e9c8cc0 into nhn:master Dec 2, 2021
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
* fix: empty tagBlacklist cause the editor to crash(nhn#1678)

* fix: cannot select text when editing customBlock (nhn#2048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select text by draging empty part when editing customBlock in wysiwyg mode
2 participants