fix: encode link url unnecessarily #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhrinae
reviewed
Jul 6, 2021
apps/editor/src/utils/encoder.ts
Outdated
Comment on lines
1
to
3
| const encodingRegExps = [/\(/g, /\)/g, /\[/g, /\]/g, /</g, />/g, / /g]; | ||
| const encodedList = ['%28', '%29', '%5B', '%5D', '%3C', '%3E', '%20']; | ||
| const escapedList = ['\\(', '\\)', '\\[', '\\]', '\\<', '\\>', ' ']; |
There was a problem hiding this comment.
배열들이 나란히 있어서 눈에 들어오긴 하는데, 각각의 encodingRegExp, encoded, escaped 가 한묶음씩 보인다면 가독성이 나아질지도 모르겠네요. 드물겠지만 새로운 변환 규칙 추가할 때 하나라도 빼먹는 것을 방지할 수 있겠고요. 막상 예제를 만들어보니까 코드 양이 좀 불필요하게 늘어나는 것 같긴 하지만요.
const encoderList = [
{
target: /\(/g,
result: { encoded: '%28', escaped: '\\(' }
},
// ...
];There was a problem hiding this comment.
더 복잡해지는 것 같아서 아래처럼 맵을 사용하되 좀 더 축약했습니다~
const encoderList = [
{
regExp: /\(/g,
encoded: '%28',
escaped: '\\(',
},
{
regExp: /\)/g,
encoded: '%29',
escaped: '\\)',
},
{
regExp: /\[/g,
encoded: '%5B',
escaped: '\\[',
},
{
regExp: /\]/g,
encoded: '%5D',
escaped: '\\]',
},
{
regExp: /</g,
encoded: '%3C',
escaped: '\\<',
},
{
regExp: />/g,
encoded: '%3E',
escaped: '\\>',
},
{
regExp: / /g,
encoded: '%20',
escaped: ' ',
},
];
js87zz
force-pushed
the
fix/encode-link-url
branch
from
3d7e36c to
d5d6c56
Compare
ahamelers
pushed a commit
to ahamelers/tui.editor
that referenced
this pull request
Aug 21, 2023
* fix: decode url when executing addImage, addLink command * chore: add test case(addImage, addLink) * chore: apply code review * refactor: assertToContainHTML function * chore: add test case(converting the html block which has "=" attr value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨