Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an 'autofocus' option that can disable initial focus (close #1730) #1772

Merged
merged 1 commit into from
Aug 30, 2021
Merged

feat: add an 'autofocus' option that can disable initial focus (close #1730) #1772

merged 1 commit into from
Aug 30, 2021

Conversation

azmeuk
Copy link
Contributor

@azmeuk azmeuk commented Aug 23, 2021 •
edited
Loading

Without this option, the editor always catches the focus on initialization, making it possibly incompatible with other elements on the page that also need the focus at startup.

The patch is really simple, I am not sure what test I could have written.

Fixes #1730

@azmeuk
feat: add an 'autofocus' option that can disable initial focus (close #…
f30c47e 
…1730)

Without this option, the editor always catches the focus on
initialization, making it possibly incompatible with other elements on
the page that also need the focus at startup.
@lucaslcode lucaslcode mentioned this pull request Aug 29, 2021
Closed
js87zz
js87zz approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@js87zz js87zz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azmeuk
Thanks for contributing :)
This PR will be included in next release.(maybe this week)

@js87zz js87zz merged commit 6bab7db into nhn:master Aug 30, 2021
@deezaster
Copy link

deezaster commented Sep 6, 2021 •
edited
Loading

I am very (urgent) interested of the cdn-version: https://uicdn.toast.com/editor/latest/toastui-editor-all.min.js

@js87zz
Copy link
Contributor

js87zz commented Sep 7, 2021

@lizy0329 @deezaster
The autofocus option has been added in v3.1.0.

@danline
Copy link

danline commented Sep 30, 2021

I am setting autofocus=false in the options but it still focuses on the editor when editor loads. Is my understanding correct in that autofocus=false should disable it?

@js87zz
Copy link
Contributor

js87zz commented Sep 30, 2021

@Daniel-Sudhindaran
Yes. If you have an issue about it, please write the issue here. Thanks!

@azmeuk azmeuk mentioned this pull request Nov 19, 2021
Closed
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@azmeuk
feat: add an 'autofocus' option that can disable initial focus (close n…
105c296 
…hn#1730) (nhn#1772)

Without this option, the editor always catches the focus on
initialization, making it possibly incompatible with other elements on
the page that also need the focus at startup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js87zz js87zz js87zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to cancel auto focus after initialization?
4 participants
@azmeuk @deezaster @js87zz @danline