feat: Added a focus
parameter to the setMarkdown
and setHTML
functions
#2030
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1772 introduced a
focus
parameter to themoveCursorToEnd
function.Now I encounter the need to not take the focus when setting markdown in the editor, hence I added a
focus
parameter to thesetMarkdown
andsetHTML
functions, defaulted totrue
, that is passed tomoveCursorToEnd
.The
autofocus
parameter introduced in #1772 is also passed tosetMarkdown
orsetHTML
during the editor constructor to ensure cursor is not taken by the editor ifautofocus
isfalse
. I think this may help with #1945 and #1802, because without this patch, if the editor is initialized with data it still takes the focus.I am not really sure how to test this so I did not write any, but please let me know if you think this is important.
ping @js87zz