Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #2572 (fix #1806 #2708) #2754

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

kshnurov
Copy link
Contributor

see #2742

@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Oct 30, 2022
@stale
Copy link

stale bot commented Nov 12, 2022

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this Nov 12, 2022
@kshnurov
Copy link
Contributor Author

@jajugoguma @jwlee1108 anyone?

@jwlee1108
Copy link
Contributor

@kshnurov Our team was having a pretty busy time. I'm sorry for not responding to your issue properly. We will review this issue internally and share it with you.

@jwlee1108 jwlee1108 reopened this Dec 19, 2022
@stale stale bot removed inactive labels Dec 19, 2022
Copy link
Contributor

@jajugoguma jajugoguma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, reverting the previous fix seems right. So this pull request is approved and merged. Thanks for your contribution!

@jajugoguma jajugoguma merged commit 2f0cbb5 into nhn:master Feb 16, 2023
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants