-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: non-spec emphasis (fix #1806 #2708) #2742
Conversation
@jajugoguma check, please. |
c0f717b
to
8f7b53f
Compare
8f7b53f
to
71e3d22
Compare
After doing some testing I've found some very common cases that are completely broken either in master:
or in this PR:
Looking at how this editor works with marks and opening/closing tags I don't think it's possible to fix that without a major rework.
@jwlee1108 @jajugoguma what do you think? If you agree, please revert #2572 and release a new version. |
@jwlee1108 @jajugoguma it's been a month, how's it going? :) |
@jwlee1108 @jajugoguma 2 months. There's 200+ issues labeled as bug. Shouldn't this repo be marked as unmaintained, so people won't rely on it in production? |
Until this gets resolved: nhn/tui.editor#2742
Until this gets resolved: nhn/tui.editor#2742
Resolved in #2754 |
#2572 introduced a dirty fix for a very rare non-spec emphasis and lead to many regular emphasis being replaced with html tags, which is no good (#1806 #2708).
This PR fixes that by making sure only non-compliant emphasis will be replaced with html tags.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)