Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent to remove heading tag when press the enter key(fix #872) #888

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Apr 7, 2020

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@js87zz js87zz requested review from dongwoo-kim and seonim-ryu April 7, 2020 03:24
domUtils.getParentUntil(range.startContainer, this.wwe.getBody()),
element
element,
domUtils.getParentUntil(range.startContainer, this.wwe.getBody())
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_insertEmptyBlockToPrevious 테스트를 하는건 좀 무리일까요ㅎㅎ

@seonim-ryu
Copy link
Member

seonim-ryu commented Apr 8, 2020

[4/8] 리뷰 완료! 간단하게 처리되었네요 👍 타이틀에 이슈 번호만 추가해주시면 될 것 같습니다ㅎ

fix: prevent to remove heading tag when press the enter key (fix #872)

@js87zz js87zz changed the title fix: prevent to remove heading tag when press the enter key fix: prevent to remove heading tag when press the enter key(fix #872) Apr 13, 2020
@js87zz js87zz merged commit e306fe8 into master Apr 13, 2020
@js87zz js87zz deleted the fix/wysiwyg-heading-removal-bug branch April 13, 2020 07:19
@seonim-ryu seonim-ryu added this to the 2.1.0 milestone Apr 23, 2020
@seonim-ryu seonim-ryu added the Bug label Apr 23, 2020
js87zz pushed a commit that referenced this pull request Jun 17, 2021
fix: [FE개발랩-TUI에디터/13] 마크다운 에디터 입력한 글자를 코드블럭 지정시 코드블럭 위치가 이상함
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants