Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent to remove heading tag when press the enter key(fix #872) #888

Merged
merged 1 commit into from
Apr 13, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/editor/src/js/wwHeadingManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ class WwHeadingManager {
const element = domUtils.createElementWith('<div><br></div>');

domUtils.insertBefore(
domUtils.getParentUntil(range.startContainer, this.wwe.getBody()),
element
element,
domUtils.getParentUntil(range.startContainer, this.wwe.getBody())
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_insertEmptyBlockToPrevious 테스트를 하는건 좀 무리일까요ㅎㅎ

}

Expand Down