-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove node polyfills no longer needed for rich text components (#2195)
# Pull Request ## 🤨 Rationale Fixes #1700 These two polyfills were added in #1335 because markdown-it implicitly depended on some functionality that existed in Node but not browser environments. We've since upgraded markdown-it to a version that expresses those dependencies on normal npm packages, so the polyfills are no longer needed. markdown-it/markdown-it#967 ## 👩💻 Implementation Remove rollup plugins and npm dependencies on those plugins that were added in #1335. ## 🧪 Testing Mostly depending on PR build but also spot checking rich text functionality in storybook. ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
- Loading branch information
Showing
7 changed files
with
18 additions
and
87 deletions.
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@ni-nimble-components-3e442ad0-bc5a-4afd-8733-816aa647697b.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "Remove unneeded rollup dependencies", | ||
"packageName": "@ni/nimble-components", | ||
"email": "jattasNI@users.noreply.github.com", | ||
"dependentChangeType": "patch" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@ni-spright-components-4e09e3fc-c683-4f1b-8eae-2d71ab8fa981.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "patch", | ||
"comment": "Remove unneeded rollup dependencies", | ||
"packageName": "@ni/spright-components", | ||
"email": "jattasNI@users.noreply.github.com", | ||
"dependentChangeType": "patch" | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters