Remove node polyfills no longer needed for rich text components #2195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes #1700. These two polyfills were added in #1335 because markdown-it implicitly depended on some functionality that existed in Node but not browser environments. We've since upgraded markdown-it to a version that expresses those dependencies on normal npm packages, so the polyfills are no longer needed.
markdown-it/markdown-it#967
👩💻 Implementation
Remove rollup plugins and npm dependencies on those plugins that were added in #1335.
🧪 Testing
Mostly depending on PR build but also spot checking rich text functionality in storybook.
✅ Checklist