Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit conversion from float-string to int is deprecated #14

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

thisispiers
Copy link
Contributor

@thisispiers thisispiers requested a review from nickbeen as a code owner July 20, 2023 21:32
@nickbeen nickbeen added the good first issue Good for newcomers label Sep 18, 2023
@nickbeen
Copy link
Owner

There is no explicit conversion of float-string to integer since number_format casts the percentage to a string. Are you trying to use the percentage value in your application?

@everton3x
Copy link

I got an error like this trying to use ProgressBar. All it took was to change the code of line 228 according to the change in the PR and everything started to work properly.

Any reason PR isn't merged yet?

@nickbeen
Copy link
Owner

nickbeen commented Apr 8, 2024

This PR isn't merged yet, because:

  1. There is no example (preferably with stack trace) of the notice provided
  2. There is no test of this PR provided
  3. This PR only touches setPercentage(); similar methods like setProgress() and setMaxProgress() may trigger the same notice
  4. Other functionality may be affected like the console output

I'm working on a complete fix, so I'll merge this PR for now.

@nickbeen nickbeen merged commit 036f0f9 into nickbeen:main Apr 8, 2024
7 checks passed
@nickbeen nickbeen added the fixed For any bug fixes label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed For any bug fixes good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants