Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full support for floating values without implicit conversion #16

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

nickbeen
Copy link
Owner

@nickbeen nickbeen commented Apr 8, 2024

What does this pull request do?

This PR adds a full fix for deprecation notices about implicit conversions of floating values losing precision. #14 was a partial fix for this issue.

Why is this pull request needed?

Implicit conversion of floating values will trigger deprecation notices in PHP 8.1 or newer.

How does this pull request work?

This PR adds explicit conversion of floating values where applicable.

@nickbeen nickbeen added the fixed For any bug fixes label Apr 8, 2024
@nickbeen nickbeen merged commit 6562183 into main Apr 8, 2024
7 checks passed
@nickbeen nickbeen deleted the float-conversion-patch branch April 8, 2024 15:28
@nickbeen nickbeen restored the float-conversion-patch branch April 8, 2024 15:29
@nickbeen nickbeen deleted the float-conversion-patch branch April 8, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed For any bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant