For custom High/low into WIP #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
customHigh and customLow entries
Default set to 180/80. can be overridden by user in Settings.
Substituted customHigh/Low for targetTop/Bottom. Alarm function still does not "take" the custom values... still rings at 180/80 only. Storage from browserSettings, this allows for multiple devices looking at same website to customize their levels. if set Server-Side then you can have continuity across all devices, but less flexibility if you have different monitors for Night/Day.
|
Before when I suggested that this might make sense in the wip/iob/cob branch it was to make use of the new profile collection. If it's going to be per device and client side only it could target dev, but I'm worried it will create confusion. I made almost the same changes before and the rest of the team asked that I not include them in the brownie release. If we continue with this we'll also need to support mmol targets |
|
most of this should be covered by #305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.