Alarm / Threshold updates (and some other UI updates...) #305

jasoncalabrese · 2014-12-19T20:45:08Z

Many users don't understand the current Loss/PredictAR based alarms, they also want to be able to set their own target range instead of the default 80-180.

This PR aims to make the target range and alarm types configurable, this should address most of #271. To do this 5 new ENV variables have been added.

BG_HIGH - default: 260, the high BG outside the target range that is considered urgent
BG_TARGET_TOP - default: 180, the top of the target range, also used to draw the line on the chart
BG_TARGET_BOTTOM - default: 80, the bottom of the target range, also used to draw the line on the chart
BG_LOW - default: 55, the low BG outside the target range that is considered urgent
ALARM_TYPES - default to simple if any BG_* ENV's are set, otherwise default to predict. There currently 2 alarm types are supported, and can be used independently are separately. The simple alarm type only compares the current BG to BG_ thresholds above, the predict alarm type works as before by using a highly tuned formula that forecasts where the BG is going based on it's trend.

…o the server and api

…e get basic settings from api

scottleibrand · 2014-12-19T20:57:25Z

Do we really want to change the default behavior, and require an ENV variable to restore the previous default? Seems better to only change the alarm type if custom thresholds are defined

Scott

On Dec 19, 2014, at 12:45 PM, Jason Calabrese notifications@github.com wrote:

Maybe users don't understand the current Loss/PredictAR based alarms, they also want to be able to set their own target range instead of the default 80-180.

This PR aims to make the target range and alarm types configurable. To do this 5 new ENV variables have been added.

BG_HIGH - default: 240, the high BG outside the target range that is considered urgent
BG_TARGET_TOP - default: 180, the top of the target range, also used to draw the line on the chart
BG_TARGET_BOTTOM - default: 70, the bottom of the target range, also used to draw the line on the chart
BG_LOW - default: 55, the low BG outside the target range that is considered urgent
ALARM_TYPES - default: simple, currently 2 alarm types are supported, and can be used independently are separately. The simple alarm type only compares the current BG to BG_ thresholds above, the predict alarm type works as before by using a highly tuned formula that forecasts where the BG is going based on it's trend.
You can merge this Pull Request by running

git pull https://github.com/nightscout/cgm-remote-monitor wip/jingle-bells
Or view, comment on, or merge it at:

#305

Commit Summary

read BG thresholds and alarm types from ENV and make them available to the server and api
read BG thresholds from api; refactor init so that it happend after we get basic settings from api
emit alarms based on ENV ALARM_TYPES (simple and predict)
updated BG_HIGH default to 240
File Changes

M env.js (9)
M lib/api/index.js (2)
M lib/api/status.js (1)
M lib/websocket.js (45)
M static/js/client.js (519)
M static/js/ui-utils.js (22)
Patch Links:

https://github.com/nightscout/cgm-remote-monitor/pull/305.patch
https://github.com/nightscout/cgm-remote-monitor/pull/305.diff
—
Reply to this email directly or view it on GitHub.

jasoncalabrese · 2014-12-19T21:03:06Z

@scottleibrand I've been trying to decide on that. I think most users expect an alarm below the line on the chart. The easy approach would be to default ALARM_TYPES to "predict" or even "simple predict".

jasoncalabrese · 2014-12-19T21:05:37Z

Also thinking about drawing a line at BG_HIGH and BG_LOW, then green in target, yellow between target and BG_HIGH/BG_LOW, and red above and below. With that urgent is red and normal is yellow.

scottleibrand · 2014-12-19T21:05:47Z

IMO, if a user sets a threshold, it should simply alarm at that threshold unless they specify to predict. If the user does nothing, the current behavior should not change: some people rely on Nightscout "alarming sooner" than Dexcom.

Scott

On Dec 19, 2014, at 1:03 PM, Jason Calabrese notifications@github.com wrote:

@scottleibrand I've been trying to decide on that. I think most users expect an alarm below the line on the chart. The easy approach would be to default ALARM_TYPES to "predict" or even "simple predict".

—
Reply to this email directly or view it on GitHub.

jasoncalabrese · 2014-12-19T21:07:03Z

I'll go with that for now

also some cleanup of the int ENV parsing

raven569 · 2014-12-19T22:38:32Z

Where do we need to setup the ENV to use this? On the code env.js or in
azure?

Rob
On Dec 19, 2014 2:45 PM, "Jason Calabrese" notifications@github.com wrote:

Maybe users don't understand the current Loss/PredictAR based alarms, they
also want to be able to set their own target range instead of the default
80-180.

This PR aims to make the target range and alarm types configurable. To do
this 5 new ENV variables have been added.

BG_HIGH - default: 240, the high BG outside the target range that
is considered urgent

BG_TARGET_TOP - default: 180, the top of the target range, also
used to draw the line on the chart

BG_TARGET_BOTTOM - default: 70, the bottom of the target range,
also used to draw the line on the chart

BG_LOW - default: 55, the low BG outside the target range that is
considered urgent

ALARM_TYPES - default: simple, currently 2 alarm types are
supported, and can be used independently are separately. The simple
alarm type only compares the current BG to BG_ thresholds above, the
predict alarm type works as before by using a highly tuned formula
that forecasts where the BG is going based on it's trend.

You can merge this Pull Request by running

git pull https://github.com/nightscout/cgm-remote-monitor wip/jingle-bells

Or view, comment on, or merge it at:

#305
Commit Summary

read BG thresholds and alarm types from ENV and make them available
to the server and api

read BG thresholds from api; refactor init so that it happend after
we get basic settings from api

emit alarms based on ENV ALARM_TYPES (simple and predict)

updated BG_HIGH default to 240

File Changes

M env.js
https://github.com/nightscout/cgm-remote-monitor/pull/305/files#diff-0
(9)

M lib/api/index.js
https://github.com/nightscout/cgm-remote-monitor/pull/305/files#diff-1
(2)

M lib/api/status.js
https://github.com/nightscout/cgm-remote-monitor/pull/305/files#diff-2
(1)

M lib/websocket.js
https://github.com/nightscout/cgm-remote-monitor/pull/305/files#diff-3
(45)

M static/js/client.js
https://github.com/nightscout/cgm-remote-monitor/pull/305/files#diff-4
(519)

M static/js/ui-utils.js
https://github.com/nightscout/cgm-remote-monitor/pull/305/files#diff-5
(22)

Patch Links:

https://github.com/nightscout/cgm-remote-monitor/pull/305.patch

https://github.com/nightscout/cgm-remote-monitor/pull/305.diff

—
Reply to this email directly or view it on GitHub
#305.

jasoncalabrese · 2014-12-19T22:40:37Z

@raven569 you can set them in the Azure settings, just like the ENV vars used here: http://www.nightscout.info/wiki/labs/cgm-remote-monitor-care-portal

raven569 · 2014-12-19T22:42:47Z

So have to add all 5 variables?

Rob
On Dec 19, 2014 4:40 PM, "Jason Calabrese" notifications@github.com wrote:

@raven569 https://github.com/raven569 you can set them in the Azure
settings, just like the ENV vars used here:
http://www.nightscout.info/wiki/labs/cgm-remote-monitor-care-portal

—
Reply to this email directly or view it on GitHub
#305 (comment)
.

raven569 · 2014-12-19T22:45:25Z

Sot just add ALARM_TYPES and predict in azure yes?

Rob
On Dec 19, 2014 4:40 PM, "Jason Calabrese" notifications@github.com wrote:

@raven569 https://github.com/raven569 you can set them in the Azure
settings, just like the ENV vars used here:
http://www.nightscout.info/wiki/labs/cgm-remote-monitor-care-portal

—
Reply to this email directly or view it on GitHub
#305 (comment)
.

jasoncalabrese · 2014-12-19T22:46:01Z

All the new settings have a default, so you only need to change the ones you want.

For example if you like the default BG_* thresholds, but if you wanted simple alarms you could just set ALARM_TYPES="simple"

raven569 · 2014-12-19T22:50:22Z

I want the 240 and turn off the 180. Code has bottom at 80 not 70? Want the
55 on and 80 off.

Rob
On Dec 19, 2014 4:46 PM, "Jason Calabrese" notifications@github.com wrote:

All the new setting have a default, so you only need to change the ones
you want.

For example if you like the default BG_* thresholds, but if you wanted
simple alarms you could just set ALARM_TYPES="simple"

—
Reply to this email directly or view it on GitHub
#305 (comment)
.

jasoncalabrese · 2014-12-19T22:53:29Z

It's probably best to set all the env vars, then you don't have to remember what the defaults are.

Notes above were wrong 70 vs 80, thanks for catching it, fixing

raven569 · 2014-12-19T22:55:33Z

OK so how set all? Just put predict ? Or do u call each one?

Rob
On Dec 19, 2014 4:53 PM, "Jason Calabrese" notifications@github.com wrote:

It's probably best to set all the env vars, then you don't have to
remember what the defaults are.

Notes above were wrong 70 vs 80, thanks for catching it, fixing

—
Reply to this email directly or view it on GitHub
#305 (comment)
.

bewest · 2014-12-19T23:56:46Z

lib/websocket.js

+            var lastBG = actual[actualLength].y;
+
+            if (lastBG > env.thresholds.bg_high) {
+                emitAlarmType = 'urgent_alarm';


Let's not conflate urgent and high.
This should be a high alarm type not urgent, right?

Jason stipulated two high thresholds: a "high end of target range"
threshold (default 180), which would trigger a standard alarm, and a
"urgent high" threshold (default 240) that would trigger an urgent alarm.
Similar on the low end (80 and 55 IIRC).

Does that paradigm make sense to you? Do you have any suggestions for a
better way to approach it?

On Fri, Dec 19, 2014 at 3:56 PM, Ben West notifications@github.com wrote:

In lib/websocket.js
#305 (diff)
:

@@ -238,20 +238,42 @@ function loadData() {
emitData( );
}

// compute current loss

var avgLoss = 0;

var size = Math.min(predicted.length - 1, 6);

for (var j = 0; j <= size; j++) {

avgLoss += 1 / size \* Math.pow(log10(predicted[j].y / 120), 2);

var emitAlarmType = null;

if (env.alarm_types.indexOf("simple") > -1) {

var lastBG = actual[actualLength].y;

if (lastBG > env.thresholds.bg_high) {

emitAlarmType = 'urgent_alarm';

Let's not conflate urgent and high.
This should be a high alarm type not urgent, right?

—
Reply to this email directly or view it on GitHub
https://github.com/nightscout/cgm-remote-monitor/pull/305/files#r22136552
.

I was attempting to not change the current normal/urgent alarms levels, since adding extra levels will make snooze more complicated.

There are still issues to work out with the High/Low setting on the client. The easy thing to do is make them say Urgent/Normal, but I don't think thats what people want.

…as yellow and urgent as red; some clean up

jasoncalabrese · 2014-12-20T08:26:19Z

Lots of updates

Added settings to enable/disable the different alarms types:

Normal alarms are now yellow, urgent alarms are red:

Now showing 4 lines (high/low are lighter), red is now for urgent high/low, with yellow in-between red and green:

jasoncalabrese · 2014-12-20T16:26:59Z

@scottleibrand I'm wondering if the default for ALARM_TYPES should be "simple predict", then you'd get the hybrid mode. I'll see what everyone else thinks after testing this.

ELUTE · 2014-12-22T19:48:16Z

Agreed. Would love to see that!

Sent from my iPad

On Dec 22, 2014, at 2:35 PM, Jim Sifferle notifications@github.com wrote:

@jasoncalabrese So far so good on Jingle Bells alarms.

Should CP entries w/o carbs or insulin still show up in their previous position as a grey dot above the trend line? Would you consider putting BG checks on the trend line, positioned at the tested BG #? It could be colored green/yellow/red depending on where it sits in the alarm thresholds... or just a static color. What about other types of CP entries?

—
Reply to this email directly or view it on GitHub.

jasoncalabrese · 2014-12-22T19:52:37Z

I think we need a BG dot for 3 types: calibration, meter(ShugaTrak), and BG check(manual, care portal)

Thinking same red dot with different border

raven569 · 2014-12-22T19:53:02Z

BG checks would be interesting... If they were shown on position of BG
check value at time... See diff in Dex vs BG values.

Rob
On Dec 22, 2014 1:48 PM, "Kate Farnsworth" notifications@github.com wrote:

Agreed. Would love to see that!

Sent from my iPad

On Dec 22, 2014, at 2:35 PM, Jim Sifferle notifications@github.com
wrote:

@jasoncalabrese So far so good on Jingle Bells alarms.

Should CP entries w/o carbs or insulin still show up in their previous
position as a grey dot above the trend line? Would you consider putting BG
checks on the trend line, positioned at the tested BG #? It could be
colored green/yellow/red depending on where it sits in the alarm
thresholds... or just a static color. What about other types of CP entries?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#305 (comment)
.

jasoncalabrese · 2014-12-22T20:01:47Z

I have the code to estimate BG position by time, so we could put everything on the trend line, but I think it could get crowded. Some events like basal and activity make sense at the top.

jimsiff · 2014-12-22T22:57:18Z

@jasoncalabrese Should there be different sized dots for different CP entry types? I see a large dot for a standard meal bolus, medium dots for a split entry (prebolus) and smaller dots for an insulin correction.

Edit: Or is the CP dot size related to the amount of carbs / insulin given?

jasoncalabrese · 2014-12-23T04:47:08Z

Yes, the size is relative, it would work even better if it knew the actual carb ratio that was used.

…etc)

… read when overlaping other elements

jasoncalabrese · 2014-12-24T01:15:43Z

@bewest you'll like 38f755e, found the fix on @ldesboro's site :)

rnpenguin · 2014-12-24T03:59:59Z

nice :)

…re's glucose make it look similar to a calibration

trhodeos · 2015-01-03T19:32:57Z

static/css/main.css

@@ -238,6 +242,11 @@ div.tooltip {
    font-size: 70%;
  }

+  html body #bgButton {


html body is unnecessary.

Also, should this be merged with the #bgButton rule on line 153?

bewest · 2015-01-03T20:33:15Z

Looking good.

trhodeos · 2015-01-04T18:44:15Z

Added a few comments. Looks good otherwise.

…ries for a couple of edge cases

jasoncalabrese · 2015-01-05T07:05:44Z

@trhodeos thanks for the code review, think I took care of those issues

I merged this to my prod branch and will be using it all day tomorrow, if there aren't any new issues I plan to merge tomorrow.

Alarm / Threshold updates (and some other UI updates...)

Jason Calabrese added 4 commits December 19, 2014 11:48

read BG thresholds and alarm types from ENV and make them available t…

bd06646

…o the server and api

read BG thresholds from api; refactor init so that it happend after w…

3e745f9

…e get basic settings from api

emit alarms based on ENV ALARM_TYPES (simple and predict)

b38fdab

updated BG_HIGH default to 240

82d70a1

jasoncalabrese added the in progress label Dec 19, 2014

jasoncalabrese changed the title ~~Alarm / Threshold updates~~ Alarm / Threshold updates, for #271 Dec 19, 2014

jasoncalabrese changed the title ~~Alarm / Threshold updates, for #271~~ Alarm / Threshold updates Dec 19, 2014

jasoncalabrese self-assigned this Dec 19, 2014

Jason Calabrese added 2 commits December 19, 2014 13:17

cleanup

deb5e81

preseve current behavior is new BG_* and ALARM_TYPES ENV isn't set

da1ab49

also some cleanup of the int ENV parsing

bewest reviewed Dec 19, 2014
View reviewed changes

Jason Calabrese added 2 commits December 20, 2014 00:17

draw 2 extra lines for the high/low thresholds; dispay normal alarms …

0df8650

…as yellow and urgent as red; some clean up

changed default of BG_HIGH to 260

86c5af7

some more display adjustments for short-landscape mode

f59b2bf

make an errorCode based alarm count as a low

e66acdd

Jason Calabrese added 3 commits December 23, 2014 10:00

adjust the radius of the focus dots on transistion also (for rotate, …

eb3c63f

…etc)

added some text-shadow for carb/insulin amount to make them easier to…

de7ddfa

… read when overlaping other elements

move the context NOW line when scrolling

38f755e

Jason Calabrese added 2 commits December 26, 2014 23:27

draw non-insulin/carbs treatment circles on the trendline too, if the…

ac2f6a4

…re's glucose make it look similar to a calibration

Nightscout NOT NightScout

53d4997

trhodeos reviewed Jan 3, 2015
View reviewed changes

corrected some issues found in code review; improved use of media que…

bfcbda8

…ries for a couple of edge cases

jasoncalabrese added a commit that referenced this pull request Jan 6, 2015

Merge pull request #305 from nightscout/wip/jingle-bells

14d5568

Alarm / Threshold updates (and some other UI updates...)

jasoncalabrese merged commit 14d5568 into dev Jan 6, 2015

jasoncalabrese removed the in progress label Jan 6, 2015

This was referenced Jan 6, 2015

For custom High/low into WIP #202

Closed

Alarms #60

Closed

jasoncalabrese deleted the wip/jingle-bells branch January 6, 2015 07:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alarm / Threshold updates (and some other UI updates...) #305

Alarm / Threshold updates (and some other UI updates...) #305

jasoncalabrese commented Dec 19, 2014

scottleibrand commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

scottleibrand commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

raven569 commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

bewest Dec 19, 2014

scottleibrand Dec 20, 2014

jasoncalabrese Dec 20, 2014

jasoncalabrese commented Dec 20, 2014

jasoncalabrese commented Dec 20, 2014

ELUTE commented Dec 22, 2014

jasoncalabrese commented Dec 22, 2014

raven569 commented Dec 22, 2014

jasoncalabrese commented Dec 22, 2014

jimsiff commented Dec 22, 2014

jasoncalabrese commented Dec 23, 2014

jasoncalabrese commented Dec 24, 2014

rnpenguin commented Dec 24, 2014

trhodeos Jan 3, 2015

trhodeos Jan 3, 2015

bewest commented Jan 3, 2015

trhodeos commented Jan 4, 2015

jasoncalabrese commented Jan 5, 2015

Alarm / Threshold updates (and some other UI updates...) #305

Alarm / Threshold updates (and some other UI updates...) #305

Conversation

jasoncalabrese commented Dec 19, 2014

scottleibrand commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

scottleibrand commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

raven569 commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

jasoncalabrese commented Dec 19, 2014

raven569 commented Dec 19, 2014

bewest Dec 19, 2014

Choose a reason for hiding this comment

scottleibrand Dec 20, 2014

Choose a reason for hiding this comment

jasoncalabrese Dec 20, 2014

Choose a reason for hiding this comment

jasoncalabrese commented Dec 20, 2014

jasoncalabrese commented Dec 20, 2014

ELUTE commented Dec 22, 2014

jasoncalabrese commented Dec 22, 2014

raven569 commented Dec 22, 2014

jasoncalabrese commented Dec 22, 2014

jimsiff commented Dec 22, 2014

jasoncalabrese commented Dec 23, 2014

jasoncalabrese commented Dec 24, 2014

rnpenguin commented Dec 24, 2014

trhodeos Jan 3, 2015

Choose a reason for hiding this comment

trhodeos Jan 3, 2015

Choose a reason for hiding this comment

bewest commented Jan 3, 2015

trhodeos commented Jan 4, 2015

jasoncalabrese commented Jan 5, 2015