nightwatch test-observability integration phase-1 #5

grkpranaykumar · 2023-03-29T12:01:23Z

No description provided.

nightwatch/globals.js

src/utils/requestQueueHandler.js

src/utils/helper.js

nightwatch/globals.js

swrdfish · 2023-03-30T20:24:59Z

src/utils/helper.js

+    console.log(`Getting ${module} from ${GLOBAL_MODULE_PATH}`);
+
+    const global_path = path.join(GLOBAL_MODULE_PATH, module);
+    if (!fs.existsSync(global_path)) {


No sure if looking for nightwatch in the global path is a good idea.

@gravityvi thoughts?

src/utils/helper.js

src/utils/requestQueueHandler.js

swrdfish · 2023-04-18T18:02:19Z

nightwatch/globals.js

+          }
+        }
+      } catch (error) {
+        console.log(`nightwatch-browserstack-plugin: Something went wrong in processing report file for test observability - ${error}`);


create a helper function for logs.

src/testObservability.js

nightwatch/globals.js

src/testObservability.js

src/utils/helper.js

src/testObservability.js

swrdfish · 2023-05-09T14:02:49Z

src/testObservability.js

+            await this.sendTestRunEvent(eventData, testFileReport, 'HookRunStarted', globalBeforeEachHookId, 'GLOBAL_BEFORE_EACH', sectionName);
+            if (eventData.httpOutput && eventData.httpOutput.length > 0) {
+              for (let i=0; i<eventData.httpOutput.length; i+=2) {
+                await this.createHttpLogEvent(eventData.httpOutput[i], eventData.httpOutput[i+1], globalBeforeEachHookId);
+              }
+            }
+            await this.sendTestRunEvent(eventData, testFileReport, 'HookRunFinished', globalBeforeEachHookId, 'GLOBAL_BEFORE_EACH', sectionName);


this section is repeated again and again, extract is out into a function

nightwatch/globals.js

src/utils/helper.js

swrdfish · 2023-05-09T14:17:39Z

src/utils/helper.js

+    let data = eventData; 
+    let event_api_url = 'api/v1/event';
+
+    exports.requestQueueHandler.start();


This is does not make sense.

requestQueueHandler seems to be a singleton, this state management should be in requestQueueHandler.js itself.

src/utils/helper.js

src/testObservability.js

src/utils/requestQueueHandler.js

vaibhavsingh97 · 2023-05-09T14:56:10Z

src/utils/crashReporter.js

+  static filterPII(settings) {
+    const configWithoutPII = JSON.parse(JSON.stringify(settings));
+    if (configWithoutPII['@nightwatch/browserstack'] && configWithoutPII['@nightwatch/browserstack'].test_observability) {
+      this.deletePIIKeysFromObject(configWithoutPII['@nightwatch/browserstack'].test_observability);
+    }
+    if (configWithoutPII.desiredCapabilities && configWithoutPII.desiredCapabilities['bstack:options']) {
+      this.deletePIIKeysFromObject(configWithoutPII.desiredCapabilities['bstack:options']);
+    }
+    return configWithoutPII;
+  }


deletePIIKeysFromObject is defined as static and only being used in filterPII, so we can include the delete functionality in filterPII itself.

Suggested change

static filterPII(settings) {

const configWithoutPII = JSON.parse(JSON.stringify(settings));

if (configWithoutPII['@nightwatch/browserstack'] && configWithoutPII['@nightwatch/browserstack'].test_observability) {

this.deletePIIKeysFromObject(configWithoutPII['@nightwatch/browserstack'].test_observability);

}

if (configWithoutPII.desiredCapabilities && configWithoutPII.desiredCapabilities['bstack:options']) {

this.deletePIIKeysFromObject(configWithoutPII.desiredCapabilities['bstack:options']);

}

return configWithoutPII;

}

static filterPII(settings) {

const keysToDelete = ['user', 'username', 'userName', 'key', 'accessKey'];

const configWithoutPII = JSON.parse(JSON.stringify(settings));

const deleteKeys = (obj) => {

if (!obj) {

return;

}

keysToDelete.forEach(key => delete obj[key]);

}

if (configWithoutPII['@nightwatch/browserstack'] && configWithoutPII['@nightwatch/browserstack'].test_observability) {

deleteKeys(configWithoutPII['@nightwatch/browserstack'].test_observability);

}

if (configWithoutPII.desiredCapabilities && configWithoutPII.desiredCapabilities['bstack:options']) {

deleteKeys(configWithoutPII.desiredCapabilities['bstack:options']);

}

return configWithoutPII;

}

vaibhavsingh97 · 2023-05-09T15:08:16Z

src/utils/helper.js

+const httpKeepAliveAgent = new http.Agent({
+  keepAlive: true,
+  timeout: 60000,
+  maxSockets: 2,
+  maxTotalSockets: 2
+});
+
+const httpsKeepAliveAgent = new https.Agent({
+  keepAlive: true,
+  timeout: 60000,
+  maxSockets: 2,
+  maxTotalSockets: 2
+});
+
+const httpScreenshotsKeepAliveAgent = new http.Agent({
+  keepAlive: true,
+  timeout: 60000,
+  maxSockets: 2,
+  maxTotalSockets: 2
+});
+
+const httpsScreenshotsKeepAliveAgent = new https.Agent({
+  keepAlive: true,
+  timeout: 60000,
+  maxSockets: 2,
+  maxTotalSockets: 2
+});


can be consolidated into a function, which will be much cleaner

function createKeepAliveAgent(protocol) { return new protocol.Agent({ keepAlive: true, timeout: 60000, maxSockets: 2, maxTotalSockets: 2 }); } const httpKeepAliveAgent = createKeepAliveAgent(http); const httpsKeepAliveAgent = createKeepAliveAgent(https); const httpScreenshotsKeepAliveAgent = createKeepAliveAgent(http); const httpsScreenshotsKeepAliveAgent = createKeepAliveAgent(https);

swrdfish · 2023-05-18T05:44:57Z

nightwatch/globals.js

+                delete modulesWithEnv[testSetting][testFile].completed[completedSection].testcases;
+              }
+            }
+            promises.push(testObservability.processTestReportFile(JSON.parse(JSON.stringify(modulesWithEnv[testSetting][testFile]))));


JSON.parse and JSON.stringify is unnecessary

Deep copy is necessary because the git modules are changing the values in the object while parsing.

swrdfish · 2023-05-18T05:48:56Z

src/utils/helper.js

+};
+
+exports.shutDownRequestHandler = async () => {
+  await requestQueueHandler.shutdown();


methods related to requesQueuetHandler should be moved to requestQueueHandler.js

added this method to remove circular dependency and made requesQueuetHandler as singleton

swrdfish · 2023-05-18T05:50:26Z

src/utils/helper.js

+    requestQueueHandler.start();
+    const {
+      shouldProceed,
+      proceedWithData,
+      proceedWithUrl
+    } = requestQueueHandler.add(eventData);


methods related to requesQueuetHandler should be moved to requestQueueHandler.js

@swrdfish these are just the method calls, which can be called anywhere in the code. Can you suggest how can this be moved inside the class itself.

The entire uploadEventData should be moved to requestQueueHandler.

swrdfish · 2023-05-18T05:50:41Z

src/utils/helper.js

+      agent: API_URL.includes('https') ? httpsKeepAliveAgent : httpKeepAliveAgent
+    }};
+
+    if (url === requestQueueHandler.screenshotEventUrl) {


methods related to requesQueuetHandler should be moved to requestQueueHandler.js

swrdfish · 2023-05-18T05:53:03Z

src/utils/helper.js

+const httpScreenshotsKeepAliveAgent = createKeepAliveAgent(http);
+const httpsScreenshotsKeepAliveAgent = createKeepAliveAgent(https);
+
+const requestQueueHandler = require('./requestQueueHandler');


methods related to requesQueuetHandler should be moved to requestQueueHandler.js

swrdfish · 2023-05-18T06:00:05Z

src/utils/helper.js

+    ['HookRunFinished']: 'Hook_End_Upload'
+  }[eventData.event_type];
+
+  if (process.env.BS_TESTOPS_JWT !== 'null') {


What happens if process.env.BS_TESTOPS_JWT is undefined?

vaibhavsingh97 · 2023-05-23T11:57:51Z

nightwatch/globals.js

+  reporter: function(results, done) {
+    if (helper.isTestObservabilitySession()) {
+      const promises = [];
+      try {
+        const modulesWithEnv = results['modulesWithEnv'];
+        for (const testSetting in modulesWithEnv) {
+          for (const testFile in modulesWithEnv[testSetting]) {
+            for (const completedSection in modulesWithEnv[testSetting][testFile].completed) {
+              if (modulesWithEnv[testSetting][testFile].completed[completedSection]) {
+                delete modulesWithEnv[testSetting][testFile].completed[completedSection].steps;
+                delete modulesWithEnv[testSetting][testFile].completed[completedSection].testcases;
+              }
+            }
+            promises.push(testObservability.processTestReportFile(JSON.parse(JSON.stringify(modulesWithEnv[testSetting][testFile]))));
+          }
+        }
+
+        Promise.all(promises).then(() => {
+          done();
+        }).catch((err) =>{
+          Logger.error(`Something went wrong in processing report file for test observability - ${err.message} with stacktrace ${err.stack}`);
+          CrashReporter.uploadCrashReport(err.message, err.stack);
+          done();
+        });
+
+        return;
+      } catch (error) {
+        CrashReporter.uploadCrashReport(error.message, error.stack);
+        Logger.error(`Something went wrong in processing report file for test observability - ${error.message} with stacktrace ${error.stack}`);
+      }
+    } 
+    done(results);
+  },


I think this whole code can be refactored like this

reporter: async function(results, done) { if (!helper.isTestObservabilitySession()) { done(results); return; } try { const modulesWithEnv = results['modulesWithEnv']; const promises = []; for (const testSetting in modulesWithEnv) { for (const testFile in modulesWithEnv[testSetting]) { const completedSections = modulesWithEnv[testSetting][testFile].completed; for (const completedSection in completedSections) { if (completedSections[completedSection]) { delete completedSections[completedSection].steps; delete completedSections[completedSection].testcases; } } // Maybe create a helper method to do `.parse` and `.stringify` promises.push(testObservability.processTestReportFile(JSON.parse(JSON.stringify(modulesWithEnv[testSetting][testFile])))); } } await Promise.all(promises); done(); } catch (error) { Logger.error(`Something went wrong in processing report file for test observability - ${error.message} with stacktrace ${error.stack}`); CrashReporter.uploadCrashReport(error.message, error.stack); } }

vaibhavsingh97 · 2023-05-23T12:04:51Z

src/testObservability.js

+      name: helper.getObservabilityBuild(this._settings, this._bstackOptions),
+      build_identifier: options.buildIdentifier,
+      description: options.buildDescription || '',
+      start_time: (new Date()).toISOString(),


Suggested change

start_time: (new Date()).toISOString(),

start_time: new Date().toISOString(),

vaibhavsingh97 · 2023-05-23T12:06:18Z

src/testObservability.js

+      if (response.data && response.data.jwt) {
+        process.env.BS_TESTOPS_JWT = response.data.jwt;
+      }
+      if (response.data && response.data.build_hashed_id) {
+        process.env.BS_TESTOPS_BUILD_HASHED_ID = response.data.build_hashed_id;
+      }
+      if (response.data && response.data.allow_screenshots) {
+        process.env.BS_TESTOPS_ALLOW_SCREENSHOTS = response.data.allow_screenshots.toString();
+      }


Suggested change

if (response.data && response.data.jwt) {

process.env.BS_TESTOPS_JWT = response.data.jwt;

}

if (response.data && response.data.build_hashed_id) {

process.env.BS_TESTOPS_BUILD_HASHED_ID = response.data.build_hashed_id;

}

if (response.data && response.data.allow_screenshots) {

process.env.BS_TESTOPS_ALLOW_SCREENSHOTS = response.data.allow_screenshots.toString();

}

const responseData = response.data || {};

if (responseData.jwt) {

process.env.BS_TESTOPS_JWT = responseData.jwt;

}

if (responseData.build_hashed_id) {

process.env.BS_TESTOPS_BUILD_HASHED_ID = responseData.build_hashed_id;

}

if (responseData.allow_screenshots) {

process.env.BS_TESTOPS_ALLOW_SCREENSHOTS = responseData.allow_screenshots.toString();

}

vaibhavsingh97 · 2023-05-23T12:09:13Z

src/testObservability.js

+    await helper.shutDownRequestHandler();
+    try {
+      const response = await helper.makeRequest('PUT', `api/v1/builds/${process.env.BS_TESTOPS_BUILD_HASHED_ID}/stop`, data, config);
+      if (response.data && response.data.error) {


Suggested change

if (response.data && response.data.error) {

if (response.data?.error) {

vaibhavsingh97 · 2023-05-23T12:10:33Z

src/testObservability.js

+      };
+    }
+    const data = {
+      'stop_time': (new Date()).toISOString()


Suggested change

'stop_time': (new Date()).toISOString()

'stop_time': new Date().toISOString()

vaibhavsingh97 · 2023-05-23T12:11:44Z

src/testObservability.js

+    try {
+      const response = await helper.makeRequest('PUT', `api/v1/builds/${process.env.BS_TESTOPS_BUILD_HASHED_ID}/stop`, data, config);
+      if (response.data && response.data.error) {
+        throw ({message: response.data.error});


Suggested change

throw ({message: response.data.error});

throw {message: response.data.error};

vaibhavsingh97 · 2023-05-23T12:23:06Z

src/testObservability.js

+            break;
+          }
+          default: {
+            if (eventData.retryTestData && eventData.retryTestData.length>0) {


Suggested change

if (eventData.retryTestData && eventData.retryTestData.length>0) {

if (eventData.retryTestData?.length) {

vaibhavsingh97 · 2023-05-23T12:23:30Z

src/testObservability.js

+          }
+        }
+      }
+      if (skippedTests && skippedTests.length > 0) {


Suggested change

if (skippedTests && skippedTests.length > 0) {

if (skippedTests?.length > 0) {

vaibhavsingh97 · 2023-05-23T12:25:20Z

src/testObservability.js

+
+  async processTestRunData (eventData, sectionName, testFileReport, hookIds) {
+    const testUuid = uuidv4();
+    const errorData = eventData.commands.find(command => command.result && command.result.stack);


Suggested change

const errorData = eventData.commands.find(command => command.result && command.result.stack);

const errorData = eventData.commands.find(command => command.result?.stack);

vaibhavsingh97 · 2023-05-23T12:27:30Z

src/testObservability.js

+    if (eventData.httpOutput && eventData.httpOutput.length > 0) {
+      for (let i=0; i<eventData.httpOutput.length; i+=2) {
+        await this.createHttpLogEvent(eventData.httpOutput[i], eventData.httpOutput[i+1], testUuid);
+      }
+    }


Suggested change

if (eventData.httpOutput && eventData.httpOutput.length > 0) {

for (let i=0; i<eventData.httpOutput.length; i+=2) {

await this.createHttpLogEvent(eventData.httpOutput[i], eventData.httpOutput[i+1], testUuid);

}

}

for (const [index, output] of eventData.httpOutput.entries()) {

if (index % 2 === 0) {

await this.createHttpLogEvent(output, eventData.httpOutput[index + 1], testUuid);

}

}

vaibhavsingh97

I made a small refactor suggestion, but overall I think this PR is looking great!

vaibhavsingh97 · 2023-05-24T08:36:08Z

src/utils/requestHelper.js

+exports.makeRequest = (type, url, data, config) => {
+
+  return new Promise((resolve, reject) => {
+    const options = {...config, ...{
+      method: type,
+      url: `${API_URL}/${url}`,
+      body: data,
+      json: config.headers['Content-Type'] === 'application/json',
+      agent: API_URL.includes('https') ? httpsKeepAliveAgent : httpKeepAliveAgent
+    }};
+
+    if (url === SCREENSHOT_EVENT_URL) {
+      options.agent = API_URL.includes('https') ? httpsScreenshotsKeepAliveAgent : httpScreenshotsKeepAliveAgent;
+    }
+
+    request(options, function callback(error, response, body) {
+      if (error) {
+        reject(error);
+      } else if (response.statusCode !== 200) {
+        if (response.statusCode === 401) {
+          reject(response && response.body ? response.body : `Received response from BrowserStack Server with status : ${response.statusCode}`);
+        } else {
+          reject(`Received response from BrowserStack Server with status : ${response.statusCode}`);
+        }
+      } else {
+        try {
+          if (body && typeof(body) !== 'object') {body = JSON.parse(body)}
+        } catch (e) {
+          reject('Not a JSON response from BrowserStack Server');
+        }
+        resolve({
+          data: body
+        });
+      }
+    });
+  });
+};


nitpick: I had suggested small refactor

Suggested change

exports.makeRequest = (type, url, data, config) => {

return new Promise((resolve, reject) => {

const options = {...config, ...{

method: type,

url: `${API_URL}/${url}`,

body: data,

json: config.headers['Content-Type'] === 'application/json',

agent: API_URL.includes('https') ? httpsKeepAliveAgent : httpKeepAliveAgent

}};

if (url === SCREENSHOT_EVENT_URL) {

options.agent = API_URL.includes('https') ? httpsScreenshotsKeepAliveAgent : httpScreenshotsKeepAliveAgent;

}

request(options, function callback(error, response, body) {

if (error) {

reject(error);

} else if (response.statusCode !== 200) {

if (response.statusCode === 401) {

reject(response && response.body ? response.body : `Received response from BrowserStack Server with status : ${response.statusCode}`);

} else {

reject(`Received response from BrowserStack Server with status : ${response.statusCode}`);

}

} else {

try {

if (body && typeof(body) !== 'object') {body = JSON.parse(body)}

} catch (e) {

reject('Not a JSON response from BrowserStack Server');

}

resolve({

data: body

});

}

});

});

};

exports.makeRequest = (type, url, data, config) => {

const isHttps = API_URL.includes('https');

if (url === SCREENSHOT_EVENT_URL) {

agent = isHttps ? httpsScreenshotsKeepAliveAgent : httpScreenshotsKeepAliveAgent;

} else {

agent = isHttps ? httpsKeepAliveAgent : httpKeepAliveAgent;

}

const options = {

...config,

method: type,

url: `${API_URL}/${url}`,

body: data,

json: config.headers['Content-Type'] === 'application/json',

agent

};

return new Promise((resolve, reject) => {

request(options, function callback(error, response, body) {

if (error) {

reject(error);

} else if (response.statusCode !== 200) {

if (response.statusCode === 401) {

reject(response && response.body ? response.body : `Received response from BrowserStack Server with status : ${response.statusCode}`);

} else {

reject(`Received response from BrowserStack Server with status : ${response.statusCode}`);

}

} else {

try {

if (body && typeof(body) !== 'object') {body = JSON.parse(body)}

} catch (e) {

reject('Not a JSON response from BrowserStack Server');

}

resolve({

data: body

});

}

});

});

};

vaibhavsingh97 · 2023-05-24T08:43:25Z

src/utils/helper.js

+};
+
+exports.getObservabilityProject = (options, bstackOptions={}) => {
+  if (options.test_observability && options.test_observability.projectName) {


Have you considered using optional chaining? I've noticed it being used throughout the files.

…-plugin-browserstack into HEAD

added build start event

286fc9b

AutomatedTester requested review from swrdfish, beatfactor and gravityvi March 29, 2023 15:39

beatfactor reviewed Mar 30, 2023

View reviewed changes

nightwatch/globals.js Outdated Show resolved Hide resolved

stop build event

32369f3

swrdfish requested changes Mar 30, 2023

View reviewed changes

Pranay Kumar added 15 commits April 11, 2023 10:56

populated test and hook events for test observability

fdaaebd

added screenshot for failure case

a7dcf06

changes for screenshots and integration object in teststart

67a7a00

refactored code by removing comments and unncessary code

ab028c5

given preference to env variables

f2f6c0d

added argument support for test observability

6133a6a

version control file path bug fixed

f982799

observability rerun changes and code refactoring

34f2c45

removed before each

a8e58bd

removed vc file path unwanted function

7416ae7

sending screenshot in base64 format

0240650

failure stacktrace format changed

130ffe5

clear interval if empty queue

eb8313e

fixed null ptr exception

0978995

check for file read and unlink

0a03b14

swrdfish requested changes Apr 18, 2023

View reviewed changes

added times for benchmarking

8ddf1d9

sriteja777 reviewed Apr 20, 2023

View reviewed changes

Pranay Kumar added 5 commits April 20, 2023 14:30

removed console logs used for benchmarking

9cd7a0d

changes for test level tags

aff83d3

changes for displaying http logs

c39e842

made reporter function async

5e156d8

await for shutdown que handler

40eb90b

Pranay Kumar added 4 commits May 8, 2023 10:38

changes for review comments

5fc6c31

retry test data fix

129d6ff

logging changes

cfb7ac3

removed typo

79bc9ee

swrdfish requested changes May 9, 2023

View reviewed changes

vaibhavsingh97 reviewed May 9, 2023

View reviewed changes

changes for review comments

c48343e

sriteja777 approved these changes May 10, 2023

View reviewed changes

Pranay Kumar added 2 commits May 17, 2023 13:09

added fspromises

bfc7764

made request handler singleton

0c701c4

swrdfish requested changes May 18, 2023

View reviewed changes

Pranay Kumar added 2 commits May 18, 2023 19:06

added observability sync script

173d6ea

added pref for env vars

9cff9c0

grkpranaykumar changed the title ~~added build start event~~ nightwatch test-observability integration phase-1 May 22, 2023

amaanbs approved these changes May 22, 2023

View reviewed changes

null check added

4783713

sriteja777 approved these changes May 23, 2023

View reviewed changes

vaibhavsingh97 reviewed May 23, 2023

View reviewed changes

Pranay Kumar added 2 commits May 23, 2023 19:17

review comments done

eefc057

added fixes for review comments

4cedf20

grkpranaykumar requested a review from vaibhavsingh97 May 23, 2023 15:01

swrdfish approved these changes May 24, 2023

View reviewed changes

vaibhavsingh97 reviewed May 24, 2023

View reviewed changes

Pranay Kumar and others added 4 commits May 24, 2023 15:29

linting changes and fixes for new review comments

53c3da6

handling of error cases in 401 and 403

5347114

use ES2020

5148bff

Merge branch 'OB_189' of https://github.com/grkpranaykumar/nightwatch…

d0e71d4

…-plugin-browserstack into HEAD

swrdfish merged commit 006ac1f into nightwatchjs:main May 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nightwatch test-observability integration phase-1 #5

nightwatch test-observability integration phase-1 #5

grkpranaykumar commented Mar 29, 2023

swrdfish Mar 30, 2023

swrdfish Apr 18, 2023

swrdfish May 9, 2023

swrdfish May 9, 2023

vaibhavsingh97 May 9, 2023

vaibhavsingh97 May 9, 2023

swrdfish May 18, 2023

grkpranaykumar May 22, 2023

swrdfish May 18, 2023

grkpranaykumar May 22, 2023

swrdfish May 18, 2023

grkpranaykumar May 23, 2023

swrdfish May 23, 2023

swrdfish May 18, 2023

swrdfish May 18, 2023

swrdfish May 18, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 May 23, 2023

vaibhavsingh97 left a comment

vaibhavsingh97 May 24, 2023

vaibhavsingh97 May 24, 2023

	start_time: (new Date()).toISOString(),
	start_time: new Date().toISOString(),

-      if (response.data && response.data.jwt) {
-        process.env.BS_TESTOPS_JWT = response.data.jwt;
-      }
-      if (response.data && response.data.build_hashed_id) {
-        process.env.BS_TESTOPS_BUILD_HASHED_ID = response.data.build_hashed_id;
-      }
-      if (response.data && response.data.allow_screenshots) {
-        process.env.BS_TESTOPS_ALLOW_SCREENSHOTS = response.data.allow_screenshots.toString();
-      }
+    const responseData = response.data || {};
+    if (responseData.jwt) {
+      process.env.BS_TESTOPS_JWT = responseData.jwt;
+    }
+    if (responseData.build_hashed_id) {
+      process.env.BS_TESTOPS_BUILD_HASHED_ID = responseData.build_hashed_id;
+    }
+    if (responseData.allow_screenshots) {
+      process.env.BS_TESTOPS_ALLOW_SCREENSHOTS = responseData.allow_screenshots.toString();
+    }

	if (response.data && response.data.error) {
	if (response.data?.error) {

	'stop_time': (new Date()).toISOString()
	'stop_time': new Date().toISOString()

	throw ({message: response.data.error});
	throw {message: response.data.error};

	if (eventData.retryTestData && eventData.retryTestData.length>0) {
	if (eventData.retryTestData?.length) {

	if (skippedTests && skippedTests.length > 0) {
	if (skippedTests?.length > 0) {

	const errorData = eventData.commands.find(command => command.result && command.result.stack);
	const errorData = eventData.commands.find(command => command.result?.stack);

nightwatch test-observability integration phase-1 #5

nightwatch test-observability integration phase-1 #5

Conversation

grkpranaykumar commented Mar 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vaibhavsingh97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment