Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nightwatch test-observability integration phase-1 #5
nightwatch test-observability integration phase-1 #5
Changes from 36 commits
286fc9b
32369f3
fdaaebd
a7dcf06
67a7a00
ab028c5
f2f6c0d
6133a6a
f982799
34f2c45
a8e58bd
7416ae7
0240650
130ffe5
eb8313e
0978995
0a03b14
8ddf1d9
9cd7a0d
aff83d3
c39e842
5e156d8
40eb90b
dbfc5fc
7d188e4
564f67d
5fc6c31
129d6ff
cfb7ac3
79bc9ee
c48343e
bfc7764
0c701c4
173d6ea
9cff9c0
4783713
eefc057
4cedf20
53c3da6
5347114
5148bff
d0e71d4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON.parse
andJSON.stringify
is unnecessaryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deep copy is necessary because the git modules are changing the values in the object while parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this whole code can be refactored like this