Throwing TimeoutError when chained .find() command fails

[dikwickley]

Description of the bug/issue

When .find() command is chained and it fails to resolve any element, it throws an TimeoutError instead of NoSuchElementError.

Branched off from issue: #3991
Reference comment: #3991 (comment)

Sample test

Just use browser.element.find('.invalid_selector'); in any Nightwatch example test and run the test.

Potential solution

We'd probably need to check if the error thrown by the .find() command is a timeout error and if so, change the error name accordingly.

After the fix, instead of a timeout error, we should get an error in the following format when Nightwatch is unable to find an element:

Nightwatch.js Version

3.3.7

[Honey2339]

Hey i would like to know that are you working on this?

[dikwickley]

Hey @Honey2339 I am not working on this currently, you can take this up.

[piyushmishra1416]

Hello @dikwickley, can you please explain why I am encountering the same error twice? Will you please explain the if there is any reason behind this?

[Ayush-Vish]

@garg3133 I have raised PR for #4084 and also I have explained the solution.

[vidhvath28]

hey @dikwickley I am interested in working on issues, I have set up locally for now. I kindly request you to assign me this issue.

[vidhvath28]

started working on the issue @dikwickley @garg3133

[vidhvath28]

Test cases have been updated with sample test, please give your feedback on the code .

[vidhvath28]

Requesting you to allow my pull request for #4084

[garg3133]

The goal for this issue is to get an error in the following format when Nightwatch is unable to find an element, instead of a timeout error.

It's a very simple fix but right now there are no PRs which achieves this.

[Ayush-Vish]

@garg3133 Please Review my PR. I have Added output in the PR Itself.
#4084

[garg3133]

@Ayush-Vish I have, but as you can see, the format of error message in your PR is not same as what I shared above (no Try fixing by part in the error message, which should be appended automatically by Nightwatch for NoSuchElementError).

[Ayush-Vish]

NoSuchElementError

Ok I'll fix it as Quickly as Possible thanks.

[Honey2339]

@garg3133 I've just pushed the changes for the fix described above. Please review the PR at your earliest convenience.

[AritraLeo]

@garg3133 @dikwickley
browser.element.find('.invalid_selector');
on which test file shall I use it becuase I was using ecosia and duckDuck.js files to test the code for isPresent() issue (idk if I am right or wrong) but I received an error -
at - .navigateTo('https://duckduckgo.com')
please help me out a little bit in understanding the codebase I think once I get a good understanding I'll be able to contribute more and more! Thanks

[Ayush-Vish]

@garg3133 I have Fixed the error now and it is showing Required Error output.

2024-03-07.23-13-59.mp4

#4102

[Ayush-Vish]

@garg3133 Please Review My PR, I have done all the required changes.

[HrxSrv]

Supposed Fix PR #4122, please have a look @garg3133 .

[Visbhavesh]

hey assign these issue to me and I will resolve these