Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4078 - timeout issue on find command #4084

Closed

Conversation

Ayush-Vish
Copy link
Contributor

@Ayush-Vish Ayush-Vish commented Mar 3, 2024

Fixes #4078
The solution to this bug was to rename the TimoutError to NosuchElementError.
I have also tested the command.
Below is the required video.
If any correction is needed please let me know @garg3133 .
If not kindly assign me this issue.

2024-03-03.16-01-35.mp4

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • [.] Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • [.] If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2024

CLA assistant check
All committers have signed the CLA.

@Ayush-Vish Ayush-Vish changed the title Fix #4080 - timeout issue on find command Fix #4078 - timeout issue on find command Mar 3, 2024
@Ayush-Vish Ayush-Vish marked this pull request as draft March 4, 2024 14:27
Copy link

github-actions bot commented Mar 5, 2024

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@Ayush-Vish Ayush-Vish closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throwing TimeoutError when chained .find() command fails
2 participants