-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Error Message for Browser Compatibility Information. #3809
Merged
AutomatedTester
merged 9 commits into
nightwatchjs:main
from
yashPratp983:change-error-message
Jul 26, 2023
Merged
Updated Error Message for Browser Compatibility Information. #3809
AutomatedTester
merged 9 commits into
nightwatchjs:main
from
yashPratp983:change-error-message
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1db3b34.
…ditions and registerBasicAuth
Status
|
garg3133
approved these changes
Jul 17, 2023
AutomatedTester
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use chromium based
instead of Edge and Chrome
AutomatedTester
approved these changes
Jul 18, 2023
gravityvi
approved these changes
Jul 19, 2023
…ent-commands/setConditions.js file
…t-commands/setConditions.js
garg3133
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the error message displayed when using the non-chromium driver for commands .setNetworkConditions() and .registerBasicAuth() to provide more accurate and specific information. Previously, the error message stated that above commands were not supported while using this driver.
In this pull request, the error message has been updated to provide clearer guidance. The new error message now specifies that the mentioned commands are only supported in Chrome and Edge browsers. This clarification will help users understand the browser compatibility requirements when executing those specific commands.