Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Error Message for Browser Compatibility Information. #3809

Merged
merged 9 commits into from
Jul 26, 2023

Conversation

yashPratp983
Copy link
Contributor

This pull request modifies the error message displayed when using the non-chromium driver for commands .setNetworkConditions() and .registerBasicAuth() to provide more accurate and specific information. Previously, the error message stated that above commands were not supported while using this driver.

In this pull request, the error message has been updated to provide clearer guidance. The new error message now specifies that the mentioned commands are only supported in Chrome and Edge browsers. This clarification will help users understand the browser compatibility requirements when executing those specific commands.

@github-actions
Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

Copy link
Member

@AutomatedTester AutomatedTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use chromium based instead of Edge and Chrome

@yashPratp983 yashPratp983 requested a review from garg3133 July 19, 2023 13:08
@AutomatedTester AutomatedTester merged commit d8a3d73 into nightwatchjs:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants