Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Error Message for Browser Compatibility Information. #3809

Merged
merged 9 commits into from
Jul 26, 2023
Merged

Updated Error Message for Browser Compatibility Information. #3809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1db3b34
move network commands to network namespace
yashPratp983 Jul 9, 2023
091779a
Merge branch 'nightwatchjs:main' into main
yashPratp983 Jul 13, 2023
3b6d3be
Revert "move network commands to network namespace"
yashPratp983 Jul 14, 2023
59b9f21
changed error message for using non-chromium driver for setNetworkCon…
yashPratp983 Jul 14, 2023
d0e844f
Changed error message to use chromium based driver
yashPratp983 Jul 18, 2023
697b26b
deleted lib/api/client-commands/setNetworkConditions.js to solve merg…
yashPratp983 Jul 19, 2023
c63837e
Merge branch 'nightwatchjs:main' into change-error-message
yashPratp983 Jul 19, 2023
7f7c04c
modified error message regarding browser-compatibility in lib/api/cli…
yashPratp983 Jul 19, 2023
034de47
added . before setNetworkConditions in error message in lib/api/clien…
yashPratp983 Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/api/client-commands/network/setConditions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class SetNetworkConditions extends ClientCommand {

performAction(callback) {
if (!this.api.isChrome() && !this.api.isEdge()) {
const error = new Error('SetNetworkConditions is not supported while using this driver');
const error = new Error('The command .setNetworkConditions() is only supported in Chromium based drivers');
Logger.error(error);

return callback(error);
Expand Down
2 changes: 1 addition & 1 deletion lib/api/client-commands/registerBasicAuth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class RegisterBasicAuth extends ClientCommand {

performAction(callback) {
if (!this.api.isChrome() && !this.api.isEdge()) {
const error = new Error('RegisterBasicAuth is not supported while using this driver');
const error = new Error('The command .registerBasicAuth() is only supported in Chromium based drivers');
Logger.error(error);

return callback(error);
Expand Down
2 changes: 1 addition & 1 deletion test/src/api/commands/client/testRegisterBasicAuth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ describe('.registerBasicAuth()', function () {
}).then(client => {
client.api.registerBasicAuth('admin', 'admin', function(result){
assert.strictEqual(result.status, -1);
assert.strictEqual(result.error, 'RegisterBasicAuth is not supported while using this driver');
assert.strictEqual(result.error, 'The command .registerBasicAuth() is only supported in Chromium based drivers');
});

client.start(done);
Expand Down
2 changes: 1 addition & 1 deletion test/src/api/commands/client/testSetNetworkConditions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ describe('.setNetworkConditions()', function () {
},
function (result) {
assert.strictEqual(result.status, -1);
assert.strictEqual(result.error, 'SetNetworkConditions is not supported while using this driver');
assert.strictEqual(result.error, 'The command .setNetworkConditions() is only supported in Chromium based drivers');
}
);
client.start(done);
Expand Down