Suisin/refactor: ts migration for poi country selector #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ages/account/src/Components/poi/poi-country-selector/__tests__/poi-country-selector.spec.tsx
Outdated
Show resolved
Hide resolved
...ages/account/src/Components/poi/poi-country-selector/__tests__/poi-country-selector.spec.tsx
Outdated
Show resolved
Hide resolved
jim-deriv
approved these changes
Jan 6, 2023
niloofar-deriv
approved these changes
Jan 6, 2023
niloofar-deriv
merged commit 3a2c274
into
niloofar-deriv:niloo/84471/ts-migration-parent
niloofar-deriv
pushed a commit
that referenced
this pull request
Mar 21, 2023
…-migration-to-tsx likhith/migrated select-native to tsx
niloofar-deriv
pushed a commit
that referenced
this pull request
May 18, 2023
* refactor: initial commit * revert: revert changes * chore: ts-migration for positions-card.tsx (#5) * chore: reports-table-row to tsx (#10) * chore: migrating error-components to tsx (#8) * chore: migrating error-components to tsx * fix: added partial to type * chore: migrate calendar-icon to tsx (#11) * chore: migrate calendar-icon to tsx * fix: updated extensions * chore: migrate list-item to tsx (#12) * chore: migrate currency-wrapper to ts (#17) * chore: migrate empty-portfolio-message to ts (#18) * chore: migrating reports meta to tsx (#23) * chore: migrate amount-cell to ts (#16) * chore: migrate amount-cell to ts * fix: delete component because it is unused * chore: migrating EmptyTradeHistoryMessage to tsx (#19) * chore: migrating EmptyTradeHistoryMessage to tsx * fix: remove extension * fix: migrated sidelist to tsx (#13) * fix: migrated sidelist to tsx * fix: circle-ci error * fix: sidelist types * chore: migrate composite calendar mobile to typescript (#26) * chore: migrate composite calendar mobile to typescript * fix: remove component extension from the name * refactor: ♻️ removed unused component (#30) * chore: migrate index file to typescript (#27) * refactor: ♻️ migrate component to tsx (#29) * chore: two-month-picker to tsx with one calendar component (#15) * chore: migrate account statistics to ts (#14) * chore: migrate account statistics to ts * fix: typo in comment * Akmal / chore: migrate routes config to typescript (#31) * chore: migrate routes config to typescript * fix: change type for component * Akmal / chore: migrate data-table-constants to typescript (#33) * chore: migrate data-table-constants to typescript * fix: refactor types * chore: migrate loading component to typescript (#36) * Aizad/73988/msir ts (#21) * chore: migrate market-symbol-icon-row to ts * fix: remove commented lines * fix: remove classname from IconTradeTypes * fix: removed action prop * Sergei / chore: migrate open-positions to tsx (#40) * chore: convert open-positions to tsx * fix: add React.PropsWithChildren to tabs.tsx * fix: change Tabs type * fix: add/change some types and fix some undefined values * refactor: use Return Early pattern for contract-card-sell component * chore: delete commented lines * chore: add moment as dev dependency * chore: commit to check circleCI * fix: change back tabs.tsx * fix: change React.Fragment to null * Akmal / chore: convert helpers to typescript (#28) * chore: convert elpers to typescript * fix: types * chore: migrate placeholder to tsx (#42) * chore: migate placeholder to tsx * fix: destructure props and remove React.propswithchildre * Sergei / 73980 / chore: ts migration of route-with-sub-routes (#45) * chore: ts migration of route-with-sub-routes * refactor: add common types to separate files * fix: get back composite-calendar * refactor: change path from absolute to relative for Types * Sergei / 73979 / chore: ts migration of binary-routes (#46) * chore: ts migration of binary-routes.jsx * chore: add TPassthrough type and add key as index when route.path is undefined * chore: add export for TBinaryRoutes type * refactor: use types from common types * Aizad/73977/binary link ts (#41) * chore: migrate routes folder to tsx * fix: change type for component * fix: migrated test cases to tsx * chore: migrate binary-links to tsx * fix: change back function names * fix: resolved conflict issues * fix: testcases * chore: migrated filter component and fix some issues with composite-c… (#20) * chore: migrated filter component and fix some issues with composite-calendar * fix: change export to CalendarIcon on index.js and added RootStore type to filter-components * fix: change TRootStore to RootStore * fix: replace RootStore to TRootStore * fix: expand object for filtered_date_range * Sergei / chore: ts migration of routes (#38) * chore: ts migration of routes * chore: change RootStore type * Aizad/73994/pss ts (#48) * chore: migrate progress-slider-stream to tsx * fix: imported TContractInfo inside deriv/shared/ * Sergei / chore: migrate statements to tsx (#39) * chore: ts migration of statements * chore: change RootStore type * chore: change local TRootStore with module property * fix: return class RootStore to Stores/index.ts * chore: change core_store type * chore: migrated indicative cell to tsx (#44) * chore: migrated indicative cell to tsx * fix: added types to usestate * fix: change type * fix: change function type to boolean * fix: imported TContractInfo from shared file into indicative-cell * fix: test * fix: mockstore * fix: format-response.ts * fix: mockstore * Aizad/73978/routes ts (#50) * Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration * chore: finalising routes folder migration for Reports package 📦 * Akmal / chore: migrate app.jsx to typescript (#37) * chore: migrate app.jsx to typescript * chore: utilize TRootStore type * chore: replace type * Akmal / chore: migrate composite calendar to typescript (#25) * chore: migrate composite calendar to typescript * chore: refactor composite calendar and related components to properly use moment * chore: move out index changes * feat: resolve conflicts * feat: add deriv stores package * Kate/73995/TS migration of Reports (#51) * refactor: migrate reports component into ts * refactor: add useStore hook * refactor: delete extra react fragment Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * redeploy: rerun tests * refactor: remove named import from react * chore: migrate statement to tsx (#47) * chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions * fix: types in packages/shared/src/utils/shortcode/shortcode.ts * fix: regex to prevent sonarcloud bug * chore: change index.js to index.ts * Rostislav / 73993 / Task - TS migration of ProfitTable (#34) * refactor: init pr * refactor: profit_loss_cell tsx'd * refactor: profit_loss_cell import problem resolved * refactor: profit_loss_cell import another problem fix * refactor: the migration is more or less finished * refactor: a few extra changes * refactor: prev commit accidental changes removed * refactor: TProfitTable type changed a bit * refactor: moved types to common-prop.type.ts * refactor: getSupportedContracts and getUnsupportedContracts moved to shared * refactor: contract.tsx completely replaced by imports from @deriv/shared * refactor: added alias for Types * refactor: applied suggested changes * fix: regex for sonarcloud * fix: remove props from the name of type declaration * fix: resolve comments * fix: fix comments v2 * fix: remove usestate * fix: date-time test * fix: comments v3 * thisyahlen/fix: trade table for mobile (#52) * fix: trade table for mobile * fix: trade table error * fix: statement input validation error on date_from * fix: setdate unix * fix: responsive input validation error * fix: remove unix from store --------- Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev>
niloofar-deriv
pushed a commit
that referenced
this pull request
Jun 4, 2023
* feat: evgeniy-wall-376/likhith-wall-379/ onfido and idv verification ux improvement with example * refactor: example window styles and types improvvements * fix: circlci test error * chore: formik init * feat: ✨ incorporated IDV in Personal details for Real account sign up * feat: 🐛 resolved failing tests * chore: api updating form and styles * feat: accounts settings identity onfido impovements add * refactor: ♻️ incorporated review comments * fix: text content * feat: 🎨 migrated to TSx * feat: upgraded pack * refactor: inputs form in separate components * chore: example form ts * chore: example container ts * refactor: ts fix * chore: props passing data instead of connect * feat: 🎨 refactor stylings of shared component * feat: incorporated shared component into poi * feat: incorporated shared component into poi * fix: styles, unnecessary code remove * fix: styles for onfido * chore: fix styling * fix: lost styles restore * style: 🎨 resolved issue with onfido container for mobile * feat: 🎨 incorporated IDV new flow * chore: styles onfido * fix: 🐛 resolved tooltip issue * chore: css onfido page * feat: 🎨 incorporated testcases * fix: 🐛 resolved incorrect path * fix: 🐛 failing test case * chore: new confirm form tests * chore: onfido-sdk-view ts migration * chore: deeprequired type fix * Likhith/hide helper image on no avbl doc (#9) * style: 🎨 incorporated hiding of helper image based on avbl doc * style: 🎨 moved color to common variable * Shahzaib/kyc 42/success banner design updates (#10) * style: update positioning of success banner in KYC flow * style: update positioning of success banner in mt5 account flow * chore: renamed prop from is_mt5 to is_external * style: status message width * Likhith/kyc-34/ improve idv flow for poi (#11) * feat: 🎨 incorporated new changes * feat: ✨ incorporated idv for mt5 * refactor: review comments implementation * fix: ⚡ resolved code smells * fix: ⚡ resolved failing testcase * fix: ⚡ removed commented lines * fix: ⚡ removed minor code smells * fix: ⚡ removed minor code smells * feat: 🎨 code refactored * refactor: onfido window separate component * feat: 🎨 code refactored * feat: 🎨 code refactored (#16) * feat: 🐛 minor code smells * chore: error message banner for onfido flow * chore: renamed error message field name * Revert "Merge branch 'master' of https://github.com/binary-com/deriv-app into shahzaib/KYC-1/error-handling-for-onfido-flow" This reverts commit 44635a3, reversing changes made to f5b8fb9. * refactor: sonar cloud security issue * fix: circleci issue * fix: 🐛 removed a code smell * feat: 🎨 added new testcase * feat: 🎨 removed duplicated types * feat: minor bug fix * chore: onfido sdl view test * chore: onfido types rename, timeout comment * feat: reverted localize changes * feat: incorporated review comments * fix: resolved placeholder * feat: resolved radio button issue * fix: minor bug fix * refactor: custom math random create * refactor: deep required * refactor: revert commits with api hooks * fix: 🚑 reverted the radio button change * fix: errors object with empty fields * fix: date picker update value * fix: 🎨 formatted the code * fix: 🎨 formatted the code * chore: added cleartime out * chore: added cleartime out * refactor: ♻️ incorporated review comments * fix: removed code smells * refactor: onfido blue hint box loading fix * chore: removed unnecessary formik field * fix: 🚀 incorporated null checks * chore: resolved prop duplication in form fields * chore: updated name and types in idv form fields * chore: removed unnecessary formik field * fix: add name prop to date of birth custom component (#23) * Refactor/form fields (#24) * fix: add name prop to date of birth custom component * fix: test cases * refactor: update props from formik for date custom fields component * fix: personal-details import image error * fix: ♻️ incorporated review comments * fix: 🐛 build path issue * feat: removed unused import * style: poi form (#25) * fix: 🎨 fixed styling issue * fix: 🐛 import fix * refactor: is_external flag onfido remove * chore: fix render glitch in mt5 form (#29) * chore: fix render glitch in mt5 form * fix: dispose onfido_ref if any error occurs during onfido token fetching or sdk initialization * fix: add a check to display info message upon onfido initialization (cherry picked from commit 1cf15d2) * fix: asterisk in fields label * feat: 🐛 resolved the testcase issue * fix: empty line validation * feat: ✅ fix failing testcases * Likhith/kyc 95/document number reset (#30) * fix: 🐛 fix document number reset * fix: ✨ incorporated idv option fix * fix: 🐛 resolved the issue with DIEL * fix: fieldset padding in mobile screen (#31) * fix: css alignment form * fix: 🐛 resolved issue with tax field (#32) * fix: Place of birth issue * fix: 🐛 resolved issue with radio button (#33) --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Matin shafiei <matin@deriv.com>
niloofar-deriv
pushed a commit
that referenced
this pull request
Oct 13, 2023
* fix: ts-migrate trade-params * fix: sonarcloud * fix: pull in changes from tech debt 2 package * fix: resolve comments * fix: move type to common prop types * fix: move type to common prop types * fix: move type to common prop types file * fix: resolve comments * Kate / DTRA-321 / TS migration of trade-params and trade-params-mobile (#6) * refactor: migrate trade params and started mobile version * refactor: ts migration of trade params mobile * chore: add nessasary prop * refactor: apply suggestions * chore: change todo text * refactor: add import * fix: circleCI error * fix: ts migrate trade-footer-extensions.jsx * fix: fix import * fix: remove progress-slider-stream since its not used * fix: resolve comments * fix: reset with master * fix: reset with master * fix: reset with master * fix: reset with master * fix: circleCI * fix: togglePositions folder * fix: dtra-346 marketisclosed and marketcountdowntimer migration * fix: bug * Maryia/dtra-270/TS migration: trade-store (#5) * chore: prepare for migration * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: migrated trade-store to ts * chore: improve types in trade-store * fix: type * revert: hooks package installation * refactor: address review * fix: resolve comments * feat: add ts migartion of store * refactor: add prev changes * chore: empty commit * fix: add lost mocked * fix: resolve comments * Kate / DTRA-354 / Components/Form/Purchase files in Trader package (#21) * refactor: ts migartion of purchase files * refactor: remove duplicated types * refactor: apply suggestions * maryia/fix: sonarcloud warnings (#7) * fix: sonarcloud warnings * fix: Unexpected end of JSON input * fix: bug * fix: sonarcloud * fix: reorder props * fix: test cases * fix: coveralls * fix: coveralls * fix: this component doesnt exist anymore, hence test was also removed * henry/dtra-356/fix: ts-migration-digitsJSX (#24) * fix: initial commit * fix: ts migrate digits JSX * fix: small type change * fix: comment * chore: removed unused state * Maryia/dtra-355/Migrate ContractDrawer files to TS (#22) * feat: migrated swipeable-components to TS * feat: migrated market-closed-contract-overlay & index to TS * chore: migrated contract-drawer-card.tsx to ts * build: fix type * chore: migrated contract-drawer to ts * chore: fixed existing types in digits and logic * chore: sort types properties in alphabetical order * Kate/dtra 357/ts contract audit files (#23) * refactor: apply suggestion from prev pr * refactor: start ts migration of contract audit * chore: change comment * refactor: ts of contract audit item * refactor: ts migration of contract details * refactor: ts migration of contract history * refactor: add preprepared types * refactor: tests * chore: apply nit * refactor: apply suggestions * refactor: apply suggestions * chore: fix of sonar cloud * Maryia/dtra-373/remove localize from ContractCardHeader component (#25) * refactor: remove localize from contract-card-header * refactor: use Localize component instead of localize helper * build: install RTL deps in shared package * feat: merge previous tech debt branch * fix: sonar cloud codesmells * Merge branch kate/ts_migration_trader_package_4 into kate/ts_migration_trader_package_5 * Kate / DTRA-378 / TS migration: Multiplier components and containers in Trader package (#26) * refactor: ts of cancel deal and risk managment info * fix: types in dialog tsx * refactor: start ts of multiplier options * refactor: ts of mult amount modal * refactor: remove default val from basis component * fix: type of amount mobile * refactor: applied suggestions * refactor: ts of multiplier info (#28) * Henry/dtra 376/fix: ts migration positionsdrawer folder (#27) * fix: positions drawer folder * fix: coveralls * fix: where is my commit * fix: found commits * fix: file rename * fix: comments * fix: comments * fix: correct logic * fix: remove unused props * fix: types * refactor: remove code mells * fix: ts-migrate-populate header (#30) * Maryia/DTRA-377/TS migration: TradingDatePicker + TradingTimePicker + TimePicker + Dialog (#29) * chore: timepicker to ts * chore: trading timepicker to ts * chore: add types for TradingDatePicker & DatePicker * refactor: added default values * refactor: remove code small * chore: empty commit * fix: not using index as key (#31) * fix: ternary bug * fix: build TS errors (#32) * refactor: apply suggestions * refactor: change type of time * chore: empty commit * refactor: tests * fix: conflicts * fix: conflicts * fix: tests * fix: types in tests * fix: test extention * fix: add turbos to types back * fix: add backup for target name * fix: revert empty strings --------- Co-authored-by: Henry Hein <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change