Niloofar / Mobx migration for cfd #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of github.com:binary-com/deriv-app into mobx
niloofar-deriv
pushed a commit
that referenced
this pull request
Aug 9, 2022
Niloofar / some more features
niloofar-deriv
pushed a commit
that referenced
this pull request
Mar 28, 2023
* Merge '67492_accumulators_purchase' into 'maryia/67492/task_add_accumulators' * Maryia/75617/add_accu_to_trade_params (#3) * initialized ACCU trade params for responsive * added LabeledQuantityInputMobile & improved AccumulatorsAmountMobile * feat: added Accumulator radio group for growth_rate * feat: finalized Accumulator growth_rates radio group for mobile * feat: responsive- added Take profit to trade params & aligned purchase button icon * feat: improved mobile trade params for ACCU * feat: finalized trade params for ACCU * maryia/72761/task_add_recent_positions_drawer (#4) * feat: initialized ACCU contract card in recent positions * feat: initialized ProgressSliderSolidLine for ACCU * feat: updated recent positions card for ACCU for open/lost/won states * chore: improvements for ACCU card in responsive recent positions * chore: added TickCounterProgressBar component * feat: added TickCounterBar and reverted ProgressSlider & ProgressSliderMobile * chore: reverted original Recent positions drawer width * chore: improved TickCounterBar styling * maryia/76528/task_implement_contract_details_drawer (#5) * chore: updated Details in contract card for ACCU + styling * feat: implemented ACCU contract card in contract details + improved recent positions * chore: updated icons for ACCU trade type & contract category * maryia/72769/add_ticks_history_stats_widget (#6) * feat: init version of TicksHistoryStatsWidget for ACCU * chore: TicksHistoryStats * chore: improved tick history styling * chore: added more styles & animated progress dots under latest counter * feat: finalized desktop ticks history stats for dtrader page * feat: added ticks history to contract details page * improved ticks history stats for desktop & initialized it for responsive * made responsive stats non-expandable * maryia/77261/task_manual_for_history_widget (#8) * chore: discarded getUpdatedTicksHistoryStats as BE will send 15 exact values instead of 100+latest * feat: added AccumulatorsStatsManualModal * feat: finalized AccumulatorsStatsManualModal for desktop & responsive * chore: added getUpdatedTicksHistoryStats to process arrays of counters with epochs expected from BE * feat: added expanded AccumulatorsStats dialog for responsive * chore: contract card styling improvements + using ACCU tick_count as max_ticks_number * chore: improved AccumulatorsStats to load after tick counters have loaded * maryia/75621/task_add_tests_and_restyle_contract_card (#9) * chore: improved ACCU contract type icon & label styling in contract card * chore: added tests for accumulator.js helper function * chore: added tests for Accumulator.jsx * maryia/75621/part_2_task_accu_barriers (#10) * chore: updated dummy data * chore: fixed history stats styles & added tests for AccumulatorsStats * chore: improved AccumulatorsStats and its tests * chore: updated contract card & open positions * maryia/75621/add barriers for stay in contract on trader page (#12) * chore: test out passing trade data to all-markers for drawing barriers without contract + improvements * feat: added barriers for accumulators without open contract * feat: added markers and barriers for stay in contract on trader page * chore: adjusted open contract profit label (#13) * yauheni/77994/trader add break out contract type (#14) * yauheni/77994/trader add break out contract type * regexp fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/78429/update styles of tick history widget (#15) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: prepared data for connecting API (#16) * Maryia/78473/part 2 prepare for api + improvements (#18) * chore: improved barriers without contract and open contract label * chore: prepared data for api connection * chore: added price tags for barriers in contract details (#19) * feat: initialized AccumulatorsProfitLossTooltip (#20) * yauheni/78477/update params with buttons for responsive (#17) * yauheni/78477/update params with buttons for responsive * fix styles accordingly to design * buttons gap fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/resolve build errors (#21) * yauheni/resolve build errors * optional property for is_checkbox_hidden Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/78633/update styles for tick history widget (#22) * yauheni/resolve build errors * yauheni/78633/update styles for tick history widget * yauheni/78633/update styles for tick history widget responsive Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/78839/complete_sold_labels (#23) * chore: added tolltips for all sold positions & won/lost coloring * feat: finalized AccumulatorsProfitLossTooltip * maryia/improvements for stats and tooltip (#24) * chore: accumulators stats improvements * improvements * maryia/improvements for sold contract label * maryia/78574/add_barriers_to_contract_details * maryia/79085/remove_break_out_history_from_stats_widget (#26) * maryia/79085/remove_break_out_history_from_stats * chore: made purchaseButtonsOverlay flexible * chore: added tests for PurchaseButtonsOverlay * Yauheni/77995/update trade params for stayin breakout (#25) * yauheni/77995/update trade params for stayin breakout * take profit alimngment * buttons styles, take profit alingment * maryia/78574/add_barriers_to_contract_details * stake font and icon fix, go_tp_reports button styles * update contract store from parent Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: maryia-binary <maryia@binary.com> * maryia/fix: styles & fonts for responsive trade types * Maryia/79549/part 1: update tick markers for ACCU in contract details + improvements (#27) * maryia/79549/add_tick_markers_contract_details * chore: improvements for styles in responsive trade types desc * yauheni/79530/remove breakout contract (#28) * yauheni/79530/remove breakout contract * proposal data fields fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/styling improvements * maryia/fix: forcing Div100vh to re-render when height_offset for responsive has changed * maryia/fix: observables + markers * maryia/chore: prevented barriers, labels and markers from going outside axes (#30) * maryia/79969/set_default_chart_type_and_interval_to_Area_and_1_tick * maryia/chore: changed trade type name to Accumulators * maryia/80163/set growth rate based on default value from BE contracts_for response * yauheni/80091/hide chart mode icon for accumulators (#33) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80166/connect_to_available_API (#34) * chore: connected api without contracts_for for now * chore: updated proposal * chore: updated tests for new proposal * maryia/80163/add-growth-rate-to-purchase-button * maryia/refactored purchase button growth_rate text * maryia/chore: removed unused code for outside barriers * maryia/fix: barrier shade color for ongoing contract * feat: restore chart mode set for non accumulators contract after switching (#37) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/80158/update ui according to latest design (design flow 1-2) (#36) * icon accumulator change * purchase btn, stats fix * fix styles, flow 1 * accumulator design flow 2 Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/80686/feat: profit text animation for ongoing contract (#39) * fix: showing profit text next to current spot for open contract * chore: animated profit text * feat: added animated profit text for ongoing contract * test: fixed a test * chore: removed unused variable * fix: maryia/80686/profit text color * fix: maryia/using default growth rate only if no stored growth rate * feat: allow accumulators only for demo account (#40) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/80158/update UI according to latest design part 2 (#38) * accu design chart position fix * accu page for reports rendering * reports card design fix * reports card design fix2 * updated design fix * pseudoelement colon fix * emphasizing value fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80687/ticks_contract_details (#41) * fix: tick markers in contract details & take profit logics * feat: showing only 10 last ticks for accumulators ongoing contract * chore: display all trade types when list is not empty * style: typo * chore: maryia/added opacity to profit text + connected contracts_for + refactoring * chore: improved tick stream for ACCU in contract details + stats alignment * chore: maryia/handled undefined profit & updated opacity animation timing * chore: temporary dummy api connection * fix: maryia/hide profit if undefined, display if number * revert: dummi api * feat: implement last design part 1 (#43) * feat: implement last design part 1 * fix: test text fix * refactor: stats style for mobile fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82425/task highlight crossing tick (#42) * feat: hightlighting crossing tick * feat: sync highlighting of crossing tick based on ticks_history_stats * Maryia/83069/task: replace image with video manual (#44) * feat: replaced manual image with video + responsive stats improvement * test: fixed a test * fix: entry tick marker in dtrader * style: removed extra margin-bottom * feat: implement last design part 2 (#45) * feat: implement last design part 2 * fix: initial growth_rate added * refactor: growth_rate from contract_for delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: accu sold contract tooltip animation change (#49) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82257/Contract Details tick markers + AccumulatorsProfitLossText refactoring (#48) * chore: saving canvas context before accu barriers are drawn and restoring when finished drawing * fix: endtime, avoid fetching history in replay, avoid 0 profit animation * chore: forcing chart reload when start_epoch changes to earlier epoch + refactored profit-text * refactor: accumulators-profit-loss-text * refactor: tooltip style and tests (#51) * refactor: tooltip style and tests * refactor: accumulator info text * refactor: profit tooltip text test add * refactor: radiogroupwithinfomobile test added * refactor: tickhistorycounter tests added * refactor: tickcounterbar test added Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/83311/Refactoring, tests, TS migration (#50) * refactor: purchase-buttons-overlay.spec.js from enzyme to jest * style: removed extra variable * refactor: from accumulator.js with chai to accumulator.spec.js with jest * refactor: removed unused dummy data * test: added tests for accumulators-stats-manual-modal.jsx * chore: improved accumulators-stats-manual-modal * refactor: incapsulated AccumulatorsChartElements in trade.jsx * fix: maryia/circleci eslint error * feat: maryia/added dark theme video manual for stats + fix for circleci * test: maryia/added tests for AccumulatorsInfoDisplay & LabeledQuantityInputMobile * chore: maryia/ address review comments + updated videos * fix: maryia/open positions: auto-select Accumulators if has open ACCU contracts * refactor: accumulatorschartelements test added (#52) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * style: maryia/apply review suggestions * style: maryia/apply review suggestions * refactor: maryia/refactoring + small improvements & adjustments * chore: add built icons file * fix: circleci tests + improvements * chore: refactoring + added loader before video manual first loads * refactor: improvements + addressed review comments * yauheni/qa checks refactoring 1 (#53) * refactor: open recent position after buying contract for mobile * fix: accu card curent stake name field * fix: popover accumulator radio group text and alignment * fix: open position accumulate column name Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: last truncated counter in responsive (#54) * Maryia/83807/stake validation (part 1) (#55) * fix: set growth_rate based on accumulator_range_list (growth_rate_range) received in contracts_for * fix: app crash caused by proposal error * chore: removed unused classname * fix: growth rate title alignment (#56) * fix: growht rate title alignment * refactor: category wrapper odd style Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/83807/fix: stake validation for ACCU broken because of barriers being set (#57) * fix: stake validation for ACCU broken because of barriers being set * fix: prevent app crash in profit table for unknown contracts * fix: check if selected growth_rate is available on symbol change (#58) * fix: able to buy multiply contract / growth rate fix BO change (#59) * fix: able to buy multiply contract / growth rate fix BO change * refactor: last contract check delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * revert: maryia/revert change of last_contract computed * fix: accumulator is shown for real account (#60) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * feat: make cursor not allowd for overlay (#61) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: built icons.js * revert: maryia/ unnecessary bot file change * refactor: contract categories in contract-type-widget.jsx * refactor: according to pr review comments * refactor: open positions + add keys to fix console warning * fix: disable accu for real account, disable button having bought one contract (#62) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: purchase.jsx * refactor: according to pr reviews * refactor: able to buy contract per every available underlying (#63) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Trigger Build * yauheni/85032/ fix chart issue with dots and circles Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: exit spot styles * refactor: make barrier values string as on BE * fix: unable accumulators for real * maryia/refactor_accu_branch (#66) * refactor: remove unused file * refactor: refactor createTickMarkers * refactor: introduce a local variable * fix: 86705/ticks are not displayed correctly on chart in contract details * maryia/86953/build: bump up deriv-charts version to 1.1.0 + improvement (#68) * build: bump up deriv-charts version * chore: show profit only when barriers are received * test: updated mocked props * build: maryia/removed extra package-lock.jsons * evgeniy /87215/87226/ info description / glitch while switching account (#70) * fix: description * fix: disable trade params while switching account --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * henry/87329/fix: FE not showing error message when accu trading is suspended (#72) * fix: FE not showing error message when accu trading is suspended * test: empty commit --------- Co-authored-by: HENRY <henry@regentmarkets.com> * refactor: glitching fix and deleted odd css (#73) * refactor: glitching fix and deleted odd css * fix: code refactor --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/86616/feat: calculating accu barriers based on ticks from ticks_history (#71) * feat: calculating accu barriers based on ticks from ticks_history * chore: rounded & refactored accu barriers * refactor: added getAccumulatorBarriers for barrier calculation + fixed a test * chore: improved barriers calculations * refactor: getAccumulatorBarriers docs * refactor: getAccumulatorBarriers * fix: showing barriers only when having have barriers & always showing barrier lines in C.Details * build: updated package-lock & icons + fixed conflicts + linting * fix: max stake validation is missing (#81) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: maryia/87948/chart empty issue + profit text effects clean-up * henry/87958/feat: Add Dropdown for rates in Accumulator (#86) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> --------- Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * Maryia/86616/make 2 last ticks bold + refactoring (#84) * chore: make prelast & last tick bold * chore: adjust styles for previous and last markers in c.details * refactor: getSupportedContracts & getContractTypeDisplay in configs * refactor: open-positions * refactor: chart-markers slyles * style: updated All rates casing * build: update package-lock * Henry/87958/feat add all rates dropdown accumulator (#89) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * chore: remove console log * fix: Change Open positions total for multiplier and accumulator to flex --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: open-positions * fix: remove unused eslint disable * revert: package-lock * fix: sell button disappearing in mobile accumulators (#92) * Henry/89489/fix sell button missing accumulator (#95) * fix: sell button disappearing in mobile accumulators * fix: fix cut off buy button issue * fix: remove commented out code * maryia/89432/fix: show barriers for current symbol correctly (#94) * fix: show barriers for current symbol * refactor: show barriers for current symbol only * Maryia/test: added tests for getAccumulatorBarriers function (#99) * test: added tests for getAccumulatorBarriers function * test: added tests for getAccumulatorBarriers function * test: renamed test cases for getAccumulatorBarriers function * Maryia/89927_2/fix: ticks_history not forgotten because of chart mode & granularity change (#101) * fix: logics for changing chart mode & granularity caused ticks_history streaming for previous symbol * fix: update chart mode just once when switching contract type * fix: maryia/fixed logics for chart mode switching * refactor: maryia/address review comments * Merge branch master of github.com:binary-com/deriv-app into maryia/67492/task_add_accumulators * Update vanilla-options-card-body.jsx * fix: vanillas + accumulators adjustments * fix: maryia/restore overriden accu change * fix: maryia/vanillas+accumulators adjustment * fix: maryia/ improvements + refactoring to address review comments * fix: maryia/ update c.details chart when end_epoch is defined * fix: reset accu barriers data on every contract type change * fix: revert ui-store to master * fix: chart mode change when switching to symbol without accu * fix: purchase button styling for accumulators (#109) Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> --------- Co-authored-by: Maryia <103177211+maryia-binary@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: hirad-deriv <hirad@re-work.dev>
niloofar-deriv
pushed a commit
that referenced
this pull request
May 18, 2023
* refactor: initial commit * revert: revert changes * chore: ts-migration for positions-card.tsx (#5) * chore: reports-table-row to tsx (#10) * chore: migrating error-components to tsx (#8) * chore: migrating error-components to tsx * fix: added partial to type * chore: migrate calendar-icon to tsx (#11) * chore: migrate calendar-icon to tsx * fix: updated extensions * chore: migrate list-item to tsx (#12) * chore: migrate currency-wrapper to ts (#17) * chore: migrate empty-portfolio-message to ts (#18) * chore: migrating reports meta to tsx (#23) * chore: migrate amount-cell to ts (#16) * chore: migrate amount-cell to ts * fix: delete component because it is unused * chore: migrating EmptyTradeHistoryMessage to tsx (#19) * chore: migrating EmptyTradeHistoryMessage to tsx * fix: remove extension * fix: migrated sidelist to tsx (#13) * fix: migrated sidelist to tsx * fix: circle-ci error * fix: sidelist types * chore: migrate composite calendar mobile to typescript (#26) * chore: migrate composite calendar mobile to typescript * fix: remove component extension from the name * refactor: ♻️ removed unused component (#30) * chore: migrate index file to typescript (#27) * refactor: ♻️ migrate component to tsx (#29) * chore: two-month-picker to tsx with one calendar component (#15) * chore: migrate account statistics to ts (#14) * chore: migrate account statistics to ts * fix: typo in comment * Akmal / chore: migrate routes config to typescript (#31) * chore: migrate routes config to typescript * fix: change type for component * Akmal / chore: migrate data-table-constants to typescript (#33) * chore: migrate data-table-constants to typescript * fix: refactor types * chore: migrate loading component to typescript (#36) * Aizad/73988/msir ts (#21) * chore: migrate market-symbol-icon-row to ts * fix: remove commented lines * fix: remove classname from IconTradeTypes * fix: removed action prop * Sergei / chore: migrate open-positions to tsx (#40) * chore: convert open-positions to tsx * fix: add React.PropsWithChildren to tabs.tsx * fix: change Tabs type * fix: add/change some types and fix some undefined values * refactor: use Return Early pattern for contract-card-sell component * chore: delete commented lines * chore: add moment as dev dependency * chore: commit to check circleCI * fix: change back tabs.tsx * fix: change React.Fragment to null * Akmal / chore: convert helpers to typescript (#28) * chore: convert elpers to typescript * fix: types * chore: migrate placeholder to tsx (#42) * chore: migate placeholder to tsx * fix: destructure props and remove React.propswithchildre * Sergei / 73980 / chore: ts migration of route-with-sub-routes (#45) * chore: ts migration of route-with-sub-routes * refactor: add common types to separate files * fix: get back composite-calendar * refactor: change path from absolute to relative for Types * Sergei / 73979 / chore: ts migration of binary-routes (#46) * chore: ts migration of binary-routes.jsx * chore: add TPassthrough type and add key as index when route.path is undefined * chore: add export for TBinaryRoutes type * refactor: use types from common types * Aizad/73977/binary link ts (#41) * chore: migrate routes folder to tsx * fix: change type for component * fix: migrated test cases to tsx * chore: migrate binary-links to tsx * fix: change back function names * fix: resolved conflict issues * fix: testcases * chore: migrated filter component and fix some issues with composite-c… (#20) * chore: migrated filter component and fix some issues with composite-calendar * fix: change export to CalendarIcon on index.js and added RootStore type to filter-components * fix: change TRootStore to RootStore * fix: replace RootStore to TRootStore * fix: expand object for filtered_date_range * Sergei / chore: ts migration of routes (#38) * chore: ts migration of routes * chore: change RootStore type * Aizad/73994/pss ts (#48) * chore: migrate progress-slider-stream to tsx * fix: imported TContractInfo inside deriv/shared/ * Sergei / chore: migrate statements to tsx (#39) * chore: ts migration of statements * chore: change RootStore type * chore: change local TRootStore with module property * fix: return class RootStore to Stores/index.ts * chore: change core_store type * chore: migrated indicative cell to tsx (#44) * chore: migrated indicative cell to tsx * fix: added types to usestate * fix: change type * fix: change function type to boolean * fix: imported TContractInfo from shared file into indicative-cell * fix: test * fix: mockstore * fix: format-response.ts * fix: mockstore * Aizad/73978/routes ts (#50) * Merge branch 'Improvement/72232/Reports_TS_migration' of github.com:mahdiyeh-deriv/deriv-app into ts-migration * chore: finalising routes folder migration for Reports package 📦 * Akmal / chore: migrate app.jsx to typescript (#37) * chore: migrate app.jsx to typescript * chore: utilize TRootStore type * chore: replace type * Akmal / chore: migrate composite calendar to typescript (#25) * chore: migrate composite calendar to typescript * chore: refactor composite calendar and related components to properly use moment * chore: move out index changes * feat: resolve conflicts * feat: add deriv stores package * Kate/73995/TS migration of Reports (#51) * refactor: migrate reports component into ts * refactor: add useStore hook * refactor: delete extra react fragment Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> --------- Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> * redeploy: rerun tests * refactor: remove named import from react * chore: migrate statement to tsx (#47) * chore: migrate statement to tsx * fix: use Statement props from api-types than declaring it in ts file * fix: imported TAccountStatistics inside statement * fix: made changes based on comments * fix: refactor based on suggestions * fix: types in packages/shared/src/utils/shortcode/shortcode.ts * fix: regex to prevent sonarcloud bug * chore: change index.js to index.ts * Rostislav / 73993 / Task - TS migration of ProfitTable (#34) * refactor: init pr * refactor: profit_loss_cell tsx'd * refactor: profit_loss_cell import problem resolved * refactor: profit_loss_cell import another problem fix * refactor: the migration is more or less finished * refactor: a few extra changes * refactor: prev commit accidental changes removed * refactor: TProfitTable type changed a bit * refactor: moved types to common-prop.type.ts * refactor: getSupportedContracts and getUnsupportedContracts moved to shared * refactor: contract.tsx completely replaced by imports from @deriv/shared * refactor: added alias for Types * refactor: applied suggested changes * fix: regex for sonarcloud * fix: remove props from the name of type declaration * fix: resolve comments * fix: fix comments v2 * fix: remove usestate * fix: date-time test * fix: comments v3 * thisyahlen/fix: trade table for mobile (#52) * fix: trade table for mobile * fix: trade table error * fix: statement input validation error on date_from * fix: setdate unix * fix: responsive input validation error * fix: remove unix from store --------- Co-authored-by: aizad-deriv <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farzin Mirzaie <72082844+farzin-deriv@users.noreply.github.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Thisyahlen Nair <thisyahlen@regentmarkets.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev>
jim-deriv
added a commit
that referenced
this pull request
May 25, 2023
* matin/chore: update branch (#8026) * thisyahlen/chore: new account verification modal for purchase authentication (#7936) * chore: new account verification modal for purchase authentication * fix: height and width * fix: modal footer css * fix: css mobile title * thisyahlen/fix: remove financial mt5 for norway and japan (#7846) * fix: remove financial mt5 for norway and japan * fix: resolved comments * fix: rename restricetd countries * fix: compare accounts table * fix: fix compare accounts table for norway/japan * fix: remove synthetic bvi for norway and japan * Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926) * chore: remove duplicate get_settings api request * chore: set account_settings in client-store if undefined * chore: remove unnecessary else block * refactor: convert if expression to ternary * chore: set account_settings in client store instead of creating a local variable * fix: :sparkles: allows users to enter accented name characters (#7832) * fix: :sparkles: allows users to enter accented name characters * chore: :wastebasket: removes unused 'letter_symbol' variable * fix: :bug: allows accented characters in name for existing users * docs: :pencil2: comment on the regex used for name validation * resused regex function Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * fix: :memo: imported reused regex function * fix: :memo: comment on regex function used --------- Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * Evgeniy / 89431 / no error message for idv duplicated document numbers (#7743) * fix: no error message for idv duplicated document numbers * feat: idv testing document whitelist * refactor: function rename, code and test fix * refactor: code style change, review fixes --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Hamid/90702/account switchers to wrong deriv account when performing deposit via bank wire (#7933) * chore: icon changes after build * fix: redirect user to non-eu account instead eu after cashier deposit switch account * Ameerul /Task 89855 Add a checkbox to select/deselect a payment method when creating or updating a sell ad and making a sell order (#7824) * chore: added checkbox to payment method card * fix: added logic to disable checkbox and show checkbox in certain tabs only * Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218) * fix: instantiating useVerifyEmail object once for each email verification case to avoid settimeout leak in useCountdown * chore: store verify_email_sent_count in store instead of locally * test: fix test for email-verification-empty-state.tsx * fix: avoid counter reset by storing and using the time an email was last sent * chore: a workaround for VerifyEmailRequest type declared with an extra required field in api-types * chore: remove api-types workaround * build: update @deriv/api-types to 1.0.85 * revert: api-types version upgrade * revert: package-lock * revert: modal-manager.jsx * revert: modal-manager.jsx * thisyahlen/fix: error when switch to mf (#7778) * fix: error when switch to mf * fix: addressed comments * fix: addressed comments v2 * chore: fix tooltip language not updating on change language (#7871) * chore: fix tooltip language not updating on change language * fix: added checks for currency in trade store * fix: added delete amount validation rules in reaction * fix: remove delete rule in reaction * fix: remove mistake * fix: typo * Aizad/89113/sidebar platform fix (#7697) * chore: fix mobile sidebar platform for eu * fix: codecov error * fix: codecov error * chore: update packages * Nada/88951/change chat url (#7798) * fix: get chat url from p2p_order_create instead of p2p_chat_create * fix: fixed issue with order details page * fix: chat channel url empty issue fixed for p2p_order_create response * fix: function added to store * fix: added timeout for setting chat_channel in order details * fix: pr comments fixed * fix: increased time out * fix: removed delay for going to details page from list * thisyahlen/fix: top up mt5 demo (#7665) * fix: top up demo * fix: deriv x as well * redeploy: a * chore: update pdf in acuity download modal (#7567) * fix: filter currencies by name (#7493) * fix: changed pop up message for no recommendations (#7693) * Aizad/89700/onboarding btn fix (#7813) * chore: disable cursor on account switcher button onboarding * fix: Add the same behavior for Options and Multipliers section Trade Button * fix: added default class and refactor scss * Nada/89550/remove validation ad amount (#7753) * fix: removed error validation for amount greater than user's balance * fix: added popup for creating ad greater than balance * fix: pr comments fixed * fix: reuse common modal for visibility errors * Aizad/88786/mt5 redirection modal fix (#7663) * chore: fix mt5 redirection modal closing on trade * fix: modal and dialog close seperately after clicking outside * fix: re-add dialog_status condition back to redirect-notice-modal * fix: reverted the previous changes * fix: remove useclickoutside for page overlay * fix: update deriv/api package to latest version * fix: updated package version to match with master * Merge branch 'develop' of github.com:binary-com/deriv-app into aizad/88786/mt5-redirection-modal-fix * fix: codecov and circleci * fix: upgrade package * fix: theme switch in poroduction (#7781) * translations: 📚 sync translations with crowdin (#7989) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * yashim/chore: remove indonesia from production (#7999) * chore: remove trading experience incomplete (#8005) * chore: remove trading experience incomplete * fix: remove is cfd score available * thisyahlen/hotfix: wrong restriction message for austria (#8006) * hotfix: wrong restriction message for austria * fix: Empty-Commit * Revert "thisyahlen/hotfix: wrong restriction message for austria (#8006)" (#8013) This reverts commit 56baec7d879efd25f05249323911641ce069ab63. * Revert "Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926)" (#8016) This reverts commit 8bb13518f4cebd42bc3d2a602807d7c1b6aa5b6a. * fix: :bug: fetches latest personal details every time intead of cached value (#8002) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter a… (#8020) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218)" This reverts commit cc0065d02761a33502405d35a47a45696292858d. * revert: reverted setIsCFDScoreAvailable from client.store * Revert "fix: :bug: fetches latest personal details every time intead of cached value (#8002)" (#8022) This reverts commit ff497c14ec9fe0b831031b0d9bae1532f9c47456. --------- Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Shaheer <122449658+shaheer-deriv@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Hamid <hamid@deriv.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@deriv.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * hamza/90127/91316/sub-feat: swapfree onboarding screen addition v1.0 (#7961) * feat: swapfree onboarding screen addition v1.0 * fix: name changes and Title updated as per design * Syncing Master with the Feature Brnach of Swapfree (#8056) * thisyahlen/chore: new account verification modal for purchase authentication (#7936) * chore: new account verification modal for purchase authentication * fix: height and width * fix: modal footer css * fix: css mobile title * thisyahlen/fix: remove financial mt5 for norway and japan (#7846) * fix: remove financial mt5 for norway and japan * fix: resolved comments * fix: rename restricetd countries * fix: compare accounts table * fix: fix compare accounts table for norway/japan * fix: remove synthetic bvi for norway and japan * Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926) * chore: remove duplicate get_settings api request * chore: set account_settings in client-store if undefined * chore: remove unnecessary else block * refactor: convert if expression to ternary * chore: set account_settings in client store instead of creating a local variable * fix: :sparkles: allows users to enter accented name characters (#7832) * fix: :sparkles: allows users to enter accented name characters * chore: :wastebasket: removes unused 'letter_symbol' variable * fix: :bug: allows accented characters in name for existing users * docs: :pencil2: comment on the regex used for name validation * resused regex function Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * fix: :memo: imported reused regex function * fix: :memo: comment on regex function used --------- Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * Evgeniy / 89431 / no error message for idv duplicated document numbers (#7743) * fix: no error message for idv duplicated document numbers * feat: idv testing document whitelist * refactor: function rename, code and test fix * refactor: code style change, review fixes --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Hamid/90702/account switchers to wrong deriv account when performing deposit via bank wire (#7933) * chore: icon changes after build * fix: redirect user to non-eu account instead eu after cashier deposit switch account * Ameerul /Task 89855 Add a checkbox to select/deselect a payment method when creating or updating a sell ad and making a sell order (#7824) * chore: added checkbox to payment method card * fix: added logic to disable checkbox and show checkbox in certain tabs only * Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218) * fix: instantiating useVerifyEmail object once for each email verification case to avoid settimeout leak in useCountdown * chore: store verify_email_sent_count in store instead of locally * test: fix test for email-verification-empty-state.tsx * fix: avoid counter reset by storing and using the time an email was last sent * chore: a workaround for VerifyEmailRequest type declared with an extra required field in api-types * chore: remove api-types workaround * build: update @deriv/api-types to 1.0.85 * revert: api-types version upgrade * revert: package-lock * revert: modal-manager.jsx * revert: modal-manager.jsx * thisyahlen/fix: error when switch to mf (#7778) * fix: error when switch to mf * fix: addressed comments * fix: addressed comments v2 * chore: fix tooltip language not updating on change language (#7871) * chore: fix tooltip language not updating on change language * fix: added checks for currency in trade store * fix: added delete amount validation rules in reaction * fix: remove delete rule in reaction * fix: remove mistake * fix: typo * Aizad/89113/sidebar platform fix (#7697) * chore: fix mobile sidebar platform for eu * fix: codecov error * fix: codecov error * chore: update packages * Nada/88951/change chat url (#7798) * fix: get chat url from p2p_order_create instead of p2p_chat_create * fix: fixed issue with order details page * fix: chat channel url empty issue fixed for p2p_order_create response * fix: function added to store * fix: added timeout for setting chat_channel in order details * fix: pr comments fixed * fix: increased time out * fix: removed delay for going to details page from list * thisyahlen/fix: top up mt5 demo (#7665) * fix: top up demo * fix: deriv x as well * redeploy: a * chore: update pdf in acuity download modal (#7567) * fix: filter currencies by name (#7493) * fix: changed pop up message for no recommendations (#7693) * Aizad/89700/onboarding btn fix (#7813) * chore: disable cursor on account switcher button onboarding * fix: Add the same behavior for Options and Multipliers section Trade Button * fix: added default class and refactor scss * Nada/89550/remove validation ad amount (#7753) * fix: removed error validation for amount greater than user's balance * fix: added popup for creating ad greater than balance * fix: pr comments fixed * fix: reuse common modal for visibility errors * Aizad/88786/mt5 redirection modal fix (#7663) * chore: fix mt5 redirection modal closing on trade * fix: modal and dialog close seperately after clicking outside * fix: re-add dialog_status condition back to redirect-notice-modal * fix: reverted the previous changes * fix: remove useclickoutside for page overlay * fix: update deriv/api package to latest version * fix: updated package version to match with master * Merge branch 'develop' of github.com:binary-com/deriv-app into aizad/88786/mt5-redirection-modal-fix * fix: codecov and circleci * fix: upgrade package * fix: theme switch in poroduction (#7781) * translations: 📚 sync translations with crowdin (#7989) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * yashim/chore: remove indonesia from production (#7999) * chore: remove trading experience incomplete (#8005) * chore: remove trading experience incomplete * fix: remove is cfd score available * thisyahlen/hotfix: wrong restriction message for austria (#8006) * hotfix: wrong restriction message for austria * fix: Empty-Commit * Revert "thisyahlen/hotfix: wrong restriction message for austria (#8006)" (#8013) This reverts commit 56baec7d879efd25f05249323911641ce069ab63. * Revert "Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926)" (#8016) This reverts commit 8bb13518f4cebd42bc3d2a602807d7c1b6aa5b6a. * fix: :bug: fetches latest personal details every time intead of cached value (#8002) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter a… (#8020) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218)" This reverts commit cc0065d02761a33502405d35a47a45696292858d. * revert: reverted setIsCFDScoreAvailable from client.store * Revert "fix: :bug: fetches latest personal details every time intead of cached value (#8002)" (#8022) This reverts commit ff497c14ec9fe0b831031b0d9bae1532f9c47456. * Adrienne / Prefetched email verification modal (#8027) * chore: prefetched email verification modal * chore: added settimoeut * chore: used eager mode * chore: import model directly * chore: reverted direct imports * chore: added settimeout * translations: 📚 sync translations with crowdin (#8031) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8040) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: yashim-deriv <yashim@deriv.com> * Maryia/67492/task_add_accumulators (#6406) * Merge '67492_accumulators_purchase' into 'maryia/67492/task_add_accumulators' * Maryia/75617/add_accu_to_trade_params (#3) * initialized ACCU trade params for responsive * added LabeledQuantityInputMobile & improved AccumulatorsAmountMobile * feat: added Accumulator radio group for growth_rate * feat: finalized Accumulator growth_rates radio group for mobile * feat: responsive- added Take profit to trade params & aligned purchase button icon * feat: improved mobile trade params for ACCU * feat: finalized trade params for ACCU * maryia/72761/task_add_recent_positions_drawer (#4) * feat: initialized ACCU contract card in recent positions * feat: initialized ProgressSliderSolidLine for ACCU * feat: updated recent positions card for ACCU for open/lost/won states * chore: improvements for ACCU card in responsive recent positions * chore: added TickCounterProgressBar component * feat: added TickCounterBar and reverted ProgressSlider & ProgressSliderMobile * chore: reverted original Recent positions drawer width * chore: improved TickCounterBar styling * maryia/76528/task_implement_contract_details_drawer (#5) * chore: updated Details in contract card for ACCU + styling * feat: implemented ACCU contract card in contract details + improved recent positions * chore: updated icons for ACCU trade type & contract category * maryia/72769/add_ticks_history_stats_widget (#6) * feat: init version of TicksHistoryStatsWidget for ACCU * chore: TicksHistoryStats * chore: improved tick history styling * chore: added more styles & animated progress dots under latest counter * feat: finalized desktop ticks history stats for dtrader page * feat: added ticks history to contract details page * improved ticks history stats for desktop & initialized it for responsive * made responsive stats non-expandable * maryia/77261/task_manual_for_history_widget (#8) * chore: discarded getUpdatedTicksHistoryStats as BE will send 15 exact values instead of 100+latest * feat: added AccumulatorsStatsManualModal * feat: finalized AccumulatorsStatsManualModal for desktop & responsive * chore: added getUpdatedTicksHistoryStats to process arrays of counters with epochs expected from BE * feat: added expanded AccumulatorsStats dialog for responsive * chore: contract card styling improvements + using ACCU tick_count as max_ticks_number * chore: improved AccumulatorsStats to load after tick counters have loaded * maryia/75621/task_add_tests_and_restyle_contract_card (#9) * chore: improved ACCU contract type icon & label styling in contract card * chore: added tests for accumulator.js helper function * chore: added tests for Accumulator.jsx * maryia/75621/part_2_task_accu_barriers (#10) * chore: updated dummy data * chore: fixed history stats styles & added tests for AccumulatorsStats * chore: improved AccumulatorsStats and its tests * chore: updated contract card & open positions * maryia/75621/add barriers for stay in contract on trader page (#12) * chore: test out passing trade data to all-markers for drawing barriers without contract + improvements * feat: added barriers for accumulators without open contract * feat: added markers and barriers for stay in contract on trader page * chore: adjusted open contract profit label (#13) * yauheni/77994/trader add break out contract type (#14) * yauheni/77994/trader add break out contract type * regexp fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/78429/update styles of tick history widget (#15) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: prepared data for connecting API (#16) * Maryia/78473/part 2 prepare for api + improvements (#18) * chore: improved barriers without contract and open contract label * chore: prepared data for api connection * chore: added price tags for barriers in contract details (#19) * feat: initialized AccumulatorsProfitLossTooltip (#20) * yauheni/78477/update params with buttons for responsive (#17) * yauheni/78477/update params with buttons for responsive * fix styles accordingly to design * buttons gap fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/resolve build errors (#21) * yauheni/resolve build errors * optional property for is_checkbox_hidden Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/78633/update styles for tick history widget (#22) * yauheni/resolve build errors * yauheni/78633/update styles for tick history widget * yauheni/78633/update styles for tick history widget responsive Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/78839/complete_sold_labels (#23) * chore: added tolltips for all sold positions & won/lost coloring * feat: finalized AccumulatorsProfitLossTooltip * maryia/improvements for stats and tooltip (#24) * chore: accumulators stats improvements * improvements * maryia/improvements for sold contract label * maryia/78574/add_barriers_to_contract_details * maryia/79085/remove_break_out_history_from_stats_widget (#26) * maryia/79085/remove_break_out_history_from_stats * chore: made purchaseButtonsOverlay flexible * chore: added tests for PurchaseButtonsOverlay * Yauheni/77995/update trade params for stayin breakout (#25) * yauheni/77995/update trade params for stayin breakout * take profit alimngment * buttons styles, take profit alingment * maryia/78574/add_barriers_to_contract_details * stake font and icon fix, go_tp_reports button styles * update contract store from parent Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: maryia-binary <maryia@binary.com> * maryia/fix: styles & fonts for responsive trade types * Maryia/79549/part 1: update tick markers for ACCU in contract details + improvements (#27) * maryia/79549/add_tick_markers_contract_details * chore: improvements for styles in responsive trade types desc * yauheni/79530/remove breakout contract (#28) * yauheni/79530/remove breakout contract * proposal data fields fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/styling improvements * maryia/fix: forcing Div100vh to re-render when height_offset for responsive has changed * maryia/fix: observables + markers * maryia/chore: prevented barriers, labels and markers from going outside axes (#30) * maryia/79969/set_default_chart_type_and_interval_to_Area_and_1_tick * maryia/chore: changed trade type name to Accumulators * maryia/80163/set growth rate based on default value from BE contracts_for response * yauheni/80091/hide chart mode icon for accumulators (#33) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80166/connect_to_available_API (#34) * chore: connected api without contracts_for for now * chore: updated proposal * chore: updated tests for new proposal * maryia/80163/add-growth-rate-to-purchase-button * maryia/refactored purchase button growth_rate text * maryia/chore: removed unused code for outside barriers * maryia/fix: barrier shade color for ongoing contract * feat: restore chart mode set for non accumulators contract after switching (#37) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/80158/update ui according to latest design (design flow 1-2) (#36) * icon accumulator change * purchase btn, stats fix * fix styles, flow 1 * accumulator design flow 2 Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/80686/feat: profit text animation for ongoing contract (#39) * fix: showing profit text next to current spot for open contract * chore: animated profit text * feat: added animated profit text for ongoing contract * test: fixed a test * chore: removed unused variable * fix: maryia/80686/profit text color * fix: maryia/using default growth rate only if no stored growth rate * feat: allow accumulators only for demo account (#40) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/80158/update UI according to latest design part 2 (#38) * accu design chart position fix * accu page for reports rendering * reports card design fix * reports card design fix2 * updated design fix * pseudoelement colon fix * emphasizing value fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80687/ticks_contract_details (#41) * fix: tick markers in contract details & take profit logics * feat: showing only 10 last ticks for accumulators ongoing contract * chore: display all trade types when list is not empty * style: typo * chore: maryia/added opacity to profit text + connected contracts_for + refactoring * chore: improved tick stream for ACCU in contract details + stats alignment * chore: maryia/handled undefined profit & updated opacity animation timing * chore: temporary dummy api connection * fix: maryia/hide profit if undefined, display if number * revert: dummi api * feat: implement last design part 1 (#43) * feat: implement last design part 1 * fix: test text fix * refactor: stats style for mobile fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82425/task highlight crossing tick (#42) * feat: hightlighting crossing tick * feat: sync highlighting of crossing tick based on ticks_history_stats * Maryia/83069/task: replace image with video manual (#44) * feat: replaced manual image with video + responsive stats improvement * test: fixed a test * fix: entry tick marker in dtrader * style: removed extra margin-bottom * feat: implement last design part 2 (#45) * feat: implement last design part 2 * fix: initial growth_rate added * refactor: growth_rate from contract_for delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: accu sold contract tooltip animation change (#49) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82257/Contract Details tick markers + AccumulatorsProfitLossText refactoring (#48) * chore: saving canvas context before accu barriers are drawn and restoring when finished drawing * fix: endtime, avoid fetching history in replay, avoid 0 profit animation * chore: forcing chart reload when start_epoch changes to earlier epoch + refactored profit-text * refactor: accumulators-profit-loss-text * refactor: tooltip style and tests (#51) * refactor: tooltip style and tests * refactor: accumulator info text * refactor: profit tooltip text test add * refactor: radiogroupwithinfomobile test added * refactor: tickhistorycounter tests added * refactor: tickcounterbar test added Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/83311/Refactoring, tests, TS migration (#50) * refactor: purchase-buttons-overlay.spec.js from enzyme to jest * style: removed extra variable * refactor: from accumulator.js with chai to accumulator.spec.js with jest * refactor: removed unused dummy data * test: added tests for accumulators-stats-manual-modal.jsx * chore: improved accumulators-stats-manual-modal * refactor: incapsulated AccumulatorsChartElements in trade.jsx * fix: maryia/circleci eslint error * feat: maryia/added dark theme video manual for stats + fix for circleci * test: maryia/added tests for AccumulatorsInfoDisplay & LabeledQuantityInputMobile * chore: maryia/ address review comments + updated videos * fix: maryia/open positions: auto-select Accumulators if has open ACCU contracts * refactor: accumulatorschartelements test added (#52) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * style: maryia/apply review suggestions * style: maryia/apply review suggestions * refactor: maryia/refactoring + small improvements & adjustments * chore: add built icons file * fix: circleci tests + improvements * chore: refactoring + added loader before video manual first loads * refactor: improvements + addressed review comments * yauheni/qa checks refactoring 1 (#53) * refactor: open recent position after buying contract for mobile * fix: accu card curent stake name field * fix: popover accumulator radio group text and alignment * fix: open position accumulate column name Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: last truncated counter in responsive (#54) * Maryia/83807/stake validation (part 1) (#55) * fix: set growth_rate based on accumulator_range_list (growth_rate_range) received in contracts_for * fix: app crash caused by proposal error * chore: removed unused classname * fix: growth rate title alignment (#56) * fix: growht rate title alignment * refactor: category wrapper odd style Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/83807/fix: stake validation for ACCU broken because of barriers being set (#57) * fix: stake validation for ACCU broken because of barriers being set * fix: prevent app crash in profit table for unknown contracts * fix: check if selected growth_rate is available on symbol change (#58) * fix: able to buy multiply contract / growth rate fix BO change (#59) * fix: able to buy multiply contract / growth rate fix BO change * refactor: last contract check delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * revert: maryia/revert change of last_contract computed * fix: accumulator is shown for real account (#60) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * feat: make cursor not allowd for overlay (#61) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: built icons.js * revert: maryia/ unnecessary bot file change * refactor: contract categories in contract-type-widget.jsx * refactor: according to pr review comments * refactor: open positions + add keys to fix console warning * fix: disable accu for real account, disable button having bought one contract (#62) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: purchase.jsx * refactor: according to pr reviews * refactor: able to buy contract per every available underlying (#63) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Trigger Build * yauheni/85032/ fix chart issue with dots and circles Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: exit spot styles * refactor: make barrier values string as on BE * fix: unable accumulators for real * maryia/refactor_accu_branch (#66) * refactor: remove unused file * refactor: refactor createTickMarkers * refactor: introduce a local variable * fix: 86705/ticks are not displayed correctly on chart in contract details * maryia/86953/build: bump up deriv-charts version to 1.1.0 + improvement (#68) * build: bump up deriv-charts version * chore: show profit only when barriers are received * test: updated mocked props * build: maryia/removed extra package-lock.jsons * evgeniy /87215/87226/ info description / glitch while switching account (#70) * fix: description * fix: disable trade params while switching account --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * henry/87329/fix: FE not showing error message when accu trading is suspended (#72) * fix: FE not showing error message when accu trading is suspended * test: empty commit --------- Co-authored-by: HENRY <henry@regentmarkets.com> * refactor: glitching fix and deleted odd css (#73) * refactor: glitching fix and deleted odd css * fix: code refactor --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/86616/feat: calculating accu barriers based on ticks from ticks_history (#71) * feat: calculating accu barriers based on ticks from ticks_history * chore: rounded & refactored accu barriers * refactor: added getAccumulatorBarriers for barrier calculation + fixed a test * chore: improved barriers calculations * refactor: getAccumulatorBarriers docs * refactor: getAccumulatorBarriers * fix: showing barriers only when having have barriers & always showing barrier lines in C.Details * build: updated package-lock & icons + fixed conflicts + linting * fix: max stake validation is missing (#81) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: maryia/87948/chart empty issue + profit text effects clean-up * henry/87958/feat: Add Dropdown for rates in Accumulator (#86) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> --------- Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * Maryia/86616/make 2 last ticks bold + refactoring (#84) * chore: make prelast & last tick bold * chore: adjust styles for previous and last markers in c.details * refactor: getSupportedContracts & getContractTypeDisplay in configs * refactor: open-positions * refactor: chart-markers slyles * style: updated All rates casing * build: update package-lock * Henry/87958/feat add all rates dropdown accumulator (#89) * feat: Add Dropdown for rates in Accumulator * chore: code cleanup * Update packages/reports/src/Containers/open-positions.jsx Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * chore: remove console log * fix: Change Open positions total for multiplier and accumulator to flex --------- Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> * refactor: open-positions * fix: remove unused eslint disable * revert: package-lock * fix: sell button disappearing in mobile accumulators (#92) * Henry/89489/fix sell button missing accumulator (#95) * fix: sell button disappearing in mobile accumulators * fix: fix cut off buy button issue * fix: remove commented out code * maryia/89432/fix: show barriers for current symbol correctly (#94) * fix: show barriers for current symbol * refactor: show barriers for current symbol only * Maryia/test: added tests for getAccumulatorBarriers function (#99) * test: added tests for getAccumulatorBarriers function * test: added tests for getAccumulatorBarriers function * test: renamed test cases for getAccumulatorBarriers function * Maryia/89927_2/fix: ticks_history not forgotten because of chart mode & granularity change (#101) * fix: logics for changing chart mode & granularity caused ticks_history streaming for previous symbol * fix: update chart mode just once when switching contract type * fix: maryia/fixed logics for chart mode switching * refactor: maryia/address review comments * Merge branch master of github.com:binary-com/deriv-app into maryia/67492/task_add_accumulators * Update vanilla-options-card-body.jsx * fix: vanillas + accumulators adjustments * fix: maryia/restore overriden accu change * fix: maryia/vanillas+accumulators adjustment * fix: maryia/ improvements + refactoring to address review comments * fix: maryia/ update c.details chart when end_epoch is defined * fix: reset accu barriers data on every contract type change * fix: revert ui-store to master * fix: chart mode change when switching to symbol without accu * fix: purchase button styling for accumulators (#109) Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> --------- Co-authored-by: Maryia <103177211+maryia-binary@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: hirad-deriv <hirad@re-work.dev> * Amina /77701_make signup form fields immutable if they are immutable from BE (#7544) * adding validation * changeablle fields from client store * mutate address fields * fix: test case * fix: test case * fix: spec_file * fix: making employment status immutable * fix: trading assessment * fix: trading assessment * fix: trading assessment * fix: test case after merge conflict * fix: hide idv section when client is age verified * fix: remove idv_disallowed check * chore: merge master * fix: add new status --------- Co-authored-by: hirad-deriv <hirad@re-work.dev> * translations: 📚 sync translations with crowdin (#8048) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8049) Co-authored-by: yashim-deriv <yashim@deriv.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8050) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> --------- Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Shaheer <122449658+shaheer-deriv@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Hamid <hamid@deriv.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: Yashim Wong <yashim@deriv.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-binary@users.noreply.github.com> Co-authored-by: yauheni-kryzhyk-deriv <103182683+yauheni-kryzhyk-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: HENRY <henry@regentmarkets.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: Henry Hein <henryhein@Henry-Heins-MacBook-Pro-T90XTJ00Q4.local> Co-authored-by: hirad-deriv <hirad@re-work.dev> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> * feat: demo account creation and payload updated v1.0 (#8058) * feat: demo account creation and payload updated v1.0 * feat: demo fix Trade Popup * feat: demo and real popup fixed with deriv api-types type missing v1.2 * fix: real Get more content modal updated * fix: modal title for demo and svg account * fix: modal title for demo and svg account v1.3 * fix: get more button fix real v1.4 * fix: juridisction modal * fix: transfer icon cashier updated * fix: transfer icon cashier updated v1.2 * fix: modal unmount selected account type on close * chore: Demo text added v1.0 * fix: test coverage * fix: title for demo top up * fix: Demo added in the title for demo * fix: cfd account card * fix: juridisction content change * fix: juridisction content change + leverage fix * refactor: type checks and reviewed suggestions * refactor: hook with test cases added as per review comment * refactor: function added and switch case changed to localize to support different language scenario * Feat sub 90127 syncing the master with swapfree development (#8196) * thisyahlen/chore: new account verification modal for purchase authentication (#7936) * chore: new account verification modal for purchase authentication * fix: height and width * fix: modal footer css * fix: css mobile title * thisyahlen/fix: remove financial mt5 for norway and japan (#7846) * fix: remove financial mt5 for norway and japan * fix: resolved comments * fix: rename restricetd countries * fix: compare accounts table * fix: fix compare accounts table for norway/japan * fix: remove synthetic bvi for norway and japan * Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926) * chore: remove duplicate get_settings api request * chore: set account_settings in client-store if undefined * chore: remove unnecessary else block * refactor: convert if expression to ternary * chore: set account_settings in client store instead of creating a local variable * fix: :sparkles: allows users to enter accented name characters (#7832) * fix: :sparkles: allows users to enter accented name characters * chore: :wastebasket: removes unused 'letter_symbol' variable * fix: :bug: allows accented characters in name for existing users * docs: :pencil2: comment on the regex used for name validation * resused regex function Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * fix: :memo: imported reused regex function * fix: :memo: comment on regex function used --------- Co-authored-by: Yashim Wong <yashim@regentmarkets.com> * Evgeniy / 89431 / no error message for idv duplicated document numbers (#7743) * fix: no error message for idv duplicated document numbers * feat: idv testing document whitelist * refactor: function rename, code and test fix * refactor: code style change, review fixes --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Hamid/90702/account switchers to wrong deriv account when performing deposit via bank wire (#7933) * chore: icon changes after build * fix: redirect user to non-eu account instead eu after cashier deposit switch account * Ameerul /Task 89855 Add a checkbox to select/deselect a payment method when creating or updating a sell ad and making a sell order (#7824) * chore: added checkbox to payment method card * fix: added logic to disable checkbox and show checkbox in certain tabs only * Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218) * fix: instantiating useVerifyEmail object once for each email verification case to avoid settimeout leak in useCountdown * chore: store verify_email_sent_count in store instead of locally * test: fix test for email-verification-empty-state.tsx * fix: avoid counter reset by storing and using the time an email was last sent * chore: a workaround for VerifyEmailRequest type declared with an extra required field in api-types * chore: remove api-types workaround * build: update @deriv/api-types to 1.0.85 * revert: api-types version upgrade * revert: package-lock * revert: modal-manager.jsx * revert: modal-manager.jsx * thisyahlen/fix: error when switch to mf (#7778) * fix: error when switch to mf * fix: addressed comments * fix: addressed comments v2 * chore: fix tooltip language not updating on change language (#7871) * chore: fix tooltip language not updating on change language * fix: added checks for currency in trade store * fix: added delete amount validation rules in reaction * fix: remove delete rule in reaction * fix: remove mistake * fix: typo * Aizad/89113/sidebar platform fix (#7697) * chore: fix mobile sidebar platform for eu * fix: codecov error * fix: codecov error * chore: update packages * Nada/88951/change chat url (#7798) * fix: get chat url from p2p_order_create instead of p2p_chat_create * fix: fixed issue with order details page * fix: chat channel url empty issue fixed for p2p_order_create response * fix: function added to store * fix: added timeout for setting chat_channel in order details * fix: pr comments fixed * fix: increased time out * fix: removed delay for going to details page from list * thisyahlen/fix: top up mt5 demo (#7665) * fix: top up demo * fix: deriv x as well * redeploy: a * chore: update pdf in acuity download modal (#7567) * fix: filter currencies by name (#7493) * fix: changed pop up message for no recommendations (#7693) * Aizad/89700/onboarding btn fix (#7813) * chore: disable cursor on account switcher button onboarding * fix: Add the same behavior for Options and Multipliers section Trade Button * fix: added default class and refactor scss * Nada/89550/remove validation ad amount (#7753) * fix: removed error validation for amount greater than user's balance * fix: added popup for creating ad greater than balance * fix: pr comments fixed * fix: reuse common modal for visibility errors * Aizad/88786/mt5 redirection modal fix (#7663) * chore: fix mt5 redirection modal closing on trade * fix: modal and dialog close seperately after clicking outside * fix: re-add dialog_status condition back to redirect-notice-modal * fix: reverted the previous changes * fix: remove useclickoutside for page overlay * fix: update deriv/api package to latest version * fix: updated package version to match with master * Merge branch 'develop' of github.com:binary-com/deriv-app into aizad/88786/mt5-redirection-modal-fix * fix: codecov and circleci * fix: upgrade package * fix: theme switch in poroduction (#7781) * translations: 📚 sync translations with crowdin (#7989) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * yashim/chore: remove indonesia from production (#7999) * chore: remove trading experience incomplete (#8005) * chore: remove trading experience incomplete * fix: remove is cfd score available * thisyahlen/hotfix: wrong restriction message for austria (#8006) * hotfix: wrong restriction message for austria * fix: Empty-Commit * Revert "thisyahlen/hotfix: wrong restriction message for austria (#8006)" (#8013) This reverts commit 56baec7d879efd25f05249323911641ce069ab63. * Revert "Jim/88166/delay in real account creation flow after clicking add account button in the account creation popup (#7926)" (#8016) This reverts commit 8bb13518f4cebd42bc3d2a602807d7c1b6aa5b6a. * fix: :bug: fetches latest personal details every time intead of cached value (#8002) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter a… (#8020) * Revert "Maryia/80948/fix: avoid rate limit error by storing counter after sending verification email in Withdrawal (#7218)" This reverts commit cc0065d02761a33502405d35a47a45696292858d. * revert: reverted setIsCFDScoreAvailable from client.store * Revert "fix: :bug: fetches latest personal details every time intead of cached value (#8002)" (#8022) This reverts commit ff497c14ec9fe0b831031b0d9bae1532f9c47456. * Adrienne / Prefetched email verification modal (#8027) * chore: prefetched email verification modal * chore: added settimoeut * chore: used eager mode * chore: import model directly * chore: reverted direct imports * chore: added settimeout * translations: 📚 sync translations with crowdin (#8031) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * translations: 📚 sync translations with crowdin (#8040) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: yashim-deriv <yashim@deriv.com> * Maryia/67492/task_add_accumulators (#6406) * Merge '67492_accumulators_purchase' into 'maryia/67492/task_add_accumulators' * Maryia/75617/add_accu_to_trade_params (#3) * initialized ACCU trade params for responsive * added LabeledQuantityInputMobile & improved AccumulatorsAmountMobile * feat: added Accumulator radio group for growth_rate * feat: finalized Accumulator growth_rates radio group for mobile * feat: responsive- added Take profit to trade params & aligned purchase button icon * feat: improved mobile trade params for ACCU * feat: finalized trade params for ACCU * maryia/72761/task_add_recent_positions_drawer (#4) * feat: initialized ACCU contract card in recent positions * feat: initialized ProgressSliderSolidLine for ACCU * feat: updated recent positions card for ACCU for open/lost/won states * chore: improvements for ACCU card in responsive recent positions * chore: added TickCounterProgressBar component * feat: added TickCounterBar and reverted ProgressSlider & ProgressSliderMobile * chore: reverted original Recent positions drawer width * chore: improved TickCounterBar styling * maryia/76528/task_implement_contract_details_drawer (#5) * chore: updated Details in contract card for ACCU + styling * feat: implemented ACCU contract card in contract details + improved recent positions * chore: updated icons for ACCU trade type & contract category * maryia/72769/add_ticks_history_stats_widget (#6) * feat: init version of TicksHistoryStatsWidget for ACCU * chore: TicksHistoryStats * chore: improved tick history styling * chore: added more styles & animated progress dots under latest counter * feat: finalized desktop ticks history stats for dtrader page * feat: added ticks history to contract details page * improved ticks history stats for desktop & initialized it for responsive * made responsive stats non-expandable * maryia/77261/task_manual_for_history_widget (#8) * chore: discarded getUpdatedTicksHistoryStats as BE will send 15 exact values instead of 100+latest * feat: added AccumulatorsStatsManualModal * feat: finalized AccumulatorsStatsManualModal for desktop & responsive * chore: added getUpdatedTicksHistoryStats to process arrays of counters with epochs expected from BE * feat: added expanded AccumulatorsStats dialog for responsive * chore: contract card styling improvements + using ACCU tick_count as max_ticks_number * chore: improved AccumulatorsStats to load after tick counters have loaded * maryia/75621/task_add_tests_and_restyle_contract_card (#9) * chore: improved ACCU contract type icon & label styling in contract card * chore: added tests for accumulator.js helper function * chore: added tests for Accumulator.jsx * maryia/75621/part_2_task_accu_barriers (#10) * chore: updated dummy data * chore: fixed history stats styles & added tests for AccumulatorsStats * chore: improved AccumulatorsStats and its tests * chore: updated contract card & open positions * maryia/75621/add barriers for stay in contract on trader page (#12) * chore: test out passing trade data to all-markers for drawing barriers without contract + improvements * feat: added barriers for accumulators without open contract * feat: added markers and barriers for stay in contract on trader page * chore: adjusted open contract profit label (#13) * yauheni/77994/trader add break out contract type (#14) * yauheni/77994/trader add break out contract type * regexp fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/78429/update styles of tick history widget (#15) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: prepared data for connecting API (#16) * Maryia/78473/part 2 prepare for api + improvements (#18) * chore: improved barriers without contract and open contract label * chore: prepared data for api connection * chore: added price tags for barriers in contract details (#19) * feat: initialized AccumulatorsProfitLossTooltip (#20) * yauheni/78477/update params with buttons for responsive (#17) * yauheni/78477/update params with buttons for responsive * fix styles accordingly to design * buttons gap fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/resolve build errors (#21) * yauheni/resolve build errors * optional property for is_checkbox_hidden Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/78633/update styles for tick history widget (#22) * yauheni/resolve build errors * yauheni/78633/update styles for tick history widget * yauheni/78633/update styles for tick history widget responsive Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/78839/complete_sold_labels (#23) * chore: added tolltips for all sold positions & won/lost coloring * feat: finalized AccumulatorsProfitLossTooltip * maryia/improvements for stats and tooltip (#24) * chore: accumulators stats improvements * improvements * maryia/improvements for sold contract label * maryia/78574/add_barriers_to_contract_details * maryia/79085/remove_break_out_history_from_stats_widget (#26) * maryia/79085/remove_break_out_history_from_stats * chore: made purchaseButtonsOverlay flexible * chore: added tests for PurchaseButtonsOverlay * Yauheni/77995/update trade params for stayin breakout (#25) * yauheni/77995/update trade params for stayin breakout * take profit alimngment * buttons styles, take profit alingment * maryia/78574/add_barriers_to_contract_details * stake font and icon fix, go_tp_reports button styles * update contract store from parent Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: maryia-binary <maryia@binary.com> * maryia/fix: styles & fonts for responsive trade types * Maryia/79549/part 1: update tick markers for ACCU in contract details + improvements (#27) * maryia/79549/add_tick_markers_contract_details * chore: improvements for styles in responsive trade types desc * yauheni/79530/remove breakout contract (#28) * yauheni/79530/remove breakout contract * proposal data fields fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/styling improvements * maryia/fix: forcing Div100vh to re-render when height_offset for responsive has changed * maryia/fix: observables + markers * maryia/chore: prevented barriers, labels and markers from going outside axes (#30) * maryia/79969/set_default_chart_type_and_interval_to_Area_and_1_tick * maryia/chore: changed trade type name to Accumulators * maryia/80163/set growth rate based on default value from BE contracts_for response * yauheni/80091/hide chart mode icon for accumulators (#33) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80166/connect_to_available_API (#34) * chore: connected api without contracts_for for now * chore: updated proposal * chore: updated tests for new proposal * maryia/80163/add-growth-rate-to-purchase-button * maryia/refactored purchase button growth_rate text * maryia/chore: removed unused code for outside barriers * maryia/fix: barrier shade color for ongoing contract * feat: restore chart mode set for non accumulators contract after switching (#37) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * yauheni/80158/update ui according to latest design (design flow 1-2) (#36) * icon accumulator change * purchase btn, stats fix * fix styles, flow 1 * accumulator design flow 2 Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/80686/feat: profit text animation for ongoing contract (#39) * fix: showing profit text next to current spot for open contract * chore: animated profit text * feat: added animated profit text for ongoing contract * test: fixed a test * chore: removed unused variable * fix: maryia/80686/profit text color * fix: maryia/using default growth rate only if no stored growth rate * feat: allow accumulators only for demo account (#40) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Yauheni/80158/update UI according to latest design part 2 (#38) * accu design chart position fix * accu page for reports rendering * reports card design fix * reports card design fix2 * updated design fix * pseudoelement colon fix * emphasizing value fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/80687/ticks_contract_details (#41) * fix: tick markers in contract details & take profit logics * feat: showing only 10 last ticks for accumulators ongoing contract * chore: display all trade types when list is not empty * style: typo * chore: maryia/added opacity to profit text + connected contracts_for + refactoring * chore: improved tick stream for ACCU in contract details + stats alignment * chore: maryia/handled undefined profit & updated opacity animation timing * chore: temporary dummy api connection * fix: maryia/hide profit if undefined, display if number * revert: dummi api * feat: implement last design part 1 (#43) * feat: implement last design part 1 * fix: test text fix * refactor: stats style for mobile fix Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82425/task highlight crossing tick (#42) * feat: hightlighting crossing tick * feat: sync highlighting of crossing tick based on ticks_history_stats * Maryia/83069/task: replace image with video manual (#44) * feat: replaced manual image with video + responsive stats improvement * test: fixed a test * fix: entry tick marker in dtrader * style: removed extra margin-bottom * feat: implement last design part 2 (#45) * feat: implement last design part 2 * fix: initial growth_rate added * refactor: growth_rate from contract_for delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: accu sold contract tooltip animation change (#49) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/82257/Contract Details tick markers + AccumulatorsProfitLossText refactoring (#48) * chore: saving canvas context before accu barriers are drawn and restoring when finished drawing * fix: endtime, avoid fetching history in replay, avoid 0 profit animation * chore: forcing chart reload when start_epoch changes to earlier epoch + refactored profit-text * refactor: accumulators-profit-loss-text * refactor: tooltip style and tests (#51) * refactor: tooltip style and tests * refactor: accumulator info text * refactor: profit tooltip text test add * refactor: radiogroupwithinfomobile test added * refactor: tickhistorycounter tests added * refactor: tickcounterbar test added Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/83311/Refactoring, tests, TS migration (#50) * refactor: purchase-buttons-overlay.spec.js from enzyme to jest * style: removed extra variable * refactor: from accumulator.js with chai to accumulator.spec.js with jest * refactor: removed unused dummy data * test: added tests for accumulators-stats-manual-modal.jsx * chore: improved accumulators-stats-manual-modal * refactor: incapsulated AccumulatorsChartElements in trade.jsx * fix: maryia/circleci eslint error * feat: maryia/added dark theme video manual for stats + fix for circleci * test: maryia/added tests for AccumulatorsInfoDisplay & LabeledQuantityInputMobile * chore: maryia/ address review comments + updated videos * fix: maryia/open positions: auto-select Accumulators if has open ACCU contracts * refactor: accumulatorschartelements test added (#52) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * style: maryia/apply review suggestions * style: maryia/apply review suggestions * refactor: maryia/refactoring + small improvements & adjustments * chore: add built icons file * fix: circleci tests + improvements * chore: refactoring + added loader before video manual first loads * refactor: improvements + addressed review comments * yauheni/qa checks refactoring 1 (#53) * refactor: open recent position after buying contract for mobile * fix: accu card curent stake name field * fix: popover accumulator radio group text and alignment * fix: open position accumulate column name Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: last truncated counter in responsive (#54) * Maryia/83807/stake validation (part 1) (#55) * fix: set growth_rate based on accumulator_range_list (growth_rate_range) received in contracts_for * fix: app crash caused by proposal error * chore: removed unused classname * fix: growth rate title alignment (#56) * fix: growht rate title alignment * refactor: category wrapper odd style Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * maryia/83807/fix: stake validation for ACCU broken because of barriers being set (#57) * fix: stake validation for ACCU broken because of barriers being set * fix: prevent app crash in profit table for unknown contracts * fix: check if selected growth_rate is available on symbol change (#58) * fix: able to buy multiply contract / growth rate fix BO change (#59) * fix: able to buy multiply contract / growth rate fix BO change * refactor: last contract check delete Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * revert: maryia/revert change of last_contract computed * fix: accumulator is shown for real account (#60) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * feat: make cursor not allowd for overlay (#61) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * chore: built icons.js * revert: maryia/ unnecessary bot file change * refactor: contract categories in contract-type-widget.jsx * refactor: according to pr review comments * refactor: open positions + add keys to fix console warning * fix: disable accu for real account, disable button having bought one contract (#62) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * refactor: purchase.jsx * refactor: according to pr reviews * refactor: able to buy contract per every available underlying (#63) Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Trigger Build * yauheni/85032/ fix chart issue with dots and circles Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * fix: exit spot styles * refactor: make barrier values string as on BE * fix: unable accumulators for real * maryia/refactor_accu_branch (#66) * refactor: remove unused file * refactor: refactor createTickMarkers * refactor: introduce a local variable * fix: 86705/ticks are not displayed correctly on chart in contract details * maryia/86953/build: bump up deriv-charts version to 1.1.0 + improvement (#68) * build: bump up deriv-charts version * chore: show profit only when barriers are received * test: updated mocked props * build: maryia/removed extra package-lock.jsons * evgeniy /87215/87226/ info description / glitch while switching account (#70) * fix: description * fix: disable trade params while switching account --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * henry/87329/fix: FE not showing error message when accu trading is suspended (#72) * fix: FE not showing error message when accu trading is suspended * test: empty commit --------- Co-authored-by: HENRY <henry@regentmarkets.com> * refactor: glitching fix and deleted odd css (#73) * refactor: glitching fix and deleted odd css * fix: code refactor --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> * Maryia/86616/feat: calculating accu barriers based on ticks from ticks_history (#71) * feat: calculating accu barriers based on ticks from ticks_history * chore: rounded & refactored accu barriers * refactor: added getAccumulatorBarriers for barrier calculation + fixed a test * chore: improved barriers calculations * refactor: getAccumulatorBarriers docs * refactor: getAccumulatorBarriers * fix: showing barriers only when having have ba…
niloofar-deriv
pushed a commit
that referenced
this pull request
Jul 26, 2023
…m#8907) * chore: allow idv for vanuatu jurisdiction on MT5 * chore: update document status message in jurisdiction cards regarding idv * refactor: shared util function to check idv supported resident * refactor: util function to get supported verification service * chore: added flag to check if idv is disallowed * fix: failing test cases * refactor: refactoring the condition for better readability and conciseness * refactor: nullish coalescing operator * refactor: updated type for authenticationStatusInfo util function * chore: updated conditions regarding the vanuatu idv support in cfd * chore: updated conditions regarding the vanuatu idv support in cfd * chore: minor condition update * chore: update poa condition to poi in card banner * chore: resolve review comments * chore: prevent idv for eu region selection * refactor: condition to check verification status for maltainvest in cfd * refactor: renamed status variable for better readability * refactor: renamed status variable name * chore: update jurisdiction content * chore: update jurisdiction title indicator * chore: update test case * chore: update test case for format-response * chore: update test case for cfd-poi * chore: empty commit * fix: 🐛 resolved incorrect section display (#5) * fix: failing test cases --------- Co-authored-by: Shahzaib <shahzaib@deriv.com>
niloofar-deriv
pushed a commit
that referenced
this pull request
Sep 7, 2023
* refactor: ts migration of chart loader * refactor: ts migration of screen large form and started purchase * refactor: add types in store and refcator contract * refactor: ts migaration of purchase field * refactor: ts migration of cancel deal info * refactor: ts migration of the purchase btn * refactor: cancel deal info * refactor: remove simular types * refactor: create file for types * chore: cover return value with react fragment * refactor: apply suggestions * refactor: update imports * refactor: type returned value * refactor: left an explanation of expecting ts error * Akmal / feat: migrate EmptyPortfolioMessage, ErrorComponent and Page404 in Trader package (#5) * feat: migrate Page404 to Typescript * feat: migrate EmptyPortfolioMessage to Typescript * feat: migrate ErrorComponent to Typescript * fix: dialog prop * fix: dialog type * chore: remove React.FC * maryia/WEBREL-321/feat: migrate Actions files to TS (#4) * feat: migrate /contract-type.js to ts & remove barrier.js * feat: migrate duration to ts + remove unused currency.js * feat: migrate actions/purchase to ts * feat: migrate actions/symbol to ts * feat: migrate start-date.js to ts * feat: migrate actions/test.js to ts * chore: improve types in start-date and duration * fix: address review comments * revert: unnecessary line deletion * fix: address reviews * refactor: remove some code smells * refactor: remove code smells * refactor: update types in stores * Akmal / feat: migrate utils in Trader package (#9) * feat: migrate MarketUnderlying to Typescript * feat: migrate errors to Typescript * feat: migrate error spec to Typescript * feat: migrate index to Typescript * feat: migrate validator to Typescript * feat: trigger vercel * chore: sort options alphabetically * fix: TValidationResult type * chore: prettier formatting * refactor: reduce code smells * chore: validator type improvements (#12) * Kate / DTRA-249 / Code refactoring and removing duplicated files (#13) * refactor: remove duplicated file * refactor: test improvements * fix: removed forgotten import * chore: empty commit to retrigger checks * refactor: apply suggestion * maryia/DTRA-260/TS migration of /Constants files & SmartChart/Helpers files in Trader (#6) * feat: validation-rules and ui.js to ts * chore: squash merge maryia/WEBREL-321/actions-to-TS changes * chore: added types to validation-rules.ts * chore: remove unused ui.js, migrate used ui.js and index.js to ts * chore: remove unused ui.js * chore: remove unused markers.js, and migrate barriers.js to ts * chore: added types to barriers.js and its test * test: add missing test for removeBarrier to barriers * Revert "chore: squash merge maryia/WEBREL-321/actions-to-TS changes" * feat: migrated chart-barrier-store.js to ts * feat: remove unused ChartMarkerStore * build: trigger build * fix: address review comments * henry/webrel-319/ts-migration-modules-trading-helpers-folder (#11) * fix: merge conflicts * fix: resolve comments * fix: remove comment * fix: add loadash types dependency * refactor: move error type to common props file * fix: circle CI * fix: resolve comment * fix: bug * fix: convert returntype to use ttradestore * empty commit * fix: type change * fix: resolve comments * fix: comments * maryia/861n17c54/fix: sonarcloud warnings (#14) * fix: sonarcloud warnings * fix: types * fix: resolve conflicts * refactor: apply suggestions * refactor: add last suggestion * refactor: tests * refactor: update function * refactor: add ts migration of exist tests * fix: tests * fix: test case --------- Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com>
niloofar-deriv
pushed a commit
that referenced
this pull request
Oct 13, 2023
* fix: ts-migrate trade-params * fix: sonarcloud * fix: pull in changes from tech debt 2 package * fix: resolve comments * fix: move type to common prop types * fix: move type to common prop types * fix: move type to common prop types file * fix: resolve comments * Kate / DTRA-321 / TS migration of trade-params and trade-params-mobile (#6) * refactor: migrate trade params and started mobile version * refactor: ts migration of trade params mobile * chore: add nessasary prop * refactor: apply suggestions * chore: change todo text * refactor: add import * fix: circleCI error * fix: ts migrate trade-footer-extensions.jsx * fix: fix import * fix: remove progress-slider-stream since its not used * fix: resolve comments * fix: reset with master * fix: reset with master * fix: reset with master * fix: reset with master * fix: circleCI * fix: togglePositions folder * fix: dtra-346 marketisclosed and marketcountdowntimer migration * fix: bug * Maryia/dtra-270/TS migration: trade-store (#5) * chore: prepare for migration * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: migrated trade-store to ts * chore: improve types in trade-store * fix: type * revert: hooks package installation * refactor: address review * fix: resolve comments * feat: add ts migartion of store * refactor: add prev changes * chore: empty commit * fix: add lost mocked * fix: resolve comments * Kate / DTRA-354 / Components/Form/Purchase files in Trader package (#21) * refactor: ts migartion of purchase files * refactor: remove duplicated types * refactor: apply suggestions * maryia/fix: sonarcloud warnings (#7) * fix: sonarcloud warnings * fix: Unexpected end of JSON input * fix: bug * fix: sonarcloud * fix: reorder props * fix: test cases * fix: coveralls * fix: coveralls * fix: this component doesnt exist anymore, hence test was also removed * henry/dtra-356/fix: ts-migration-digitsJSX (#24) * fix: initial commit * fix: ts migrate digits JSX * fix: small type change * fix: comment * chore: removed unused state * Maryia/dtra-355/Migrate ContractDrawer files to TS (#22) * feat: migrated swipeable-components to TS * feat: migrated market-closed-contract-overlay & index to TS * chore: migrated contract-drawer-card.tsx to ts * build: fix type * chore: migrated contract-drawer to ts * chore: fixed existing types in digits and logic * chore: sort types properties in alphabetical order * Kate/dtra 357/ts contract audit files (#23) * refactor: apply suggestion from prev pr * refactor: start ts migration of contract audit * chore: change comment * refactor: ts of contract audit item * refactor: ts migration of contract details * refactor: ts migration of contract history * refactor: add preprepared types * refactor: tests * chore: apply nit * refactor: apply suggestions * refactor: apply suggestions * chore: fix of sonar cloud * Maryia/dtra-373/remove localize from ContractCardHeader component (#25) * refactor: remove localize from contract-card-header * refactor: use Localize component instead of localize helper * build: install RTL deps in shared package * fix: sonar cloud codesmells * fix: build TS errors (#32) * refactor: tests * fix: more conflicts * chore: empty commit * maryia/fix: type issues on package 4 (#41) * fix: type issues * chore: file change from package 3 * chore: keep small changes from package 3 * chore: removed unnecessary todo comment * refactor: apply suggestions * fix: types in tests * fix: test extention * fix: wallet file * fix: add turbos to types --------- Co-authored-by: Henry Hein <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
niloofar-deriv
pushed a commit
that referenced
this pull request
Oct 13, 2023
* fix: ts-migrate trade-params * fix: sonarcloud * fix: pull in changes from tech debt 2 package * fix: resolve comments * fix: move type to common prop types * fix: move type to common prop types * fix: move type to common prop types file * fix: resolve comments * Kate / DTRA-321 / TS migration of trade-params and trade-params-mobile (#6) * refactor: migrate trade params and started mobile version * refactor: ts migration of trade params mobile * chore: add nessasary prop * refactor: apply suggestions * chore: change todo text * refactor: add import * fix: circleCI error * fix: ts migrate trade-footer-extensions.jsx * fix: fix import * fix: remove progress-slider-stream since its not used * fix: resolve comments * fix: reset with master * fix: reset with master * fix: reset with master * fix: reset with master * fix: circleCI * fix: togglePositions folder * fix: dtra-346 marketisclosed and marketcountdowntimer migration * fix: bug * Maryia/dtra-270/TS migration: trade-store (#5) * chore: prepare for migration * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: add more types to trade-store * chore: migrated trade-store to ts * chore: improve types in trade-store * fix: type * revert: hooks package installation * refactor: address review * fix: resolve comments * feat: add ts migartion of store * refactor: add prev changes * chore: empty commit * fix: add lost mocked * fix: resolve comments * Kate / DTRA-354 / Components/Form/Purchase files in Trader package (#21) * refactor: ts migartion of purchase files * refactor: remove duplicated types * refactor: apply suggestions * maryia/fix: sonarcloud warnings (#7) * fix: sonarcloud warnings * fix: Unexpected end of JSON input * fix: bug * fix: sonarcloud * fix: reorder props * fix: test cases * fix: coveralls * fix: coveralls * fix: this component doesnt exist anymore, hence test was also removed * henry/dtra-356/fix: ts-migration-digitsJSX (#24) * fix: initial commit * fix: ts migrate digits JSX * fix: small type change * fix: comment * chore: removed unused state * Maryia/dtra-355/Migrate ContractDrawer files to TS (#22) * feat: migrated swipeable-components to TS * feat: migrated market-closed-contract-overlay & index to TS * chore: migrated contract-drawer-card.tsx to ts * build: fix type * chore: migrated contract-drawer to ts * chore: fixed existing types in digits and logic * chore: sort types properties in alphabetical order * Kate/dtra 357/ts contract audit files (#23) * refactor: apply suggestion from prev pr * refactor: start ts migration of contract audit * chore: change comment * refactor: ts of contract audit item * refactor: ts migration of contract details * refactor: ts migration of contract history * refactor: add preprepared types * refactor: tests * chore: apply nit * refactor: apply suggestions * refactor: apply suggestions * chore: fix of sonar cloud * Maryia/dtra-373/remove localize from ContractCardHeader component (#25) * refactor: remove localize from contract-card-header * refactor: use Localize component instead of localize helper * build: install RTL deps in shared package * feat: merge previous tech debt branch * fix: sonar cloud codesmells * Merge branch kate/ts_migration_trader_package_4 into kate/ts_migration_trader_package_5 * Kate / DTRA-378 / TS migration: Multiplier components and containers in Trader package (#26) * refactor: ts of cancel deal and risk managment info * fix: types in dialog tsx * refactor: start ts of multiplier options * refactor: ts of mult amount modal * refactor: remove default val from basis component * fix: type of amount mobile * refactor: applied suggestions * refactor: ts of multiplier info (#28) * Henry/dtra 376/fix: ts migration positionsdrawer folder (#27) * fix: positions drawer folder * fix: coveralls * fix: where is my commit * fix: found commits * fix: file rename * fix: comments * fix: comments * fix: correct logic * fix: remove unused props * fix: types * refactor: remove code mells * fix: ts-migrate-populate header (#30) * Maryia/DTRA-377/TS migration: TradingDatePicker + TradingTimePicker + TimePicker + Dialog (#29) * chore: timepicker to ts * chore: trading timepicker to ts * chore: add types for TradingDatePicker & DatePicker * refactor: added default values * refactor: remove code small * chore: empty commit * fix: not using index as key (#31) * fix: ternary bug * fix: build TS errors (#32) * refactor: apply suggestions * refactor: change type of time * chore: empty commit * refactor: tests * fix: conflicts * fix: conflicts * fix: tests * fix: types in tests * fix: test extention * fix: add turbos to types back * fix: add backup for target name * fix: revert empty strings --------- Co-authored-by: Henry Hein <henry@regentmarkets.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change