BUGFIX - Correct issues in delete items in list

[corentin-soriano]

Commit "Avoid duplicate items in list after a delete":

Commit "Delete by id instead of key to gain reliability": #4224

• The item key can be duplicated in database.
• The imported items all have a key of -1.
• The item id is the primary key, so it can't be null or duplicate. It's more reliable.

[nilsteampassnet]

Thank you

[FengZh61]

I also encountered this problem in version 3.1.2.45, when I imported the data through the csv file, the value of item_key was -1, and I also found that the value of created_at was null, I solved the problem of the value of item_key being -1 by modifying the incoming sql, but from the data structure of the datasheet, the value of item_key was not guaranteed unique, if item_key is duplicated, will I encounter problems in other scenarios?

The fix to avoid duplicate items in the list after deletion is great!

[corentin-soriano]

@FengZh61 My bad, little mistake in https://github.com/nilsteampassnet/TeamPass/pull/4273/files#diff-1139f18c144af50ac2f79fa33a40e72d5209d055b98c04ea5351f7832e76cd9a

Can you test this fix? #4322

[FengZh61]

@FengZh61 My bad, little mistake in https://github.com/nilsteampassnet/TeamPass/pull/4273/files#diff-1139f18c144af50ac2f79fa33a40e72d5209d055b98c04ea5351f7832e76cd9a

Can you test this fix? #4322

I'm not very proficient with git, I'll post my modifications, feel free to discuss.

• sources/import.queries.php#L378
  Add the following fields

 'item_key' => uniqidReal(50),
 'created_at' => time(),

The purpose of this part of the modification is to assign a value to the item_key so that it will not be -1, and to assign a value to the creation time, which is null by default.

• sources/items.queries.php#L2215
  Add the following fields

 $aSet = array();
 //$aSet['created_at'] = time();
       foreach ($originalRecord as $key => $value) {
             $aSet['created_at'] = time();
             $aSet['item_key'] = uniqidReal(50);
             if ($key === 'id_tree') {

This part of the modification is mainly to avoid the problem of duplicate item_key when copying the item.