Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX - Avoid break tp.config.php file with single quote in parameter value. #4231

Merged
merged 2 commits into from
Aug 25, 2024
Merged

BUGFIX - Avoid break tp.config.php file with single quote in parameter value. #4231

merged 2 commits into from
Aug 25, 2024

Conversation

corentin-soriano
Copy link
Contributor

@corentin-soriano corentin-soriano commented Jun 24, 2024 •
edited
Loading

POC:
image

tp.config.php:
image

HTTP 500:
image

And use htmlspecialchars on options page to avoid this:
image

@corentin-soriano corentin-soriano changed the title Avoid break tp.config.php file with single quote in parameter value. BUGFIX - Avoid break tp.config.php file with single quote in parameter value. Jun 24, 2024
@nilsteampassnet nilsteampassnet merged commit 6f852dd into nilsteampassnet:master Aug 25, 2024
2 of 3 checks passed
@nilsteampassnet
Copy link
Owner

NIce ... thank you

nilsteampassnet added a commit that referenced this pull request Aug 25, 2024
@nilsteampassnet
3.1.2
a78b846 
Merged PRs by @corentin-soriano: #4293 #4286 #4285 #4282 #4280 #4268 #4262 #4257 #4256 #4255 #4254 #4240 #4239 #4238 #4237 #4236 #4235 #4234 #4231 #4230 #4228 #4223 #4222 #4206 #4206
Merged PR by @rokx: #4220
Merge PR by @simonpoess: #4185
@corentin-soriano corentin-soriano deleted the addslashes_config branch September 20, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corentin-soriano @nilsteampassnet