mirtypes: fix regression with cyclic generic object types #1398
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix cyclic generic object types instantiated with tuple types as one
of the arguments causing C compiler errors under some circumstances.
Details
mirtypes
now usessighashes
, which isable to handle cyclic types
Obj[(int,)]
andObj[tuple[x: int]]
were not beingmerged into one when
Obj
is cyclicwhen the type has hooks (explicit or synthesized) that are called