mirtypes: fix regression with cyclic generic object types #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix cyclic generic object types instantiated with tuple names as arguments causing C compiler errors in some circumstances. Details ======= * the type merging logic in `mirtypes` now uses `sighashes`, which is able to handle cyclic types * previously, `Obj[(int,)]` and `Obj[tuple[x: int]]` were not being merged into one when `Obj` is cyclic * this led to C compiler errors when assigning between such types, or when the type has hooks (explicit or synthesized) that are called
`vmtypegen` doesn't yet use the MIR type IR, meaning that it's oblivious to the canoniclization.
zerbina
added
bug
saem
approved these changes
Aug 5, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix cyclic generic object types instantiated with tuple types as one
of the arguments causing C compiler errors under some circumstances.
Details
mirtypesnow usessighashes, which isable to handle cyclic types
Obj[(int,)]andObj[tuple[x: int]]were not beingmerged into one when
Objis cyclicwhen the type has hooks (explicit or synthesized) that are called