Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirtypes: fix regression with cyclic generic object types #1398

Merged
merged 2 commits into from
Aug 5, 2024
Merged

mirtypes: fix regression with cyclic generic object types #1398

merged 2 commits into from
Aug 5, 2024

Commits on Aug 5, 2024

  1. mirtypes: fix regression with cyclic generic object types 

    Summary
=======

Fix cyclic generic object types instantiated with tuple names as
arguments causing C compiler errors in some circumstances.

Details
=======

* the type merging logic in `mirtypes` now uses `sighashes`, which is
  able to handle cyclic types
* previously, `Obj[(int,)]` and `Obj[tuple[x: int]]` were not being
  merged into one when `Obj` is cyclic
* this led to C compiler errors when assigning between such types, or
  when the type has hooks (explicit or synthesized) that are called
    @zerbina
    zerbina committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3fee561 View commit details
    Browse the repository at this point in the history

  2. tests: mark test as knownIssue for the VM 

    `vmtypegen` doesn't yet use the MIR type IR, meaning that it's
oblivious to the canoniclization.
    @zerbina
    zerbina committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c98a629 View commit details
    Browse the repository at this point in the history