Deal with remaining disabled tests #71

canelhasmateus · 2021-11-21T18:21:38Z

No description provided.

tests/assign/toverload_asgn2.nim

tests/bind/tdatabind.nim

tests/closure/texplicit_dummy_closure.nim

tests/cpp/tdont_init_instantiation.nim

tests/effects/toutparam.nim

tests/compiler/tdebugutils.nim

tests/generics/toverloading_typedesc.nim

tests/global/tglobal.nim

tests/iter/titerable.nim

tests/iter/tscheduler.nim

tests/method/tmultim.nim

tests/method/tmultimjs.nim

tests/misc/tdllvar.nim

tests/misc/tgenconstraints.nim

tests/misc/tmissingnilcheck.nim

tests/misc/tunsignedcomp.nim

tests/modules/tnotuniquename2.nim

tests/modules/trecmod.nim

tests/navigator/tincludefile.nim

tests/objects/tobjpragma.nim

tests/parallel/t5000.nim

tests/parallel/treadafterwrite.nim

tests/pragmas/tpragmas_misc.nim

tests/system/t7894.nim

tests/system/tio.nim

tests/template/tmodulealias.nim

tests/typerel/tno_gcmem_in_shared.nim

tests/typerel/trectuple.nim

tests/typerel/trectype.nim

tests/types/tisop.nim

canelhasmateus · 2021-11-21T19:05:25Z

@saem moved that info into a more digestible form here

saem

Most of the way through review, but here are the interim items.

tests/assign/toverload_asgn2.nim

tests/bind/tdatabind.nim

tests/closure/texplicit_dummy_closure.nim

tests/compiler/tdebugutils.nim

tests/cpp/tdont_init_instantiation.nim

tests/method/tmultimjs.nim

tests/misc/tdllvar.nim

tests/misc/tgenconstraints.nim

tests/misc/tmissingnilcheck.nim

tests/misc/tunsignedcomp.nim

saem

Wrapped up this pass

tests/objects/tobjpragma.nim

tests/parallel/t5000.nim

tests/parallel/treadafterwrite.nim

tests/pragmas/tpragmas_misc.nim

tests/stdlib/tparsopt.nim

tests/template/tmodulealias.nim

tests/typerel/tno_gcmem_in_shared.nim

tests/typerel/trectuple.nim

tests/typerel/trectype.nim

tests/types/tisop.nim

tests/assign/toverload_asgn2.nim

canelhasmateus · 2021-12-09T23:47:31Z

tdebugutils.nim was deleted in another , unrelated commit.

Remaining issues are:
t7894.nim, which makes CI grumpy.
tdllvar.nim
tisop.nim, which probably is covered by some other specs.
tpragmas_misc.nim

canelhasmateus · 2021-12-09T23:59:42Z

I'll create a comprehensive commit message, detailing the changes and reasonings to each file, and this should be ready to merge, unless we can deal with the remaining problematic tests.
If so, we can for sure remove the 'disabled' keyword from the testament spec.
Sorry about the delay, work got me by the balls.

…he test suite, and remove the 'disabled' keyword from the testament spec. In the first commit, we added the new knownIssue key to the testament spec, while also adding knownIssues to many of the tests for which we could attribute an issue. In this commit, we almost finish the task of removing the 'disabled' keyword from the remaining tests. Below are the changes and reasonings behind them: Removed Due to old or removed features: tdatabind.nim texplicit_dummy_closure.nim tgenconstraints.nim tincludefile.nim tmodulealias.nim tno_gcmem_in_shared.nim tnotuniquename2.nim tscheduler.nim Removed due to being Half Baked or Non-sensical: tio.nim tmissingnilcheck.nim treadafterwrite.nim trecmod.nim tunsignedcomp.nim Removed due to not being worth the trouble: t5000.nim Removed due to being redundant: tisop.nim Keeping disabled, due to being unsure: t7894.nim - Works, but flaky, and makes CI servers grumpy. tdllvar.nim tpragmas_misc.nim Added knownIssues - Mostly textual descriptions, due to not having a explicit issues: tdont_init_instantiation.nim titerable.nim toutparam.nim toverload_asgn2.nim tparsopt.nim Re-enabled: tglobal.nim tmultim.nim tmultimjs.nim tobjpragma.nim toverloading_typedesc.nim Fixed trectuple.nim: Fixed the line number. trectype.nim : Fixed to the spec.

saem

bors r+

🎉

bors · 2021-12-12T03:28:09Z

Build succeeded:

canelhasmateus changed the title ~~disabled trues~~ Deal with remaining disabled tests Nov 21, 2021