Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Set TemplateFlow directory world-writeable #1501

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 8, 2019

Changes proposed in this pull request

No real way to test this until merged, built and pushed to poldracklab/fmriprep:unstable to build a Singularity image off of.

Fixes #1500.

Documentation that should be reviewed

@effigies effigies requested a review from oesteban February 8, 2019 15:28
@oesteban
Copy link
Member

oesteban commented Feb 8, 2019

Should we reset a more restrictive umask after templateflow is installed?

@effigies
Copy link
Member Author

effigies commented Feb 8, 2019

umask is local to the shell process. By my understanding, each RUN command is run in an independent shell. That's why Docker has ENV a=b instead of RUN export a=b.

@effigies
Copy link
Member Author

effigies commented Feb 8, 2019

Dockerfile:

FROM alpine:3.6

RUN umask
RUN umask 000 && umask
RUN umask
$ docker build -t umask_test .
Sending build context to Docker daemon  2.048kB
Step 1/4 : FROM alpine:3.6
 ---> 77144d8c6bdc
Step 2/4 : RUN umask
 ---> Running in 621ee0185ae2
0022
Removing intermediate container 621ee0185ae2
 ---> 4e9d5b8e4b0c
Step 3/4 : RUN umask 000 && umask
 ---> Running in b64027ef68ce
0000
Removing intermediate container b64027ef68ce
 ---> f6839a900a24
Step 4/4 : RUN umask
 ---> Running in f0e2dab2abfc
0022
Removing intermediate container f0e2dab2abfc
 ---> 9e338df90910
Successfully built 9e338df90910
Successfully tagged umask_test:latest

@effigies
Copy link
Member Author

effigies commented Feb 8, 2019

Going to merge rather than wait forever on the anatomical workflows to recache.

@effigies effigies merged commit b30568c into nipreps:master Feb 8, 2019
@effigies effigies deleted the fix/template_flow_permissions branch February 8, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TemplateFlow permissions error in 1.3.0
2 participants