Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Implement BIDS filters file and drop legacy BIDS querying #1154

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

oesteban
Copy link
Member

@oesteban oesteban commented Nov 14, 2023

Requires: nipreps/niworkflows#833.

Resolves: #760 .

@oesteban oesteban force-pushed the fix/drop-legacy-bids-querying branch 3 times, most recently from 848801c to 47d365c Compare November 14, 2023 15:49
mriqc/cli/parser.py Outdated Show resolved Hide resolved
@oesteban oesteban changed the title ENH: Drop legacy BIDS querying in favor of *NiWorkflows*' ENH: Implement BIDS filters file and drop legacy BIDS querying Nov 15, 2023
oesteban and others added 2 commits November 15, 2023 11:20
Resolves: #760.

Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@oesteban oesteban force-pushed the fix/drop-legacy-bids-querying branch from 5a5386b to 0aec011 Compare November 15, 2023 10:20
@oesteban oesteban merged commit 309a54c into master Nov 15, 2023
13 of 14 checks passed
@oesteban oesteban deleted the fix/drop-legacy-bids-querying branch November 15, 2023 16:39
@Remi-Gau
Copy link

@oesteban
random question: quick look at the code makes me think this only works at the individual level, no?
if one wanted to use the bids filter to make group summary plot of only a subset of images, this filtering would not work, right?

@oesteban
Copy link
Member Author

quick look at the code makes me think this only works at the individual level, no?

Correct

if one wanted to use the bids filter to make group summary plot of only a subset of images, this filtering would not work, right?

This would be a good idea, but as you expect, it will not work ATM. However, it is definitely a good idea for any takers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: filter input dataset by other ids
3 participants