FIX: Add DWI to the default queries of BIDS querying #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Nov 14, 2023
| @@ -223,19 +237,10 @@ def collect_data( | |||
| 'return_type': 'file', | |||
| 'subject': participant_label, | |||
| 'extension': ['.nii', '.nii.gz'], | |||
| 'session': session_id, | |||
| 'session': session_id or Query.OPTIONAL, | |||
There was a problem hiding this comment.
This changes the meaning of None from Query.NONE, which diverges from pybids semantics. I think that's an okay change, but we should check that we never use None in that way now.
There was a problem hiding this comment.
You are right, didn't think of it. Considering that single session and multisession datasets cannot be mixed up in BIDS, I agree this should be okay.
oesteban
added a commit
to nipreps/mriqc
that referenced
this pull request
Nov 14, 2023
mgxd
approved these changes
Nov 14, 2023
effigies
reviewed
Nov 14, 2023
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
oesteban
commented
Nov 14, 2023
effigies
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds DWI to the queriable suffixes, and also opens a possibility to modify the default queries.