Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Bump to later release of svgutils, small API change #619

Closed
wants to merge 2 commits into from

Conversation

mgxd
Copy link
Contributor

@mgxd mgxd commented Feb 10, 2021

Originally discussed in #595 (comment)

Sets the minimum version of svgutils to 1.3.4 to avoid try/except shenanigans.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Consider this also a +1 for an immediate patch release.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #619 (50ee8a5) into maint/1.3.x (4d9b741) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           maint/1.3.x     #619   +/-   ##
============================================
  Coverage        46.94%   46.94%           
============================================
  Files               43       43           
  Lines             5287     5287           
  Branches           770      770           
============================================
  Hits              2482     2482           
  Misses            2721     2721           
  Partials            84       84           
Flag Coverage Δ
documentation 0.00% <0.00%> (ø)
reportlettests 100.00% <ø> (ø)
unittests 47.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/viz/utils.py 9.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9b741...50ee8a5. Read the comment docs.

@mgxd
Copy link
Contributor Author

mgxd commented Feb 11, 2021

Comparing reports, there's a size discrepancy on some reports:

testFAST_nosegments.svg this patch

testFAST_nosegments.svg master

@mgxd
Copy link
Contributor Author

mgxd commented Feb 11, 2021

Closing this to avoid altering LTS images. Patch will be applied for next minor series.

@mgxd mgxd closed this Feb 11, 2021
@mgxd mgxd deleted the fix/svgutils-api branch February 11, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants