ENH: Add PrepareDerivative/SaveDerivative interfaces #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 70.95% 71.57% +0.62%
==========================================
Files 87 87
Lines 8231 8437 +206
Branches 950 994 +44
==========================================
+ Hits 5840 6039 +199
- Misses 2384 2390 +6
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
mgxd
reviewed
Jul 29, 2024
These are intended to break DerivativesDataSink functionality into separable components and avoid unnecessary writes that cause invalidation of downstream nodes.
effigies
force-pushed
the
rf/split-derivatives-datasink
branch
from
597f926
to
23e1bbc
Compare
Co-authored-by: Mathias Goncalves <goncalves.mathias@gmail.com>
effigies
commented
Jul 29, 2024
effigies
force-pushed
the
rf/split-derivatives-datasink
branch
from
4489a68
to
8c14cbe
Compare
|
@mgxd I think this is ready to go. I expanded the tests to check everything we were checking with |
|
Yup, looks good to me! |
mgxd
added a commit
that referenced
this pull request
Jul 31, 2024
1.11.0 (July 31, 2024) New minor release to start the 1.11.x series. The major changes include: - a deprecation to T1w-only based template processing - addition of a new dependency ``acres`` for accessing package data However, this is still backwards compatible with the 1.10.x series. * MAINT: Depend on acres for data access * ENH: Add PrepareDerivative/SaveDerivative interfaces (#885) * ENH: Make template dimensions support T2w as well (#879) * ENH: Modify FSSource to output T2 (#868) * FIX: Set cal_max in the NIfTI header for visualization after ``IntensityClip`` (#878) * FIX: Remove accidental MRIQC dependency, allow app config to be passed to workflow plugin (#876) * TEST: Fix plugin invocation, use an initializer that can be verified (#880)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are intended to break DerivativesDataSink functionality into separable components and avoid unnecessary writes that cause invalidation of downstream nodes.
Tests forthcoming.