Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add data loader to sdcflows.data, drop pkg_resources #379

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

effigies
Copy link
Member

Translating nipreps/niworkflows#816.

Closes #377.

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oesteban
oesteban previously approved these changes Jul 11, 2023
sdcflows/workflows/fit/pepolar.py Outdated Show resolved Hide resolved
sdcflows/workflows/fit/syn.py Outdated Show resolved Hide resolved
@oesteban oesteban enabled auto-merge July 11, 2023 13:11
@oesteban oesteban merged commit 82b6266 into nipreps:master Jul 11, 2023
@oesteban
Copy link
Member

Sorry, I didn't expect the auto-merge to kick in without waiting for all tests to pass...

@effigies
Copy link
Member Author

Thanks for the fixups. I keep forgetting how many Nipype components are Path-unaware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pkg_resources.resource_filename to locate data files
2 participants