Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Hard-wire MNI152NLin2009cAsym as standard space for SDC-SyN #63

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

oesteban
Copy link
Member

Continuing with #55, this PR re-enables SDC-SyN to work with fMRIPrep.

@@ -153,6 +151,8 @@ def init_syn_sdc_wf(omp_nthreads, epi_pe=None,
# 1) BOLD -> T1; 2) MNI -> T1; 3) ATLAS -> MNI
transform_list = pe.Node(niu.Merge(3), name='transform_list',
mem_gb=DEFAULT_MEMORY_MIN_GB)
transform_list.inputs.in3 = resource_filename(
'sdcflows', 'data/fmap_atlas_2_MNI152NLin2009cAsym_affine.mat')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reality, we only have this pre-calculated affine, so offering to switch was asking for trouble.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Without a plan to calculate an alternative, or bundling one for each template in templateflow, it doesn't make much sense to enable this flexibility.

We can revisit, if that ever seems like a good idea.

@oesteban oesteban merged commit 40ed9f8 into nipreps:master Nov 27, 2019
@oesteban oesteban deleted the fix/sdc-syn branch November 27, 2019 20:37
oesteban added a commit to oesteban/sdcflows that referenced this pull request Oct 23, 2020
This PR attempts to provide a more reliable framework to build
fieldmap estimation workflows.
Implicitly, it will help addressing issues regarding data conformity
(e.g., nipreps#63, nipreps#64, nipreps#65) and also ease larger refactors such as #20, nipreps#21,
 nipreps#26, and nipreps#101.
oesteban added a commit to oesteban/sdcflows that referenced this pull request Oct 23, 2020
This PR attempts to provide a more reliable framework to build
fieldmap estimation workflows.
Implicitly, it will help addressing issues regarding data conformity
(e.g., nipreps#63, nipreps#64, nipreps#65) and also ease larger refactors such as #20, nipreps#21,
 nipreps#26, and nipreps#101.
oesteban added a commit to oesteban/sdcflows that referenced this pull request Oct 26, 2020
This PR attempts to provide a more reliable framework to build
fieldmap estimation workflows.
Implicitly, it will help addressing issues regarding data conformity
(e.g., nipreps#63, nipreps#64, nipreps#65) and also ease larger refactors such as #20, nipreps#21,
 nipreps#26, and nipreps#101.
oesteban added a commit to oesteban/sdcflows that referenced this pull request Nov 14, 2020
This PR attempts to provide a more reliable framework to build
fieldmap estimation workflows.
Implicitly, it will help addressing issues regarding data conformity
(e.g., nipreps#63, nipreps#64, nipreps#65) and also ease larger refactors such as #20, nipreps#21,
 nipreps#26, and nipreps#101.
oesteban added a commit to oesteban/sdcflows that referenced this pull request Nov 18, 2020
This PR attempts to provide a more reliable framework to build
fieldmap estimation workflows.
Implicitly, it will help addressing issues regarding data conformity
(e.g., nipreps#63, nipreps#64, nipreps#65) and also ease larger refactors such as #20, nipreps#21,
 nipreps#26, and nipreps#101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants