Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cache_dir instead of output_dir #538

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

montesmariana
Copy link
Contributor

Types of changes

Summary

Add the option of specifying the output directory for the dotfile (the graph of a workflow) and when it is not specified, use cache_dir instead of output_dir (because when there is splitting the output_dir attribute is a list of paths instead of a path).

Checklist

I have not added tests or updated documentation (there is no much original documentation on this method that I could find)

@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #538 (2e04ffc) into master (726d242) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #538   +/-   ##
=======================================
  Coverage   76.98%   76.98%           
=======================================
  Files          20       20           
  Lines        4279     4280    +1     
  Branches     1204     1204           
=======================================
+ Hits         3294     3295    +1     
  Misses        799      799           
  Partials      186      186           
Flag Coverage Δ
unittests 76.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/core.py 88.95% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726d242...2e04ffc. Read the comment docs.

@djarecka
Copy link
Collaborator

djarecka commented Dec 1, 2022

@montesmariana - I'm sorry, I completely missed this PR... Thank you so much for fixing it!

I will merge it, but could you please add your name to the zenodo file. We haven't kept any particular order, but please just keep Satra Ghosh as the last author.

@djarecka djarecka merged commit a9ef35f into nipype:master Dec 1, 2022
@djarecka djarecka mentioned this pull request Dec 1, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants