Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph test #603

Merged
merged 6 commits into from
Dec 2, 2022
Merged

Graph test #603

merged 6 commits into from
Dec 2, 2022

Conversation

djarecka
Copy link
Collaborator

@djarecka djarecka commented Dec 1, 2022

Summary

  • adding test for plotting graph for workflow when workflow has a splitter (test for changes from use cache_dir instead of output_dir #538)
  • small fix of Docker/Singularity tasks: name=None in init
  • marking one test as flaky for slurm

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 76.82% // Head: 76.82% // No change to project coverage 👍

Coverage data is based on head (986d539) compared to base (a9ef35f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #603   +/-   ##
=======================================
  Coverage   76.82%   76.82%           
=======================================
  Files          19       19           
  Lines        4358     4358           
  Branches     1258     1258           
=======================================
  Hits         3348     3348           
  Misses        821      821           
  Partials      189      189           
Flag Coverage Δ
unittests 76.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/task.py 86.76% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djarecka djarecka merged commit 66919ab into nipype:master Dec 2, 2022
@djarecka djarecka deleted the graph_test branch December 30, 2022 20:32
@djarecka djarecka restored the graph_test branch December 30, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant