fix: await on send() calls (#1701)

nitrojs · Sep 7, 2023 · a228372 · a228372
1 parent 0099df2
commit a228372
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/dev/error.ts b/src/dev/error.ts
@@ -23,7 +23,7 @@ function errorHandler(error: any, event: H3Event) {
       "<progress></progress><script>document.querySelector('progress').indeterminate=true</script>";
   }
 
-  send(
+  return send(
     event,
     `<!DOCTYPE html>
   <html lang="en">

diff --git a/src/runtime/error.ts b/src/runtime/error.ts
@@ -46,10 +46,10 @@ export default <NitroErrorHandler>function (error, event) {
 
   if (isJsonRequest(event)) {
     setResponseHeader(event, "Content-Type", "application/json");
-    send(event, JSON.stringify(errorObject));
+    return send(event, JSON.stringify(errorObject));
   } else {
     setResponseHeader(event, "Content-Type", "text/html");
-    send(event, renderHTMLError(errorObject));
+    return send(event, renderHTMLError(errorObject));
   }
 };
 

diff --git a/src/runtime/renderer.ts b/src/runtime/renderer.ts
@@ -25,11 +25,10 @@ export function defineRenderHandler(handler: RenderHandler) {
     // TODO: Use serve-placeholder
     if (event.path.endsWith("/favicon.ico")) {
       setResponseHeader(event, "Content-Type", "image/x-icon");
-      send(
+      return send(
         event,
         "data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"
       );
-      return;
     }
 
     const response = await handler(event);