Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: await on send() calls #1701

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: await on send() calls #1701

merged 1 commit into from
Sep 7, 2023

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 7, 2023

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If not chaining send calls, h3 app may wrongly show 404 pages while response is being sent in next tick.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title fix: chain send() calls fix: await on send() calls Sep 7, 2023
@pi0 pi0 merged commit a228372 into main Sep 7, 2023
7 checks passed
@pi0 pi0 deleted the fix/dev-error branch September 7, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant