feat: fixed documentation #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kranzes
requested changes
May 2, 2024
README.md
Outdated
| @@ -29,6 +29,8 @@ If you are using flakes to configure your system, add to your nixpkgs overlays a | |||
| { | |||
| nixpkgs.overlays = overlays; | |||
| }; | |||
| #replace the configuration code segment above with the following if running nixos unstable: | |||
There was a problem hiding this comment.
Since 22.11 this is the way to do it, you should just replace the entire configuration part, replace it with modules and remove the comment.
|
sorry I have not been the best on responding, I have finals. Thought I should let you know why I was not working on this |
|
I have done the requested changes locally, how can I show those changes here in this pull request? |
|
Commit and push? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation had a deprecated argument in the home-manager example by using configuration, this aims to fix that by providing an example of how to fix it in the current nixos unstable branch(which at the time of writting is 24.05), through a comment.