Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed documentation #524

Merged
merged 1 commit into from
May 26, 2024
Merged

feat: fixed documentation #524

merged 1 commit into from
May 26, 2024

Conversation

GaetanLepage
Copy link
Member

@GaetanLepage GaetanLepage commented May 24, 2024

I closed #497 by error.
cc @DockterTeagle


The documentation had a deprecated argument in the home-manager example by using configuration, this aims to fix that by providing an example of how to fix it in the current nixos unstable branch(which at the time of writting is 24.05), through a comment.

Fixes #496

@GaetanLepage GaetanLepage requested a review from Kranzes May 24, 2024 21:28
@willruggiano
Copy link
Contributor

While you're at it, can you please also update the documentation per my comment in #521

@GaetanLepage GaetanLepage force-pushed the readme-overlay branch 2 times, most recently from 2124683 to 2f9e478 Compare May 26, 2024 17:45
@GaetanLepage
Copy link
Member Author

While you're at it, can you please also update the documentation per my comment in #521

Is that still relevant ?
The package should now build fine "no matter" what (unstable) channel people are using.
You want to warn them nonetheless that it is at their own risk to override the nixpkgs input of the overlay flake ?

The documentation had a deprecated argument in the home-manager example
by using configuration, this aims to fix that by providing an example of
how to fix it in the current nixos unstable branch(which at the time of
writting is 24.05), through a comment.
@willruggiano
Copy link
Contributor

While you're at it, can you please also update the documentation per my comment in #521

Is that still relevant ? The package should now build fine "no matter" what (unstable) channel people are using. You want to warn them nonetheless that it is at their own risk to override the nixpkgs input of the overlay flake ?

Still relevant, but probably worth a pinned github issue rather than in the README. I will do this. Note that "package should now build fine" is not technically correct, it entirely depends on what version of nixpkgs is being used. But I will drop these details into the github issue.

@willruggiano willruggiano merged commit a9a2fe6 into master May 26, 2024
15 checks passed
@willruggiano willruggiano deleted the readme-overlay branch May 26, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISSUE: README.md has deprecated configuration argument
3 participants