Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new input module #123

Merged
merged 38 commits into from
Jul 28, 2024
Merged

Add new input module #123

merged 38 commits into from
Jul 28, 2024

Conversation

toast003
Copy link
Collaborator

No description provided.

@toast003
Copy link
Collaborator Author

Had a bit of a brain fart there, sorry for the force pushing

@toast003 toast003 mentioned this pull request Apr 11, 2024
Merged
@toast003
Copy link
Collaborator Author

toast003 commented Jul 1, 2024

@magnouvean I changed the write_config script a bit, since doing base conversion inside nix seems too complicated.
I am very new at python, and although my code seems to work just fine I would appreciate if you could take a look at it

@toast003
Copy link
Collaborator Author

toast003 commented Jul 1, 2024 •
edited
Loading

Also I don't think the check failing was due to something I did, not sure why
EDIT: nvm it is, I'll fix it later

@toast003 toast003 mentioned this pull request Jul 1, 2024
Merged
toast003 and others added 11 commits July 2, 2024 01:33
@toast003
Do ID hex to dec conversion in write_config.py
ba0cdea
@HeitorAugustoLN @toast003
Fix windowDecorations options description (nix-community#226)
a1dcafd
@HeitorAugustoLN @toast003
Remove the nix-community transfer snippet from the README file (nix-c…
0efa15d 
…ommunity#227)
@toast003
Replace mentions of old repo location with the new one
7be657d
@magnouvean @toast003
Add immutableByDefault option (nix-community#225)
97a4637
@magnouvean @toast003
Add some more info and some rewrites for the README (nix-community#231)
311271a
@howird @toast003
Fix marginsseparator panel widget typo (nix-community#230)
ed17ef4
@HeitorAugustoLN @toast003
Add extraWidgets option (nix-community#233)
486cfa2
@HeitorAugustoLN @toast003
Add application-title-bar widget-specific options (nix-community#234)
64960f1
@HeitorAugustoLN @toast003
Automatically install third-party widget if it is present in a panel (n…
b922fc0 
…ix-community#236)
@toast003
Remove leftover reminder and update description in input module
9062406
magnouvean
magnouvean reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@magnouvean magnouvean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really test much atm, but looking at the code in general this looks fine after the minor suggested tweaks :)

script/write_config.py Outdated Show resolved Hide resolved
script/write_config.py Outdated Show resolved Hide resolved
script/write_config.py Outdated Show resolved Hide resolved
modules/input.nix Outdated Show resolved Hide resolved
modules/input.nix Outdated Show resolved Hide resolved
@toast003
Minor write_config.py refactoring
f5584b8 
First real python code I wrote so I made some rookie mistakes
@toast003
Copy link
Collaborator Author

toast003 commented Jul 7, 2024

I will when I finish

@magnouvean
Copy link
Collaborator

I'll try to add support for configuring multiple touchpads and add some assertions today. I think I'll just commit directly here if that's OK :)

@magnouvean
Copy link
Collaborator

Imo it's more or less good enough to merge in the current state. I haven't found any issues (though I also haven't done enough testing to confirm a lot of edge-cases). There are obviously some tweaks as mentioned above such as changing the README and maybe also adding some examples.

@HeitorAugustoLN
Copy link
Member

HeitorAugustoLN commented Jul 22, 2024 •
edited
Loading

@toast003 I sent you a pull request that adds configurations for mouses in the input module.

@toast003
Copy link
Collaborator Author

You guys did all of my work 😅

@HeitorAugustoLN I'll take a look at it rn

HeitorAugustoLN and others added 4 commits July 24, 2024 15:10
@toast003
Copy link
Collaborator Author

All seems good to me!

I'll change the readme and after that I think we can merge the PR

@toast003 toast003 marked this pull request as ready for review July 24, 2024 15:57
magnouvean
magnouvean reviewed Jul 24, 2024
View reviewed changes
Copy link
Collaborator

@magnouvean magnouvean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test more right away

modules/input.nix Outdated Show resolved Hide resolved
@magnouvean
Copy link
Collaborator

But yeah other than the two minor things above this work great so we can probably merge after they are fixed :)

@magnouvean magnouvean merged commit b3b80a0 into nix-community:trunk Jul 28, 2024
1 check passed
@HeitorAugustoLN HeitorAugustoLN mentioned this pull request Jul 28, 2024
Merged
@magnouvean magnouvean mentioned this pull request Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnouvean magnouvean magnouvean left review comments

@apfelkuchen6 apfelkuchen6 apfelkuchen6 left review comments

@HeitorAugustoLN HeitorAugustoLN HeitorAugustoLN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toast003 @magnouvean @HeitorAugustoLN @apfelkuchen6 @howird