-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add known_data_files and a few more config files #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeitorAugustoLN
added
0. type: enhancement
New feature or request for feature
1. scope: rc2nix
Related to rc2nix
labels
Sep 20, 2024
…evil module (nix-community#366) This change was made to maintain consistency with other options
Just want to say I've tested and it seems to work fine on my end at the very least. The code looks good as well so I'd be happy to merge. |
HeitorAugustoLN
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works flawlessy, just needs to be formatted, because of #370
Thanks for your contribution! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0. type: enhancement
New feature or request for feature
1. scope: rc2nix
Related to rc2nix
5. approvals: 1
5. first time contribution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
programs.plasma.dataFile
inrc2nix.py