Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statvfs is not supported on ppc64/ppc64le/s390x/aarch64 #831

Closed
ignatenkobrain opened this issue Jan 7, 2018 · 3 comments
Closed

statvfs is not supported on ppc64/ppc64le/s390x/aarch64 #831

ignatenkobrain opened this issue Jan 7, 2018 · 3 comments
Labels
A-features

Comments

@ignatenkobrain
Copy link
Contributor

Any reason for this? It seems that statvfs() is available on all platforms in glibc and I don't see any restrictions on it in libc crate...
@ignatenkobrain
Copy link
Contributor Author

See stratis-storage/stratisd#708

@Susurrus
Copy link
Contributor

Susurrus commented Jan 7, 2018

Then this should be a simple fix to change the config directives to enable it. Usually if functionality is missing for a platform it's an oversight, though we do our best to make sure new features apply to all appropriate platforms.

@ignatenkobrain
Copy link
Contributor Author

@Susurrus I will double-check libc crate and will send patch here.

ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Jan 7, 2018
@ignatenkobrain
make statfs/statvfs to be available everywhere
69c509f 
libc reads statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Jan 7, 2018
@ignatenkobrain
make statfs/statvfs to be available everywhere
8600caa 
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@ignatenkobrain ignatenkobrain mentioned this issue Jan 7, 2018
Merged
ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Jan 7, 2018
@ignatenkobrain
make statfs/statvfs to be available wherever they are available
213744a 
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Jan 8, 2018
@ignatenkobrain
make statfs/statvfs to be available wherever they are available
2074ef6 
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Jan 8, 2018
@ignatenkobrain
make statfs/statvfs to be available wherever they are available
52fa9bb 
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Jan 27, 2018
@ignatenkobrain
make statfs/statvfs to be available wherever they are available
4f51859 
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Jan 28, 2018
@ignatenkobrain
make statfs/statvfs to be available wherever they are available
32a5df2 
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
ignatenkobrain added a commit to ignatenkobrain/nix that referenced this issue Feb 8, 2018
@ignatenkobrain
make statfs/statvfs to be available wherever they are available
08624d0 
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: nix-rust#831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
bors bot added a commit that referenced this issue Feb 9, 2018
@bors
Merge #832
e2c19c6 
832: make statfs/statvfs to be available everywhere r=asomers a=ignatenkobrain

libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.

Closes: #831
Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@bors bors bot closed this as completed in #832 Feb 9, 2018
@agrover agrover mentioned this issue May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Susurrus @ignatenkobrain