make statfs/statvfs to be available everywhere #832
Conversation
|
Unfortunately I can't run nix tests on those architectures because they depend on |
|
What do you mean? The nix-test crate is no longer necessary and was removed by a PR of mine a little while back. |
|
@Susurrus ah, that's because I run from latest release.. Didn't notice that. Anyway, looking at travis, it seems it broke android builds while everything else seems good |
|
I ended up sending rust-lang/libc#890 |
ignatenkobrain
force-pushed
the
statvfs
branch
from
8600caa
to
213744a
Compare
|
@Susurrus so only android fails now and PR to libc is sent. Should I temporarily guard statvfs for android here or wait for libc PR? |
|
Please wait for the libc PR to resolve. They're pretty quick with merging those things, so I'd expect it to be merged tonight. |
ignatenkobrain
force-pushed
the
statvfs
branch
2 times, most recently
from
2074ef6
to
52fa9bb
Compare
|
@Susurrus yay! now it passes! |
|
ping @Susurrus |
ignatenkobrain
force-pushed
the
statvfs
branch
from
52fa9bb
to
4f51859
Compare
|
This needs to be rebased and the CHANGELOG Added section updated. Otherwise LGTM. |
ignatenkobrain
force-pushed
the
statvfs
branch
from
4f51859
to
32a5df2
Compare
|
@Susurrus done. |
|
CI failure with the aio_drop test, @asomers didnt you just touch this code? |
|
I'm unable to reproduce the failure locally, so I restarted the offending test on Travis. However, I don't think the changelog message is accurate. Could you please change "all supported platforms" to "all OSX and Linux architectures"? |
|
I would also move the changelog entry under the "Added" section and explicitly list the platforms as @asomers said. |
|
@ignatenkobrain We're pretty close to wrapping this up. Want to address the last two comments, then we can merge? |
|
@Susurrus sorry, didn't have time to look at. Addressing it now. |
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care about. Closes: nix-rust#831 Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
ignatenkobrain
force-pushed
the
statvfs
branch
from
32a5df2
to
08624d0
Compare
|
@Susurrus pushed! |
|
LGTM bors r+ |
|
bors needs to be on its own line. bors r+ susurrus |
libc reads sys/statvfs.h on all OS except Windows which nix doesn't care
about.
Closes: #831
Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com