Add EmptyPath for FchownatFlags #1128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tathanhdinh
force-pushed
the
fchownat
branch
from
f944ee5
to
0a7c42d
Compare
|
Couldn't same thing to be done using |
|
@otavio thank you for the feedback but IMHO |
|
@tathanhdinh you got me wrong. I meant if it is worth adding this or using the |
|
Sorry, I did misunderstand your remark. |
|
The |
asomers
requested changes
Sep 28, 2019
SteveLauC
reviewed
Dec 11, 2023
Comment on lines
631
to
+635
| pub enum FchownatFlags { | ||
| FollowSymlink, | ||
| NoFollowSymlink, | ||
| #[cfg(target_os = "linux")] | ||
| EmptyPath, |
There was a problem hiding this comment.
If we add this flag, then this type should no longer be an enum but a bitflag cause you can do AT_EMPTY_PATH and AT_SYMLINK_NOFOLLOW at the same time
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is probably a fix for #1029. Thanks for any response.