-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EmptyPath for FchownatFlags #1128
Conversation
f944ee5
to
0a7c42d
Compare
Couldn't same thing to be done using |
@otavio thank you for the feedback but IMHO |
@tathanhdinh you got me wrong. I meant if it is worth adding this or using the |
Sorry, I did misunderstand your remark. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but it still needs:
- An explanation in
fchownat
's doc comment - A test
- A CHANGELOG entry
pub enum FchownatFlags { | ||
FollowSymlink, | ||
NoFollowSymlink, | ||
#[cfg(target_os = "linux")] | ||
EmptyPath, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add this flag, then this type should no longer be an enum but a bitflag cause you can do AT_EMPTY_PATH
and AT_SYMLINK_NOFOLLOW
at the same time
Hello,
This PR is probably a fix for #1029. Thanks for any response.