extend LinkatFlags to allow passing AT_EMPTY_PATH #1895
Conversation
|
Ok this does not work as is obviously because |
src/unistd.rs
Outdated
| @@ -1272,7 +1273,7 @@ pub fn linkat<P: ?Sized + NixPath>( | |||
| oldcstr.as_ptr(), | |||
| at_rawfd(newdirfd), | |||
| newcstr.as_ptr(), | |||
| atflag.bits() as libc::c_int | |||
| flags.bits() as libc::c_int | |||
There was a problem hiding this comment.
This type cast is unnecessary as flags.bits() already returns libc::c_int
There was a problem hiding this comment.
Sorry for the late review, I have left some comments.
BTW, this change needs a CHANGELOG, please see CONTRIBUTING.md on how to do it.
| pub enum LinkatFlags { | ||
| SymlinkFollow, | ||
| NoSymlinkFollow, | ||
| libc_bitflags! { |
There was a problem hiding this comment.
This type itself should be #[cfg(not(target_os = "redox"))] as the file system on redox does not support symlink
There was a problem hiding this comment.
Actually, I am not sure if we should define a new type or just use the AtFlags type.
It is safer to define a new type so that we can prevent users from passing invalid arguments, but this will add our maintainence burgen. We are already using AtFlags type for other functions like fstatat, cc @asomers, what do you think?
There was a problem hiding this comment.
Link Add EmptyPath for FchownatFlags as these 2 PRs are similar
| pub struct LinkatFlags: c_int { | ||
| #[cfg(not(target_os = "redox"))] | ||
| AT_SYMLINK_FOLLOW; | ||
| #[cfg(any(target_os = "android", target_os = "linux"))] |
There was a problem hiding this comment.
| #[cfg(any(target_os = "android", target_os = "linux"))] | |
| #[cfg(linux_android)] |
pr for #1884