conventions: Codify use of newtypes #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ```rust | ||
| pub struct SigSet(libc::sigset_t); | ||
|
|
||
| impl SigSet { |
There was a problem hiding this comment.
I'm not sure what the right thing to suggest for naming standards is though. Should this be Sigset?
There was a problem hiding this comment.
SigSet feels right to me in this case.
There was a problem hiding this comment.
I agree. So, let's add another sentence that mentions that we use the rust convention of camel case names for structs. Then we can merge this PR.
|
r? @fiveop |
kamalmarhubi
force-pushed
the
newtype-convention
branch
from
ad38efe to
dcca871
Compare
kamalmarhubi
force-pushed
the
newtype-convention
branch
from
dcca871 to
6f0bcde
Compare
|
One thing I've wondered about is pub struct SigSet {
sigset: libc::sigset_t,
}vs pub struct SigSet(libc::sigset_t);vs pub struct SigSet {
inner: libc::sigset_t,
}There's also a possibility of introducing a something like the Rust project's I brought some of this up in review of #311. |
|
📌 Commit 6f0bcde has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Mar 12, 2016
conventions: Codify use of newtypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.